From: Denis Benato <benato.denis96@gmail.com>
To: "Ilpo Järvinen" <ilpo.jarvinen@linux.intel.com>
Cc: Denis Benato <denis.benato@linux.dev>,
LKML <linux-kernel@vger.kernel.org>,
platform-driver-x86@vger.kernel.org,
Hans de Goede <hansg@kernel.org>,
"Luke D . Jones" <luke@ljones.dev>,
Mateusz Schyboll <dragonn@op.pl>
Subject: Re: [PATCH 1/3] platform/x86: asus-wmi: explicitly mark more code with CONFIG_ASUS_WMI_DEPRECATED_ATTRS
Date: Tue, 30 Dec 2025 14:53:26 +0100 [thread overview]
Message-ID: <eb0f4db5-a169-4e28-882b-346e595c81b5@gmail.com> (raw)
In-Reply-To: <9f5085e9-454f-f003-27cd-0eb86dfd9e11@linux.intel.com>
On 12/30/25 14:41, Ilpo Järvinen wrote:
> On Tue, 30 Dec 2025, Denis Benato wrote:
>> On 12/29/25 11:06, Ilpo Järvinen wrote:
>>> On Thu, 25 Dec 2025, Denis Benato wrote:
>>>
>>>> Be more explicit in code that will be excluded when compiling
>>>> with CONFIG_ASUS_WMI_DEPRECATED_ATTRS disabled.
>>> Does this result in build fails or warnings? If that's the case, it should
>>> be mentioned in the changelog + Fixes tag added.
>> Hi,
>>
>> Sadly no, despite a property in a struct instantiated only once
>> being forcefully set to false no warning is emitted by neither
>> clang nor gcc :(
> Ah, I was mainly expecting unused function warning but apparently since it
> was still being "used" it obviously won't trigger that warning.
>
Plus if gcc/clang could have catched it build bots would have done so
when posting the asus-armoury series as they catched other things.
next prev parent reply other threads:[~2025-12-30 13:53 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-12-25 14:30 [PATCH 0/3] platform/x86: asus-wmi: move keyboard control firmware attributes Denis Benato
2025-12-25 14:30 ` [PATCH 1/3] platform/x86: asus-wmi: explicitly mark more code with CONFIG_ASUS_WMI_DEPRECATED_ATTRS Denis Benato
2025-12-29 10:06 ` Ilpo Järvinen
2025-12-30 13:36 ` Denis Benato
2025-12-30 13:41 ` Ilpo Järvinen
2025-12-30 13:53 ` Denis Benato [this message]
2025-12-25 14:30 ` [PATCH 2/3] platform/x86: asus-wmi: fix sending OOBE at probe Denis Benato
2025-12-29 10:07 ` Ilpo Järvinen
2025-12-29 10:08 ` Ilpo Järvinen
2025-12-25 14:30 ` [PATCH 3/3] platform/x86: asus-armoury: add keyboard control firmware attributes Denis Benato
2025-12-26 11:06 ` Krzysztof Kozlowski
2025-12-26 11:46 ` Denis Benato
2025-12-26 12:20 ` Krzysztof Kozlowski
2025-12-29 10:33 ` Ilpo Järvinen
2025-12-29 10:24 ` Ilpo Järvinen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=eb0f4db5-a169-4e28-882b-346e595c81b5@gmail.com \
--to=benato.denis96@gmail.com \
--cc=denis.benato@linux.dev \
--cc=dragonn@op.pl \
--cc=hansg@kernel.org \
--cc=ilpo.jarvinen@linux.intel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=luke@ljones.dev \
--cc=platform-driver-x86@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome