* [PATCH] [media] imx: add VIDEO_V4L2_SUBDEV_API dependency
@ 2017-07-21 16:21 Arnd Bergmann
2017-07-22 18:52 ` Steve Longerbeam
0 siblings, 1 reply; 2+ messages in thread
From: Arnd Bergmann @ 2017-07-21 16:21 UTC (permalink / raw)
To: Steve Longerbeam, Philipp Zabel, Mauro Carvalho Chehab,
Greg Kroah-Hartman
Cc: Arnd Bergmann, Hans Verkuil, Russell King, linux-media, devel,
linux-kernel
Without this, I get a build error:
drivers/staging/media/imx/imx-media-vdic.c: In function '__vdic_get_fmt':
drivers/staging/media/imx/imx-media-vdic.c:554:10: error: implicit declaration of function 'v4l2_subdev_get_try_format'; did you mean 'v4l2_subdev_notify_event'? [-Werror=implicit-function-declaration]
Fixes: e130291212df ("[media] media: Add i.MX media core driver")
Signed-off-by: Arnd Bergmann <arnd@arndb.de>
---
drivers/staging/media/imx/Kconfig | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/staging/media/imx/Kconfig b/drivers/staging/media/imx/Kconfig
index 7eff50bcea39..719508fcb0e9 100644
--- a/drivers/staging/media/imx/Kconfig
+++ b/drivers/staging/media/imx/Kconfig
@@ -1,6 +1,7 @@
config VIDEO_IMX_MEDIA
tristate "i.MX5/6 V4L2 media core driver"
depends on MEDIA_CONTROLLER && VIDEO_V4L2 && ARCH_MXC && IMX_IPUV3_CORE
+ depends on VIDEO_V4L2_SUBDEV_API
select V4L2_FWNODE
---help---
Say yes here to enable support for video4linux media controller
--
2.9.0
^ permalink raw reply [flat|nested] 2+ messages in thread
* Re: [PATCH] [media] imx: add VIDEO_V4L2_SUBDEV_API dependency
2017-07-21 16:21 [PATCH] [media] imx: add VIDEO_V4L2_SUBDEV_API dependency Arnd Bergmann
@ 2017-07-22 18:52 ` Steve Longerbeam
0 siblings, 0 replies; 2+ messages in thread
From: Steve Longerbeam @ 2017-07-22 18:52 UTC (permalink / raw)
To: Arnd Bergmann, Philipp Zabel, Mauro Carvalho Chehab, Greg Kroah-Hartman
Cc: Hans Verkuil, Russell King, linux-media, devel, linux-kernel
Acked-by: Steve Longerbeam <steve_longerbeam@mentor.com>
On 07/21/2017 09:21 AM, Arnd Bergmann wrote:
> Without this, I get a build error:
>
> drivers/staging/media/imx/imx-media-vdic.c: In function '__vdic_get_fmt':
> drivers/staging/media/imx/imx-media-vdic.c:554:10: error: implicit declaration of function 'v4l2_subdev_get_try_format'; did you mean 'v4l2_subdev_notify_event'? [-Werror=implicit-function-declaration]
>
> Fixes: e130291212df ("[media] media: Add i.MX media core driver")
> Signed-off-by: Arnd Bergmann <arnd@arndb.de>
> ---
> drivers/staging/media/imx/Kconfig | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/drivers/staging/media/imx/Kconfig b/drivers/staging/media/imx/Kconfig
> index 7eff50bcea39..719508fcb0e9 100644
> --- a/drivers/staging/media/imx/Kconfig
> +++ b/drivers/staging/media/imx/Kconfig
> @@ -1,6 +1,7 @@
> config VIDEO_IMX_MEDIA
> tristate "i.MX5/6 V4L2 media core driver"
> depends on MEDIA_CONTROLLER && VIDEO_V4L2 && ARCH_MXC && IMX_IPUV3_CORE
> + depends on VIDEO_V4L2_SUBDEV_API
> select V4L2_FWNODE
> ---help---
> Say yes here to enable support for video4linux media controller
>
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2017-07-22 18:52 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2017-07-21 16:21 [PATCH] [media] imx: add VIDEO_V4L2_SUBDEV_API dependency Arnd Bergmann
2017-07-22 18:52 ` Steve Longerbeam
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®