[PATCH net-2.6.26] [IPV6] Return NET_RX_DROP when a packet is dropped in ipv6_rcv().

[PATCH net-2.6.26] [IPV6] Return NET_RX_DROP when a packet is dropped in ipv6_rcv().

[Rami Rosen]

[-- Attachment #1: Type: text/plain, Size: 572 bytes --]

Hi,
- The IPv6 handler for receiving packets is ipv6_rcv() in net/ipv6/ip6_input.c.
It is called by netif_receive_skb() (net/core/dev.c)
According to the documentation, the return value of netif_receive_skb() should
be NET_RX_DROP when the packet is dropped; though this return value
is usually not used (except maybe for congestion), this patch fixes the
ipv6_rcv() to return NET_RX_DROP when the packet is dropped (note that
NET_RX_DROP value **is not** 0 but 1; NET_RX_SUCCESS value is in fact	0).


Regards,
Rami Rosen


Signed-off-by: Rami Rosen <ramirose@gmail.com>

[-- Attachment #2: patch.txt --]
[-- Type: text/plain, Size: 255 bytes --]

diff --git a/net/ipv6/ip6_input.c b/net/ipv6/ip6_input.c
index 4e5c861..3ca041b 100644
--- a/net/ipv6/ip6_input.c
+++ b/net/ipv6/ip6_input.c
@@ -138,7 +138,7 @@ drop:
 	rcu_read_unlock();
 	kfree_skb(skb);
 out:
-	return 0;
+	return NET_RX_DROP;
 }
 
 /*

Re: [PATCH net-2.6.26] [IPV6] Return NET_RX_DROP when a packet is dropped in ipv6_rcv().

[YOSHIFUJI Hideaki / 吉藤英明]

In article <eb3ff54b0804140615u3dd4549fie83ae6818c33beba@mail.gmail.com> (at Mon, 14 Apr 2008 16:15:54 +0300), "Rami Rosen" <ramirose@gmail.com> says:

> Hi,
> - The IPv6 handler for receiving packets is ipv6_rcv() in net/ipv6/ip6_input.c.
> It is called by netif_receive_skb() (net/core/dev.c)
> According to the documentation, the return value of netif_receive_skb() should
> be NET_RX_DROP when the packet is dropped; though this return value
> is usually not used (except maybe for congestion), this patch fixes the
> ipv6_rcv() to return NET_RX_DROP when the packet is dropped (note that
> NET_RX_DROP value **is not** 0 but 1; NET_RX_SUCCESS value is in fact	0).

Well yes, and I think we should fix other paths as well, right?
So, I'm going to defer this for now.

--yoshfuji