* [PATCH 1/3] [IPV6] Remove unused macro (MLDV2_QQIC) from mcast.c.
@ 2008-04-23 11:34 Rami Rosen
2008-04-23 14:47 ` David Stevens
0 siblings, 1 reply; 2+ messages in thread
From: Rami Rosen @ 2008-04-23 11:34 UTC (permalink / raw)
To: yoshfuji, netdev, David Miller, linux-kernel
[-- Attachment #1: Type: text/plain, Size: 141 bytes --]
Hi,
This patch removes MLDV2_QQIC macro from mcast.c
as it is unused.
Regards,
Rami Rosen
Signed-off-by: Rami Rosen <ramirose@gmail.com>
[-- Attachment #2: patch1.txt --]
[-- Type: text/plain, Size: 474 bytes --]
diff --git a/net/ipv6/mcast.c b/net/ipv6/mcast.c
index 54f91ef..bff99fb 100644
--- a/net/ipv6/mcast.c
+++ b/net/ipv6/mcast.c
@@ -164,7 +164,6 @@ static int ip6_mc_leave_src(struct sock *sk, struct ipv6_mc_socklist *iml,
((MLDV2_MASK(value, nbmant) | (1<<(nbmant))) << \
(MLDV2_MASK((value) >> (nbmant), nbexp) + (nbexp))))
-#define MLDV2_QQIC(value) MLDV2_EXP(0x80, 4, 3, value)
#define MLDV2_MRC(value) MLDV2_EXP(0x8000, 12, 3, value)
#define IPV6_MLD_MAX_MSF 64
^ permalink raw reply [flat|nested] 2+ messages in thread
* Re: [PATCH 1/3] [IPV6] Remove unused macro (MLDV2_QQIC) from mcast.c.
2008-04-23 11:34 [PATCH 1/3] [IPV6] Remove unused macro (MLDV2_QQIC) from mcast.c Rami Rosen
@ 2008-04-23 14:47 ` David Stevens
0 siblings, 0 replies; 2+ messages in thread
From: David Stevens @ 2008-04-23 14:47 UTC (permalink / raw)
To: Rami Rosen; +Cc: David Miller, linux-kernel, netdev, netdev-owner, yoshfuji
The QQIC field is only used by multicast routers.
I don't object strongly to removing it, but it doesn't really save much
and it's potentially useful for debug printing or simply documenting how
to decode the field. So, I would leave it, but I agree it isn't a
requirement
if Yoshifuji or Dave thinks it's better to remove it.
+-DLS
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2008-04-23 14:48 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2008-04-23 11:34 [PATCH 1/3] [IPV6] Remove unused macro (MLDV2_QQIC) from mcast.c Rami Rosen
2008-04-23 14:47 ` David Stevens
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®