From: Gao Xiang <hsiangkao@linux.alibaba.com>
To: Mateusz Guzik <mjguzik@gmail.com>
Cc: Christian Brauner <brauner@kernel.org>,
Ian Kent <raven@themaw.net>, Al Viro <viro@zeniv.linux.org.uk>,
Miklos Szeredi <miklos@szeredi.hu>,
Eric Sandeen <sandeen@sandeen.net>,
Frank Sorenson <fsorenso@redhat.com>,
Jay Shin <jaeshin@redhat.com>,
Linus Torvalds <torvalds@linux-foundation.org>,
Yafang Shao <laoar.shao@gmail.com>, Jan Kara <jack@suse.cz>,
Waiman Long <longman@redhat.com>,
Matthew Wilcox <willy@infradead.org>,
Wangkai <wangkai86@huawei.com>,
Colin Walters <walters@verbum.org>,
linux-fsdevel <linux-fsdevel@vger.kernel.org>,
Kernel Mailing List <linux-kernel@vger.kernel.org>
Subject: Re: [RFC PATCH] vfs: limit directory child dentry retention
Date: Tue, 31 Mar 2026 23:11:49 +0800 [thread overview]
Message-ID: <eb46cf29-2ac5-4586-a76d-c6a9d7b6619f@linux.alibaba.com> (raw)
In-Reply-To: <6qfk57jj64a2t2mwjsldtvne6ooctpnfhpwisexctlntqa5mpq@s2lumil5gddf>
Hi,
On 2026/3/31 22:59, Mateusz Guzik wrote:
> On Tue, Mar 31, 2026 at 05:54:01PM +0800, Gao Xiang wrote:
>> JFYI, another issue we once observed on user workloads is that
>>
>> `d_lockref.count` can exceed `int` on very very large
>> directories in reality (also combined with cached
>> negative dentries).
>>
>> It can be a real overflow, this commit can help but it
>> doesn't strictly resolve this, anyway.
>
>
> Another way to contribute to the problem is to mass open the same file,
> which results in one ref per fd.
>
> Or to put it differently, sooner or later the dentry refcount will have
> to switch to 64 bits on 64 bit systems.
Yes, but my own basic question on this is that do we
really need 64-bit refcount for each dentry?
- do we need to cache so many child dentries at the
same time? some real use case?
- do we need to cache so many negative dentries for
a single directory?
- do we need to really care mass open the same file?
or just find a way to error out blindly when the
refcount is nearly overflowed? together with this
retain_dentry() change to make cached dentries
in the low watermark.
just my .2 cents since currently I don't work on
vfs stuffs.
Thanks,
Gao Xiang
next prev parent reply other threads:[~2026-03-31 15:11 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-03-31 1:29 [RFC PATCH] Limit " Ian Kent
2026-03-31 1:29 ` [RFC PATCH] vfs: limit " Ian Kent
2026-03-31 9:39 ` Christian Brauner
2026-03-31 9:54 ` Gao Xiang
2026-03-31 14:59 ` Mateusz Guzik
2026-03-31 15:11 ` Gao Xiang [this message]
2026-04-01 1:38 ` Ian Kent
2026-04-01 1:47 ` Gao Xiang
2026-04-01 2:21 ` Ian Kent
2026-04-01 2:40 ` Linus Torvalds
2026-04-01 2:10 ` Ian Kent
2026-04-07 10:35 ` Christian Brauner
2026-04-07 12:41 ` Ian Kent
2026-04-08 10:17 ` Jan Kara
2026-04-09 0:59 ` Ian Kent
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=eb46cf29-2ac5-4586-a76d-c6a9d7b6619f@linux.alibaba.com \
--to=hsiangkao@linux.alibaba.com \
--cc=brauner@kernel.org \
--cc=fsorenso@redhat.com \
--cc=jack@suse.cz \
--cc=jaeshin@redhat.com \
--cc=laoar.shao@gmail.com \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=longman@redhat.com \
--cc=miklos@szeredi.hu \
--cc=mjguzik@gmail.com \
--cc=raven@themaw.net \
--cc=sandeen@sandeen.net \
--cc=torvalds@linux-foundation.org \
--cc=viro@zeniv.linux.org.uk \
--cc=walters@verbum.org \
--cc=wangkai86@huawei.com \
--cc=willy@infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®