mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Steve Longerbeam <slongerbeam@gmail.com>
To: Dan Carpenter <dan.carpenter@oracle.com>,
	kbuild@01.org, Steve Longerbeam <slongerbeam@gmail.com>
Cc: kbuild-all@01.org, linux-media@vger.kernel.org,
	linux-kernel@vger.kernel.org
Subject: Re: [PATCH v5 15/17] media: platform: Switch to v4l2_async_notifier_add_subdev
Date: Sat, 7 Jul 2018 14:06:59 -0700	[thread overview]
Message-ID: <eb8fbaae-6ab3-e1fa-9575-fbadb8d55342@gmail.com> (raw)
In-Reply-To: <20180702060907.xlghcxtsj5eepdxu@mwanda>



On 07/01/2018 11:09 PM, Dan Carpenter wrote:
> Hi Steve,
>
> I love your patch! Perhaps something to improve:
>
> url:    https://github.com/0day-ci/linux/commits/Steve-Longerbeam/media-imx-Switch-to-subdev-notifiers/20180630-035625
> base:   git://linuxtv.org/media_tree.git master
>
> New smatch warnings:
> drivers/media/platform/xilinx/xilinx-vipp.c:97 xvip_graph_build_one() error: '%pOF' expects argument of type 'struct device_node*', argument 3 has type 'struct fwnode_handle*'
> drivers/media/platform/xilinx/xilinx-vipp.c:335 xvip_graph_notify_bound() error: '%pOF' expects argument of type 'struct device_node*', argument 3 has type 'struct fwnode_handle*'
>
> Old smatch warnings:
> drivers/media/platform/xilinx/xilinx-vipp.c:106 xvip_graph_build_one() error: '%pOF' expects argument of type 'struct device_node*', argument 4 has type 'struct fwnode_handle*'
> drivers/media/platform/xilinx/xilinx-vipp.c:133 xvip_graph_build_one() error: '%pOF' expects argument of type 'struct device_node*', argument 3 has type 'struct fwnode_handle*'
> drivers/media/platform/xilinx/xilinx-vipp.c:143 xvip_graph_build_one() error: '%pOF' expects argument of type 'struct device_node*', argument 4 has type 'struct fwnode_handle*'

Thanks for the report. Will fix for v8.

Steve



  reply	other threads:[~2018-07-07 21:07 UTC|newest]

Thread overview: 24+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-06-29 18:49 [PATCH v5 00/17] media: imx: Switch to subdev notifiers Steve Longerbeam
2018-06-29 18:49 ` [PATCH v5 01/17] media: v4l2-fwnode: ignore endpoints that have no remote port parent Steve Longerbeam
2018-06-29 18:49 ` [PATCH v5 02/17] media: v4l2: async: Allow searching for asd of any type Steve Longerbeam
2018-06-29 18:49 ` [PATCH v5 03/17] media: v4l2: async: Add v4l2_async_notifier_add_subdev Steve Longerbeam
2018-06-29 18:49 ` [PATCH v5 04/17] media: v4l2: async: Add convenience functions to allocate and add asd's Steve Longerbeam
2018-06-29 18:49 ` [PATCH v5 05/17] media: v4l2-fwnode: Switch to v4l2_async_notifier_add_subdev Steve Longerbeam
2018-06-29 18:49 ` [PATCH v5 06/17] media: v4l2-fwnode: Add a convenience function for registering subdevs with notifiers Steve Longerbeam
2018-06-29 18:49 ` [PATCH v5 07/17] media: platform: video-mux: Register a subdev notifier Steve Longerbeam
2018-06-29 18:49 ` [PATCH v5 08/17] media: imx: csi: " Steve Longerbeam
2018-06-29 18:49 ` [PATCH v5 09/17] media: imx: mipi csi-2: " Steve Longerbeam
2018-06-29 18:49 ` [PATCH v5 10/17] media: staging/imx: of: Remove recursive graph walk Steve Longerbeam
2018-06-29 18:49 ` [PATCH v5 11/17] media: staging/imx: Loop through all registered subdevs for media links Steve Longerbeam
2018-06-29 18:49 ` [PATCH v5 12/17] media: staging/imx: Rename root notifier Steve Longerbeam
2018-06-29 18:49 ` [PATCH v5 13/17] media: staging/imx: Switch to v4l2_async_notifier_add_*_subdev Steve Longerbeam
2018-06-29 18:49 ` [PATCH v5 14/17] media: staging/imx: TODO: Remove one assumption about OF graph parsing Steve Longerbeam
2018-06-29 18:49 ` [PATCH v5 15/17] media: platform: Switch to v4l2_async_notifier_add_subdev Steve Longerbeam
2018-07-02  6:09   ` Dan Carpenter
2018-07-07 21:06     ` Steve Longerbeam [this message]
2018-07-02 11:23   ` Sakari Ailus
2018-07-07 21:09     ` Steve Longerbeam
2018-06-29 18:50 ` [PATCH v5 16/17] media: v4l2: async: Remove notifier subdevs array Steve Longerbeam
2018-06-29 18:50 ` [PATCH v5 17/17] [media] v4l2-subdev.rst: Update doc regarding subdev descriptors Steve Longerbeam
2018-07-02  9:51 ` [PATCH v5 00/17] media: imx: Switch to subdev notifiers Sakari Ailus
2018-07-07 21:15   ` Steve Longerbeam

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=eb8fbaae-6ab3-e1fa-9575-fbadb8d55342@gmail.com \
    --to=slongerbeam@gmail.com \
    --cc=dan.carpenter@oracle.com \
    --cc=kbuild-all@01.org \
    --cc=kbuild@01.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-media@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®