From: Andrew Lunn <andrew@lunn.ch>
To: "illusion.wang" <illusion.wang@nebula-matrix.com>
Cc: dimon.zhao@nebula-matrix.com, alvin.wang@nebula-matrix.com,
sam.chen@nebula-matrix.com, netdev@vger.kernel.org,
open list <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH v1 net-next 07/15] net/nebula-matrix: add vsi, queue, adminq resource definitions and implementation
Date: Wed, 24 Dec 2025 11:49:01 +0100 [thread overview]
Message-ID: <ebe0444d-28cd-4c19-bd35-1aa0971e8c41@lunn.ch> (raw)
In-Reply-To: <20251223035113.31122-8-illusion.wang@nebula-matrix.com>
> +++ b/drivers/net/ethernet/nebula-matrix/nbl/nbl_hw/nbl_hw_leonis/base/nbl_datapath.h
> @@ -0,0 +1,14 @@
> +/* SPDX-License-Identifier: GPL-2.0*/
> +/*
> + * Copyright (c) 2025 Nebula Matrix Limited.
> + * Author:
> + */
> +// Code generated by interstellar. DO NOT EDIT.
> +// Compatible with leonis RTL tag 0710
That patch is way too big, it is unlikely anybody will review it for
you.
One thing which will help is put all the machine generated headers in
a separate patch. Make sure the commit message makes it clear this is
machine generated. Human reviewers will then only take a quick look,
but mostly ignore it. That helps make the real code which needs human
review stand out.
Andrew
next prev parent reply other threads:[~2025-12-24 10:49 UTC|newest]
Thread overview: 25+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-12-23 3:50 [PATCH v1 net-next 00/15] nbl driver for Nebulamatrix NICs illusion.wang
2025-12-23 3:50 ` [PATCH v1 net-next 01/15] net/nebula-matrix: add minimum nbl build framework illusion.wang
2025-12-23 10:02 ` Andrew Lunn
2025-12-23 3:50 ` [PATCH v1 net-next 02/15] net/nebula-matrix: add simple probe/remove illusion.wang
2025-12-23 10:19 ` Andrew Lunn
2025-12-23 3:50 ` [PATCH v1 net-next 03/15] net/nebula-matrix: add HW layer definitions and implementation illusion.wang
2025-12-23 3:50 ` [PATCH v1 net-next 04/15] net/nebula-matrix: add Channel " illusion.wang
2025-12-23 3:50 ` [PATCH v1 net-next 05/15] net/nebula-matrix: add Resource " illusion.wang
2025-12-23 3:50 ` [PATCH v1 net-next 06/15] net/nebula-matrix: add intr resource " illusion.wang
2025-12-23 3:50 ` [PATCH v1 net-next 07/15] net/nebula-matrix: add vsi, queue, adminq " illusion.wang
2025-12-24 10:49 ` Andrew Lunn [this message]
2025-12-23 3:50 ` [PATCH v1 net-next 08/15] net/nebula-matrix: add flow " illusion.wang
2025-12-23 3:50 ` [PATCH v1 net-next 09/15] net/nebula-matrix: add txrx " illusion.wang
2025-12-23 3:50 ` [PATCH v1 net-next 10/15] net/nebula-matrix: add Dispatch layer " illusion.wang
2025-12-23 3:50 ` [PATCH v1 net-next 11/15] net/nebula-matrix: add Service " illusion.wang
2025-12-23 3:50 ` [PATCH v1 net-next 12/15] net/nebula-matrix: add Dev " illusion.wang
2025-12-23 3:50 ` [PATCH v1 net-next 13/15] net/nebula-matrix: add Dev start, stop operation illusion.wang
2025-12-24 11:03 ` Andrew Lunn
2025-12-29 1:36 ` 回复：[PATCH " Illusion Wang
2025-12-23 3:50 ` [PATCH v1 net-next 14/15] net/nebula-matrix: fully support ndo operations illusion.wang
2025-12-23 3:50 ` [PATCH v1 net-next 15/15] net/nebula-matrix: add kernel/user coexist mode support illusion.wang
2025-12-24 10:52 ` Andrew Lunn
2025-12-23 7:08 ` [PATCH v1 net-next 00/15] nbl driver for Nebulamatrix NICs Paolo Abeni
2025-12-29 1:47 ` 回复：[PATCH " Illusion Wang
2025-12-29 16:41 ` Paolo Abeni
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ebe0444d-28cd-4c19-bd35-1aa0971e8c41@lunn.ch \
--to=andrew@lunn.ch \
--cc=alvin.wang@nebula-matrix.com \
--cc=dimon.zhao@nebula-matrix.com \
--cc=illusion.wang@nebula-matrix.com \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=sam.chen@nebula-matrix.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®