* [PATCH] gpu/drm/radeon:Fix null pointer risk
@ 2021-12-28 7:31 Wen Zhiwei
2021-12-30 16:36 ` Christian König
0 siblings, 1 reply; 2+ messages in thread
From: Wen Zhiwei @ 2021-12-28 7:31 UTC (permalink / raw)
To: alexander.deucher, christian.koenig, Xinhui.Pan, airlied, daniel
Cc: wenzhiwei, amd-gfx, dri-devel, linux-kernel
If the null pointer is not judged in advance,
there is a risk that the pointer will cross
the boundary
Signed-off-by: Wen Zhiwei <wenzhiwei@kylinos.cn>
---
drivers/gpu/drm/radeon/radeon_vm.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/gpu/drm/radeon/radeon_vm.c b/drivers/gpu/drm/radeon/radeon_vm.c
index bb53016f3138..d3d342041adf 100644
--- a/drivers/gpu/drm/radeon/radeon_vm.c
+++ b/drivers/gpu/drm/radeon/radeon_vm.c
@@ -951,7 +951,7 @@ int radeon_vm_bo_update(struct radeon_device *rdev,
if (mem->mem_type == TTM_PL_TT) {
bo_va->flags |= RADEON_VM_PAGE_SYSTEM;
- if (!(bo_va->bo->flags & (RADEON_GEM_GTT_WC | RADEON_GEM_GTT_UC)))
+ if (bo_va->bo && !(bo_va->bo->flags & (RADEON_GEM_GTT_WC | RADEON_GEM_GTT_UC)))
bo_va->flags |= RADEON_VM_PAGE_SNOOPED;
} else {
--
2.30.0
^ permalink raw reply [flat|nested] 2+ messages in thread* Re: [PATCH] gpu/drm/radeon:Fix null pointer risk
2021-12-28 7:31 [PATCH] gpu/drm/radeon:Fix null pointer risk Wen Zhiwei
@ 2021-12-30 16:36 ` Christian König
0 siblings, 0 replies; 2+ messages in thread
From: Christian König @ 2021-12-30 16:36 UTC (permalink / raw)
To: Wen Zhiwei, alexander.deucher, Xinhui.Pan, airlied, daniel
Cc: amd-gfx, dri-devel, linux-kernel
Am 28.12.21 um 08:31 schrieb Wen Zhiwei:
> If the null pointer is not judged in advance,
> there is a risk that the pointer will cross
> the boundary
As far as I can see that case is impossible, why do you want to add a
check for it?
Regards,
Christian.
>
> Signed-off-by: Wen Zhiwei <wenzhiwei@kylinos.cn>
> ---
> drivers/gpu/drm/radeon/radeon_vm.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/gpu/drm/radeon/radeon_vm.c b/drivers/gpu/drm/radeon/radeon_vm.c
> index bb53016f3138..d3d342041adf 100644
> --- a/drivers/gpu/drm/radeon/radeon_vm.c
> +++ b/drivers/gpu/drm/radeon/radeon_vm.c
> @@ -951,7 +951,7 @@ int radeon_vm_bo_update(struct radeon_device *rdev,
>
> if (mem->mem_type == TTM_PL_TT) {
> bo_va->flags |= RADEON_VM_PAGE_SYSTEM;
> - if (!(bo_va->bo->flags & (RADEON_GEM_GTT_WC | RADEON_GEM_GTT_UC)))
> + if (bo_va->bo && !(bo_va->bo->flags & (RADEON_GEM_GTT_WC | RADEON_GEM_GTT_UC)))
> bo_va->flags |= RADEON_VM_PAGE_SNOOPED;
>
> } else {
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2021-12-30 16:37 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-12-28 7:31 [PATCH] gpu/drm/radeon:Fix null pointer risk Wen Zhiwei
2021-12-30 16:36 ` Christian König
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®