* [PATCH net-next v3 0/2] net: stmmac: Add RK3572 support
@ 2026-11-16 7:39 Cunhao Lu via B4 Relay
2026-11-16 7:39 ` [PATCH net-next v3 1/2] dt-bindings: net: rockchip-dwmac: Add RK3572 Cunhao Lu via B4 Relay
` (2 more replies)
0 siblings, 3 replies; 8+ messages in thread
From: Cunhao Lu via B4 Relay @ 2026-11-16 7:39 UTC (permalink / raw)
To: Andrew Lunn, David S. Miller, Eric Dumazet, Jakub Kicinski,
Paolo Abeni, Rob Herring, Krzysztof Kozlowski, Conor Dooley,
Heiko Stuebner, David Wu, Alexandre Torgue, Giuseppe Cavallaro,
Jose Abreu, Maxime Chevallier, Maxime Coquelin
Cc: Cunhao Lu, netdev, devicetree, linux-arm-kernel, linux-rockchip,
linux-kernel, linux-stm32
This is one of the subsystem submissions for RK3572 support.
This series adds the RK3572 GMAC bindings and support for both Ethernet
controllers in the Rockchip stmmac glue driver. It provides RGMII and
RMII mode and clock control, together with RGMII delay configuration.
The RK3572 SoC has eight CPU cores: two Cortex-A73 cores and six
Cortex-A53 cores. It also integrates an Arm Mali-G310V2 MC1 GPU.
The OK3572-C board provides two Gigabit Ethernet ports, three USB3 Type-A
ports, a Type-C dual-role port, eMMC, microSD, and UART.
Testing was performed with Debian 13 minimal and Linux 7.3 on the
OK3572-C with the FET3572-C module.
Passed functionality:
- SD and eMMC complete the firmware, kernel, and root filesystem
boot chain.
- UART console works at 1500000 baud.
- SD read/write and data persistence checks pass.
- All eight CPUs start; CPU frequency scaling and hotplug checks pass.
- Both Ethernet ports obtain IPv4 addresses and pass bidirectional file
transfers.
- All three Type-A ports pass USB2 and USB3 enumeration, data transfers,
and reconnect persistence checks.
- Type-C host and device modes pass in both plug orientations. Physical
reconnects correctly select the expected device, host, and device roles
in sequence.
Stability:
- Repeated cold and software reboots complete on SD and eMMC without data
integrity failures.
- A combined CPU, memory, network, SD, and USB3 stress test completes
without a crash, lockup, CPU offline event, or thermal shutdown.
- Ethernet error and drop counters do not increase during bidirectional
network tests.
Build and checks:
- The kernel, modules, and board DTB build successfully.
- The series passes checkpatch with --strict.
Untested hardware and paths:
- NPU
- PCIe
- GPU, video output, and audio
- Other low-speed external interfaces
Some files in this series are derived from the Forlinx OK3572-C BSP
Alpha1. Thanks to Forlinx for their support.
AI assistance:
- Codex / DeepSeek V4.1 Flash were used for:
- Reviewing and adjusting code style to follow community conventions
- Automating tests
- Collecting data
Signed-off-by: Cunhao Lu <1579567540@qq.com>
---
Changes in v3:
- Deprecate tx_delay and rx_delay and disallow them for RK3572.
- Link to v2:
https://patch.msgid.link/20261111-add-board-ok3572-c-net-v2-0-304466394970@qq.com
Changes in v2:
- Split the original RK3572 support series by subsystem.
- Add rockchip,rk3572-gmac to the shared Synopsys compatible list in
snps,dwmac.yaml.
- Link to v1:
https://patch.msgid.link/20261022-add-board-ok3572-c-v1-0-0b0fd85a31ee@qq.com
---
Raw dmesg: see the v1 cover letter.
To: Andrew Lunn <andrew+netdev@lunn.ch>
To: "David S. Miller" <davem@davemloft.net>
To: Eric Dumazet <edumazet@kernel.org>
To: Jakub Kicinski <kuba@kernel.org>
To: Paolo Abeni <pabeni@redhat.com>
To: Rob Herring <robh@kernel.org>
To: Krzysztof Kozlowski <krzk+dt@kernel.org>
To: Conor Dooley <conor+dt@kernel.org>
To: Heiko Stuebner <heiko@sntech.de>
To: David Wu <david.wu@rock-chips.com>
To: Alexandre Torgue <alexandre.torgue@foss.st.com>
To: Giuseppe Cavallaro <peppe.cavallaro@st.com>
To: Jose Abreu <joabreu@synopsys.com>
To: Maxime Chevallier <maxime.chevallier@bootlin.com>
To: Maxime Coquelin <mcoquelin.stm32@gmail.com>
Cc: netdev@vger.kernel.org
Cc: devicetree@vger.kernel.org
Cc: linux-arm-kernel@lists.infradead.org
Cc: linux-rockchip@lists.infradead.org
Cc: linux-kernel@vger.kernel.org
Cc: linux-stm32@st-md-mailman.stormreply.com
---
Cunhao Lu (2):
dt-bindings: net: rockchip-dwmac: Add RK3572
net: stmmac: dwmac-rk: Add RK3572 support
.../devicetree/bindings/net/rockchip-dwmac.yaml | 15 ++++++
.../devicetree/bindings/net/snps,dwmac.yaml | 1 +
drivers/net/ethernet/stmicro/stmmac/dwmac-rk.c | 53 ++++++++++++++++++++++
3 files changed, 69 insertions(+)
---
base-commit: 067c5c24cef23d913b67eaaf71ae67e7169a6620
change-id: 20261111-add-board-ok3572-c-net-4d45887c575f
Best regards,
--
Cunhao Lu <1579567540@qq.com>
^ permalink raw reply [flat|nested] 8+ messages in thread
* [PATCH net-next v3 1/2] dt-bindings: net: rockchip-dwmac: Add RK3572
2026-11-16 7:39 [PATCH net-next v3 0/2] net: stmmac: Add RK3572 support Cunhao Lu via B4 Relay
@ 2026-11-16 7:39 ` Cunhao Lu via B4 Relay
2026-11-16 13:44 ` Andrew Lunn
2026-11-16 7:39 ` [PATCH net-next v3 2/2] net: stmmac: dwmac-rk: Add RK3572 support Cunhao Lu via B4 Relay
2026-11-16 13:43 ` [PATCH net-next v3 0/2] net: stmmac: " Andrew Lunn
2 siblings, 1 reply; 8+ messages in thread
From: Cunhao Lu via B4 Relay @ 2026-11-16 7:39 UTC (permalink / raw)
To: Andrew Lunn, David S. Miller, Eric Dumazet, Jakub Kicinski,
Paolo Abeni, Rob Herring, Krzysztof Kozlowski, Conor Dooley,
Heiko Stuebner, David Wu, Alexandre Torgue, Giuseppe Cavallaro,
Jose Abreu, Maxime Chevallier, Maxime Coquelin
Cc: Cunhao Lu, netdev, devicetree, linux-arm-kernel, linux-rockchip,
linux-kernel, linux-stm32
From: Cunhao Lu <1579567540@qq.com>
Add the rockchip,rk3572-gmac compatible with the snps,dwmac-4.20a
fallback and require rockchip,php-grf.
Mark tx_delay and rx_delay as deprecated and disallow them for RK3572
so new designs do not use the legacy delay properties.
Signed-off-by: Cunhao Lu <1579567540@qq.com>
---
Changes in v3:
- Deprecate tx_delay and rx_delay and disallow them for RK3572.
Changes in v2:
- Add RK3572 to the shared Synopsys compatible list for consistency.
---
Documentation/devicetree/bindings/net/rockchip-dwmac.yaml | 15 +++++++++++++++
Documentation/devicetree/bindings/net/snps,dwmac.yaml | 1 +
2 files changed, 16 insertions(+)
diff --git a/Documentation/devicetree/bindings/net/rockchip-dwmac.yaml b/Documentation/devicetree/bindings/net/rockchip-dwmac.yaml
index e8dda1961ab3..d7b7bb008235 100644
--- a/Documentation/devicetree/bindings/net/rockchip-dwmac.yaml
+++ b/Documentation/devicetree/bindings/net/rockchip-dwmac.yaml
@@ -27,6 +27,7 @@ select:
- rockchip,rk3506-gmac
- rockchip,rk3528-gmac
- rockchip,rk3568-gmac
+ - rockchip,rk3572-gmac
- rockchip,rk3576-gmac
- rockchip,rk3588-gmac
- rockchip,rv1108-gmac
@@ -54,6 +55,7 @@ properties:
- rockchip,rk3506-gmac
- rockchip,rk3528-gmac
- rockchip,rk3568-gmac
+ - rockchip,rk3572-gmac
- rockchip,rk3576-gmac
- rockchip,rk3588-gmac
- rockchip,rv1126-gmac
@@ -112,6 +114,7 @@ properties:
minimum: 0
maximum: 0x7F
default: 0x30
+ deprecated: true
rx_delay:
description: Delay value for RXD timing.
@@ -119,6 +122,7 @@ properties:
minimum: 0
maximum: 0x7F
default: 0x10
+ deprecated: true
pcs-handle:
description:
@@ -141,11 +145,22 @@ required:
allOf:
- $ref: snps,dwmac.yaml#
+ - if:
+ properties:
+ compatible:
+ contains:
+ const: rockchip,rk3572-gmac
+ then:
+ properties:
+ rx_delay: false
+ tx_delay: false
+
- if:
properties:
compatible:
contains:
enum:
+ - rockchip,rk3572-gmac
- rockchip,rk3576-gmac
- rockchip,rk3588-gmac
then:
diff --git a/Documentation/devicetree/bindings/net/snps,dwmac.yaml b/Documentation/devicetree/bindings/net/snps,dwmac.yaml
index 2c4842404bf6..80d3b43e2889 100644
--- a/Documentation/devicetree/bindings/net/snps,dwmac.yaml
+++ b/Documentation/devicetree/bindings/net/snps,dwmac.yaml
@@ -94,6 +94,7 @@ properties:
- rockchip,rk3506-gmac
- rockchip,rk3528-gmac
- rockchip,rk3568-gmac
+ - rockchip,rk3572-gmac
- rockchip,rk3576-gmac
- rockchip,rk3588-gmac
- rockchip,rv1108-gmac
--
2.34.1
^ permalink raw reply [flat|nested] 8+ messages in thread
* [PATCH net-next v3 2/2] net: stmmac: dwmac-rk: Add RK3572 support
2026-11-16 7:39 [PATCH net-next v3 0/2] net: stmmac: Add RK3572 support Cunhao Lu via B4 Relay
2026-11-16 7:39 ` [PATCH net-next v3 1/2] dt-bindings: net: rockchip-dwmac: Add RK3572 Cunhao Lu via B4 Relay
@ 2026-11-16 7:39 ` Cunhao Lu via B4 Relay
2026-11-16 13:55 ` Andrew Lunn
2026-11-16 13:43 ` [PATCH net-next v3 0/2] net: stmmac: " Andrew Lunn
2 siblings, 1 reply; 8+ messages in thread
From: Cunhao Lu via B4 Relay @ 2026-11-16 7:39 UTC (permalink / raw)
To: Andrew Lunn, David S. Miller, Eric Dumazet, Jakub Kicinski,
Paolo Abeni, Rob Herring, Krzysztof Kozlowski, Conor Dooley,
Heiko Stuebner, David Wu, Alexandre Torgue, Giuseppe Cavallaro,
Jose Abreu, Maxime Chevallier, Maxime Coquelin
Cc: Cunhao Lu, netdev, devicetree, linux-arm-kernel, linux-rockchip,
linux-kernel, linux-stm32
From: Cunhao Lu <1579567540@qq.com>
The RK3572 has two GMAC controllers with separate mode and clock control
registers in the PHP and NVM0 GRFs. RGMII delay lines are configured
through the IOC.
Add the register layout and delay callback for both controllers so the
Rockchip glue driver can configure their RGMII and RMII interfaces and
select the appropriate clocks for each link speed.
Signed-off-by: Cunhao Lu <1579567540@qq.com>
---
drivers/net/ethernet/stmicro/stmmac/dwmac-rk.c | 53 ++++++++++++++++++++++++++
1 file changed, 53 insertions(+)
diff --git a/drivers/net/ethernet/stmicro/stmmac/dwmac-rk.c b/drivers/net/ethernet/stmicro/stmmac/dwmac-rk.c
index a37df5767d84..c9d8d8bf51f7 100644
--- a/drivers/net/ethernet/stmicro/stmmac/dwmac-rk.c
+++ b/drivers/net/ethernet/stmicro/stmmac/dwmac-rk.c
@@ -900,6 +900,58 @@ static const struct rk_gmac_ops rk3568_ops = {
},
};
+#define RK3572_VCCIO0_3_VO_IOC_CON1 0x10608
+#define RK3572_VCCIO1_2_4_VI_IOC_CON1 0x12604
+#define RK3572_VCCIO5_6_IOC_MISC0 0x14630
+#define RK3572_PHP_GRF_GMAC0_CON 0x0070
+#define RK3572_NVM0_GRF_GMAC1_CON 0x0020
+
+static int rk3572_init(struct rk_priv_data *bsp_priv)
+{
+ switch (bsp_priv->id) {
+ case 0:
+ bsp_priv->gmac_grf_reg = RK3572_PHP_GRF_GMAC0_CON;
+ break;
+ case 1:
+ bsp_priv->gmac_grf_reg = RK3572_NVM0_GRF_GMAC1_CON;
+ break;
+ default:
+ return -EINVAL;
+ }
+
+ bsp_priv->clock_grf_reg = bsp_priv->gmac_grf_reg;
+ return 0;
+}
+
+static void rk3572_set_to_rgmii(struct rk_priv_data *bsp_priv,
+ int tx_delay, int rx_delay)
+{
+ u32 val = GRF_FIELD(14, 8, rx_delay) | GRF_FIELD(6, 0, tx_delay) |
+ GRF_FIELD(15, 15, !!rx_delay) | GRF_FIELD(7, 7, !!tx_delay);
+
+ if (bsp_priv->id == 1) {
+ regmap_write(bsp_priv->php_grf, RK3572_VCCIO0_3_VO_IOC_CON1, val);
+ regmap_write(bsp_priv->php_grf, RK3572_VCCIO5_6_IOC_MISC0, val);
+ } else {
+ regmap_write(bsp_priv->php_grf, RK3572_VCCIO1_2_4_VI_IOC_CON1, val);
+ }
+}
+
+static const struct rk_gmac_ops rk3572_ops = {
+ .init = rk3572_init,
+ .set_to_rgmii = rk3572_set_to_rgmii,
+ .gmac_phy_intf_sel_mask = GENMASK_U16(11, 9),
+ .gmac_rmii_mode_mask = BIT_U16(3),
+ .clock.io_clksel_io_mask = BIT_U16(7),
+ .clock.gmii_clk_sel_mask = GENMASK_U16(6, 5),
+ .clock.rmii_clk_sel_mask = BIT_U16(5),
+ .clock.rmii_gate_en_mask = BIT_U16(4),
+ .supports_rmii = true,
+ .php_grf_required = true,
+ .regs_valid = true,
+ .regs = { 0x29d20000, 0x2a040000, 0 },
+};
+
/* VCCIO0_1_3_IOC */
#define RK3576_VCCIO0_1_3_IOC_CON2 0X6408
#define RK3576_VCCIO0_1_3_IOC_CON3 0X640c
@@ -1720,6 +1772,7 @@ static const struct of_device_id rk_gmac_dwmac_match[] = {
{ .compatible = "rockchip,rk3506-gmac", .data = &rk3506_ops },
{ .compatible = "rockchip,rk3528-gmac", .data = &rk3528_ops },
{ .compatible = "rockchip,rk3568-gmac", .data = &rk3568_ops },
+ { .compatible = "rockchip,rk3572-gmac", .data = &rk3572_ops },
{ .compatible = "rockchip,rk3576-gmac", .data = &rk3576_ops },
{ .compatible = "rockchip,rk3588-gmac", .data = &rk3588_ops },
{ .compatible = "rockchip,rv1108-gmac", .data = &rv1108_ops },
--
2.34.1
^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: [PATCH net-next v3 0/2] net: stmmac: Add RK3572 support
2026-11-16 7:39 [PATCH net-next v3 0/2] net: stmmac: Add RK3572 support Cunhao Lu via B4 Relay
2026-11-16 7:39 ` [PATCH net-next v3 1/2] dt-bindings: net: rockchip-dwmac: Add RK3572 Cunhao Lu via B4 Relay
2026-11-16 7:39 ` [PATCH net-next v3 2/2] net: stmmac: dwmac-rk: Add RK3572 support Cunhao Lu via B4 Relay
@ 2026-11-16 13:43 ` Andrew Lunn
2 siblings, 0 replies; 8+ messages in thread
From: Andrew Lunn @ 2026-11-16 13:43 UTC (permalink / raw)
To: 1579567540
Cc: Andrew Lunn, David S. Miller, Eric Dumazet, Jakub Kicinski,
Paolo Abeni, Rob Herring, Krzysztof Kozlowski, Conor Dooley,
Heiko Stuebner, David Wu, Alexandre Torgue, Giuseppe Cavallaro,
Jose Abreu, Maxime Chevallier, Maxime Coquelin, netdev,
devicetree, linux-arm-kernel, linux-rockchip, linux-kernel,
linux-stm32
On Mon, Nov 16, 2026 at 03:39:13PM +0800, Cunhao Lu via B4 Relay wrote:
> This is one of the subsystem submissions for RK3572 support.
>
> This series adds the RK3572 GMAC bindings and support for both Ethernet
> controllers in the Rockchip stmmac glue driver. It provides RGMII and
> RMII mode and clock control, together with RGMII delay configuration.
>
> The RK3572 SoC has eight CPU cores: two Cortex-A73 cores and six
> Cortex-A53 cores. It also integrates an Arm Mali-G310V2 MC1 GPU.
> The OK3572-C board provides two Gigabit Ethernet ports, three USB3 Type-A
> ports, a Type-C dual-role port, eMMC, microSD, and UART.
>
> Testing was performed with Debian 13 minimal and Linux 7.3 on the
> OK3572-C with the FET3572-C module.
>
> Passed functionality:
>
> - SD and eMMC complete the firmware, kernel, and root filesystem
> boot chain.
> - UART console works at 1500000 baud.
> - SD read/write and data persistence checks pass.
> - All eight CPUs start; CPU frequency scaling and hotplug checks pass.
> - Both Ethernet ports obtain IPv4 addresses and pass bidirectional file
> transfers.
> - All three Type-A ports pass USB2 and USB3 enumeration, data transfers,
> and reconnect persistence checks.
> - Type-C host and device modes pass in both plug orientations. Physical
> reconnects correctly select the expected device, host, and device roles
> in sequence.
>
> Stability:
>
> - Repeated cold and software reboots complete on SD and eMMC without data
> integrity failures.
> - A combined CPU, memory, network, SD, and USB3 stress test completes
> without a crash, lockup, CPU offline event, or thermal shutdown.
> - Ethernet error and drop counters do not increase during bidirectional
> network tests.
>
> Build and checks:
>
> - The kernel, modules, and board DTB build successfully.
> - The series passes checkpatch with --strict.
>
> Untested hardware and paths:
>
> - NPU
> - PCIe
> - GPU, video output, and audio
> - Other low-speed external interfaces
Most of this is irrelevant for netdev. Please write your merge commit
message for the subsystem doing to merge.
Andrew
^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: [PATCH net-next v3 1/2] dt-bindings: net: rockchip-dwmac: Add RK3572
2026-11-16 7:39 ` [PATCH net-next v3 1/2] dt-bindings: net: rockchip-dwmac: Add RK3572 Cunhao Lu via B4 Relay
@ 2026-11-16 13:44 ` Andrew Lunn
0 siblings, 0 replies; 8+ messages in thread
From: Andrew Lunn @ 2026-11-16 13:44 UTC (permalink / raw)
To: 1579567540
Cc: Andrew Lunn, David S. Miller, Eric Dumazet, Jakub Kicinski,
Paolo Abeni, Rob Herring, Krzysztof Kozlowski, Conor Dooley,
Heiko Stuebner, David Wu, Alexandre Torgue, Giuseppe Cavallaro,
Jose Abreu, Maxime Chevallier, Maxime Coquelin, netdev,
devicetree, linux-arm-kernel, linux-rockchip, linux-kernel,
linux-stm32
On Mon, Nov 16, 2026 at 03:39:14PM +0800, Cunhao Lu via B4 Relay wrote:
> From: Cunhao Lu <1579567540@qq.com>
>
> Add the rockchip,rk3572-gmac compatible with the snps,dwmac-4.20a
> fallback and require rockchip,php-grf.
>
> Mark tx_delay and rx_delay as deprecated and disallow them for RK3572
> so new designs do not use the legacy delay properties.
>
> Signed-off-by: Cunhao Lu <1579567540@qq.com>
Reviewed-by: Andrew Lunn <andrew@lunn.ch>
Andrew
^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: [PATCH net-next v3 2/2] net: stmmac: dwmac-rk: Add RK3572 support
2026-11-16 7:39 ` [PATCH net-next v3 2/2] net: stmmac: dwmac-rk: Add RK3572 support Cunhao Lu via B4 Relay
@ 2026-11-16 13:55 ` Andrew Lunn
2026-11-16 15:11 ` Cunhao Lu
0 siblings, 1 reply; 8+ messages in thread
From: Andrew Lunn @ 2026-11-16 13:55 UTC (permalink / raw)
To: 1579567540
Cc: Andrew Lunn, David S. Miller, Eric Dumazet, Jakub Kicinski,
Paolo Abeni, Rob Herring, Krzysztof Kozlowski, Conor Dooley,
Heiko Stuebner, David Wu, Alexandre Torgue, Giuseppe Cavallaro,
Jose Abreu, Maxime Chevallier, Maxime Coquelin, netdev,
devicetree, linux-arm-kernel, linux-rockchip, linux-kernel,
linux-stm32
> +static void rk3572_set_to_rgmii(struct rk_priv_data *bsp_priv,
> + int tx_delay, int rx_delay)
> +{
> + u32 val = GRF_FIELD(14, 8, rx_delay) | GRF_FIELD(6, 0, tx_delay) |
> + GRF_FIELD(15, 15, !!rx_delay) | GRF_FIELD(7, 7, !!tx_delay);
> +
> + if (bsp_priv->id == 1) {
> + regmap_write(bsp_priv->php_grf, RK3572_VCCIO0_3_VO_IOC_CON1, val);
> + regmap_write(bsp_priv->php_grf, RK3572_VCCIO5_6_IOC_MISC0, val);
> + } else {
> + regmap_write(bsp_priv->php_grf, RK3572_VCCIO1_2_4_VI_IOC_CON1, val);
> + }
> +}
> +
> +static const struct rk_gmac_ops rk3572_ops = {
> + .init = rk3572_init,
> + .set_to_rgmii = rk3572_set_to_rgmii,
> + .gmac_phy_intf_sel_mask = GENMASK_U16(11, 9),
> + .gmac_rmii_mode_mask = BIT_U16(3),
> + .clock.io_clksel_io_mask = BIT_U16(7),
> + .clock.gmii_clk_sel_mask = GENMASK_U16(6, 5),
> + .clock.rmii_clk_sel_mask = BIT_U16(5),
> + .clock.rmii_gate_en_mask = BIT_U16(4),
> + .supports_rmii = true,
> + .php_grf_required = true,
> + .regs_valid = true,
> + .regs = { 0x29d20000, 0x2a040000, 0 },
> +};
Just looking at this, it is not obvious that rx_delay and tx_delay are
actually not used.
Andrew
^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: [PATCH net-next v3 2/2] net: stmmac: dwmac-rk: Add RK3572 support
2026-11-16 13:55 ` Andrew Lunn
@ 2026-11-16 15:11 ` Cunhao Lu
2026-11-16 15:58 ` Andrew Lunn
0 siblings, 1 reply; 8+ messages in thread
From: Cunhao Lu @ 2026-11-16 15:11 UTC (permalink / raw)
To: Andrew Lunn
Cc: Andrew Lunn, David S. Miller, Eric Dumazet, Jakub Kicinski,
Paolo Abeni, Rob Herring, Krzysztof Kozlowski, Conor Dooley,
Heiko Stuebner, David Wu, Alexandre Torgue, Giuseppe Cavallaro,
Jose Abreu, Maxime Chevallier, Maxime Coquelin, netdev,
devicetree, linux-arm-kernel, linux-rockchip, linux-kernel,
linux-stm32
Hi,
> [...]
> > + .regs_valid = true,
> > + .regs = { 0x29d20000, 0x2a040000, 0 },
> > +};
>
> Just looking at this, it is not obvious that rx_delay and tx_delay are
> actually not used.
My board currently uses rgmii-id, where both MAC TX and RX delays
are disabled. I kept the delay handling to support rgmii-rxid,
rgmii-txid and rgmii, using the default values for the MAC delays
enabled in those modes. The legacy tx_delay and rx_delay properties
are now disallowed for RK3572 in the binding.
I currently have only one oscilloscope, with a maximum bandwidth of
200 MHz. With this equipment, I cannot accurately determine how the
TX and RX delay register values translate to picoseconds, so I am
not planning to add support for tx-internal-delay-ps and
rx-internal-delay-ps in this series for now.
Would it be acceptable to support only rgmii-id for RGMII in the next
version, and reject rgmii, rgmii-rxid and rgmii-txid? This would let me
stop using tx_delay and rx_delay in the RK3572 driver path as well.
Best regards,
Cunhao Lu
^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: [PATCH net-next v3 2/2] net: stmmac: dwmac-rk: Add RK3572 support
2026-11-16 15:11 ` Cunhao Lu
@ 2026-11-16 15:58 ` Andrew Lunn
0 siblings, 0 replies; 8+ messages in thread
From: Andrew Lunn @ 2026-11-16 15:58 UTC (permalink / raw)
To: Cunhao Lu
Cc: Andrew Lunn, David S. Miller, Eric Dumazet, Jakub Kicinski,
Paolo Abeni, Rob Herring, Krzysztof Kozlowski, Conor Dooley,
Heiko Stuebner, David Wu, Alexandre Torgue, Giuseppe Cavallaro,
Jose Abreu, Maxime Chevallier, Maxime Coquelin, netdev,
devicetree, linux-arm-kernel, linux-rockchip, linux-kernel,
linux-stm32
On Mon, Nov 16, 2026 at 11:11:42PM +0800, Cunhao Lu wrote:
> Hi,
>
> > [...]
> > > + .regs_valid = true,
> > > + .regs = { 0x29d20000, 0x2a040000, 0 },
> > > +};
> >
> > Just looking at this, it is not obvious that rx_delay and tx_delay are
> > actually not used.
>
> My board currently uses rgmii-id, where both MAC TX and RX delays
> are disabled. I kept the delay handling to support rgmii-rxid,
> rgmii-txid and rgmii, using the default values for the MAC delays
> enabled in those modes. The legacy tx_delay and rx_delay properties
> are now disallowed for RK3572 in the binding.
>
> I currently have only one oscilloscope, with a maximum bandwidth of
> 200 MHz. With this equipment, I cannot accurately determine how the
> TX and RX delay register values translate to picoseconds, so I am
> not planning to add support for tx-internal-delay-ps and
> rx-internal-delay-ps in this series for now.
>
> Would it be acceptable to support only rgmii-id for RGMII in the next
> version, and reject rgmii, rgmii-rxid and rgmii-txid? This would let me
> stop using tx_delay and rx_delay in the RK3572 driver path as well.
No, rgmii, rgmii-rxid and rgmii-txid are valid, it depends on the PCB
design.
https://elixir.bootlin.com/linux/v6.15/source/Documentation/devicetree/bindings/net/ethernet-controller.yaml#L287
What i would prefer is that the C code does not parse the rx_delay and
tx_delay properties. If somebody actually needs them, they need to
implement tx-internal-delay-ps and rx-internal-delay-ps. Since you
don't need them, you don't need to implement them.
Andrew
^ permalink raw reply [flat|nested] 8+ messages in thread
end of thread, other threads:[~2026-11-16 15:58 UTC | newest]
Thread overview: 8+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2026-11-16 7:39 [PATCH net-next v3 0/2] net: stmmac: Add RK3572 support Cunhao Lu via B4 Relay
2026-11-16 7:39 ` [PATCH net-next v3 1/2] dt-bindings: net: rockchip-dwmac: Add RK3572 Cunhao Lu via B4 Relay
2026-11-16 13:44 ` Andrew Lunn
2026-11-16 7:39 ` [PATCH net-next v3 2/2] net: stmmac: dwmac-rk: Add RK3572 support Cunhao Lu via B4 Relay
2026-11-16 13:55 ` Andrew Lunn
2026-11-16 15:11 ` Cunhao Lu
2026-11-16 15:58 ` Andrew Lunn
2026-11-16 13:43 ` [PATCH net-next v3 0/2] net: stmmac: " Andrew Lunn
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®