* [PATCH] dmaengine: idxd: Delete unnecessary NULL check
@ 2025-01-08 9:13 Dan Carpenter
2025-01-18 0:17 ` Fenghua Yu
2025-02-10 14:35 ` Vinod Koul
0 siblings, 2 replies; 3+ messages in thread
From: Dan Carpenter @ 2025-01-08 9:13 UTC (permalink / raw)
To: Fenghua Yu
Cc: Dave Jiang, Vinod Koul, dmaengine, linux-kernel, kernel-janitors
The "saved_evl" pointer is a offset into the middle of a non-NULL struct.
It can't be NULL and the check is slightly confusing. Delete the check.
Signed-off-by: Dan Carpenter <dan.carpenter@linaro.org>
---
drivers/dma/idxd/init.c | 3 +--
1 file changed, 1 insertion(+), 2 deletions(-)
diff --git a/drivers/dma/idxd/init.c b/drivers/dma/idxd/init.c
index b946f78f85e1..fca1d2924999 100644
--- a/drivers/dma/idxd/init.c
+++ b/drivers/dma/idxd/init.c
@@ -912,8 +912,7 @@ static void idxd_device_config_restore(struct idxd_device *idxd,
idxd->rdbuf_limit = idxd_saved->saved_idxd.rdbuf_limit;
- if (saved_evl)
- idxd->evl->size = saved_evl->size;
+ idxd->evl->size = saved_evl->size;
for (i = 0; i < idxd->max_groups; i++) {
struct idxd_group *saved_group, *group;
--
2.45.2
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] dmaengine: idxd: Delete unnecessary NULL check
2025-01-08 9:13 [PATCH] dmaengine: idxd: Delete unnecessary NULL check Dan Carpenter
@ 2025-01-18 0:17 ` Fenghua Yu
2025-02-10 14:35 ` Vinod Koul
1 sibling, 0 replies; 3+ messages in thread
From: Fenghua Yu @ 2025-01-18 0:17 UTC (permalink / raw)
To: Dan Carpenter
Cc: Dave Jiang, Vinod Koul, dmaengine, linux-kernel, kernel-janitors
On 1/8/25 01:13, Dan Carpenter wrote:
> The "saved_evl" pointer is a offset into the middle of a non-NULL struct.
> It can't be NULL and the check is slightly confusing. Delete the check.
>
> Signed-off-by: Dan Carpenter <dan.carpenter@linaro.org>
Reviewed-by: Fenghua Yu <fenghua.yu@intel.com>
> ---
> drivers/dma/idxd/init.c | 3 +--
> 1 file changed, 1 insertion(+), 2 deletions(-)
>
> diff --git a/drivers/dma/idxd/init.c b/drivers/dma/idxd/init.c
> index b946f78f85e1..fca1d2924999 100644
> --- a/drivers/dma/idxd/init.c
> +++ b/drivers/dma/idxd/init.c
> @@ -912,8 +912,7 @@ static void idxd_device_config_restore(struct idxd_device *idxd,
>
> idxd->rdbuf_limit = idxd_saved->saved_idxd.rdbuf_limit;
>
> - if (saved_evl)
> - idxd->evl->size = saved_evl->size;
> + idxd->evl->size = saved_evl->size;
>
> for (i = 0; i < idxd->max_groups; i++) {
> struct idxd_group *saved_group, *group;
Thanks.
-Fenghua
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] dmaengine: idxd: Delete unnecessary NULL check
2025-01-08 9:13 [PATCH] dmaengine: idxd: Delete unnecessary NULL check Dan Carpenter
2025-01-18 0:17 ` Fenghua Yu
@ 2025-02-10 14:35 ` Vinod Koul
1 sibling, 0 replies; 3+ messages in thread
From: Vinod Koul @ 2025-02-10 14:35 UTC (permalink / raw)
To: Fenghua Yu, Dan Carpenter
Cc: Dave Jiang, dmaengine, linux-kernel, kernel-janitors
On Wed, 08 Jan 2025 12:13:20 +0300, Dan Carpenter wrote:
> The "saved_evl" pointer is a offset into the middle of a non-NULL struct.
> It can't be NULL and the check is slightly confusing. Delete the check.
>
>
Applied, thanks!
[1/1] dmaengine: idxd: Delete unnecessary NULL check
commit: 2c17e9ea0caa5555e31e154fa1b06260b816f5cc
Best regards,
--
~Vinod
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2025-02-10 14:35 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2025-01-08 9:13 [PATCH] dmaengine: idxd: Delete unnecessary NULL check Dan Carpenter
2025-01-18 0:17 ` Fenghua Yu
2025-02-10 14:35 ` Vinod Koul
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®