[PATCH][next] ASoC: SOF: Intel: hda-stream: Fix incorrect variable used in error message

[PATCH][next] ASoC: SOF: Intel: hda-stream: Fix incorrect variable used in error message

[Colin Ian King]

The dev_err message is reporting an error about capture streams however
it is using the incorrect variable num_playback instead of num_capture.
Fix this by using the correct variable num_capture.

Fixes: a1d1e266b445 ("ASoC: SOF: Intel: Add Intel specific HDA stream operations")
Signed-off-by: Colin Ian King <colin.i.king@gmail.com>
---
 sound/soc/sof/intel/hda-stream.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/sound/soc/sof/intel/hda-stream.c b/sound/soc/sof/intel/hda-stream.c
index aa6b0247d5c9..a34f472ef175 100644
--- a/sound/soc/sof/intel/hda-stream.c
+++ b/sound/soc/sof/intel/hda-stream.c
@@ -890,7 +890,7 @@ int hda_dsp_stream_init(struct snd_sof_dev *sdev)
 
 	if (num_capture >= SOF_HDA_CAPTURE_STREAMS) {
 		dev_err(sdev->dev, "error: too many capture streams %d\n",
-			num_playback);
+			num_capture);
 		return -EINVAL;
 	}
 
-- 
2.51.0

Re: [PATCH][next] ASoC: SOF: Intel: hda-stream: Fix incorrect variable used in error message

[Péter Ujfalusi]

On 02/09/2025 15:06, Colin Ian King wrote:
> The dev_err message is reporting an error about capture streams however
> it is using the incorrect variable num_playback instead of num_capture.
> Fix this by using the correct variable num_capture.
> 
> Fixes: a1d1e266b445 ("ASoC: SOF: Intel: Add Intel specific HDA stream operations")
> Signed-off-by: Colin Ian King <colin.i.king@gmail.com>

Acked-by: Peter Ujfalusi <peter.ujfalusi@linux.intel.com>

> ---
>  sound/soc/sof/intel/hda-stream.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/sound/soc/sof/intel/hda-stream.c b/sound/soc/sof/intel/hda-stream.c
> index aa6b0247d5c9..a34f472ef175 100644
> --- a/sound/soc/sof/intel/hda-stream.c
> +++ b/sound/soc/sof/intel/hda-stream.c
> @@ -890,7 +890,7 @@ int hda_dsp_stream_init(struct snd_sof_dev *sdev)
>  
>  	if (num_capture >= SOF_HDA_CAPTURE_STREAMS) {
>  		dev_err(sdev->dev, "error: too many capture streams %d\n",
> -			num_playback);
> +			num_capture);
>  		return -EINVAL;
>  	}
>  

-- 
Péter

Re: [PATCH][next] ASoC: SOF: Intel: hda-stream: Fix incorrect variable used in error message

[Mark Brown]

On Tue, 02 Sep 2025 13:06:39 +0100, Colin Ian King wrote:
> The dev_err message is reporting an error about capture streams however
> it is using the incorrect variable num_playback instead of num_capture.
> Fix this by using the correct variable num_capture.
> 
> 

Applied to

   https://git.kernel.org/pub/scm/linux/kernel/git/broonie/sound.git for-next

Thanks!

[1/1] ASoC: SOF: Intel: hda-stream: Fix incorrect variable used in error message
      commit: 35fc531a59694f24a2456569cf7d1a9c6436841c

All being well this means that it will be integrated into the linux-next
tree (usually sometime in the next 24 hours) and sent to Linus during
the next merge window (or sooner if it is a bug fix), however if
problems are discovered then the patch may be dropped or reverted.

You may get further e-mails resulting from automated or manual testing
and review of the tree, please engage with people reporting problems and
send followup patches addressing any issues that are reported if needed.

If any updates are required or you are submitting further changes they
should be sent as incremental updates against current git, existing
patches will not be replaced.

Please add any relevant lists and maintainers to the CCs when replying
to this mail.

Thanks,
Mark