From: ally heev <allyheev@gmail.com>
To: Tony Nguyen <anthony.l.nguyen@intel.com>,
Przemek Kitszel <przemyslaw.kitszel@intel.com>,
Andrew Lunn <andrew+netdev@lunn.ch>,
"David S. Miller" <davem@davemloft.net>,
Eric Dumazet <edumazet@google.com>,
Jakub Kicinski <kuba@kernel.org>,
Paolo Abeni <pabeni@redhat.com>,
Alexander Lobakin <aleksander.lobakin@intel.com>
Cc: intel-wired-lan@lists.osuosl.org, netdev@vger.kernel.org,
linux-kernel@vger.kernel.org, Simon Horman <horms@kernel.org>,
Dan Carpenter <dan.carpenter@linaro.org>
Subject: Re: [RFT net-next PATCH RESEND 0/2] ethernet: intel: fix freeing uninitialized pointers with __free
Date: Wed, 03 Dec 2025 01:17:13 +0530 [thread overview]
Message-ID: <ec570c6f8c041f60f1de0b002e61e5a2971633c5.camel@gmail.com> (raw)
In-Reply-To: <81053279-f2da-420c-b7a1-9a81615cd7ca@intel.com>
On Mon, 2025-12-01 at 13:40 -0800, Tony Nguyen wrote:
>
> On 11/23/2025 11:40 PM, Ally Heev wrote:
> > Uninitialized pointers with `__free` attribute can cause undefined
> > behavior as the memory assigned randomly to the pointer is freed
> > automatically when the pointer goes out of scope.
> >
> > We could just fix it by initializing the pointer to NULL, but, as usage of
> > cleanup attributes is discouraged in net [1], trying to achieve cleanup
> > using goto
>
> These two drivers already have multiple other usages of this. All the
> other instances initialize to NULL; I'd prefer to see this do the same
> over changing this single instance.
>
Other usages are slightly complicated to be refactored and might need
good testing. Do you want me to do it in a different series?
Regards,
Ally
next prev parent reply other threads:[~2025-12-02 14:18 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-11-24 7:40 Ally Heev
2025-11-24 7:40 ` [PATCH RESEND RFT net-next 1/2] ice: remove __free usage in ice_flow Ally Heev
2025-11-24 10:00 ` [Intel-wired-lan] " Loktionov, Aleksandr
2025-11-24 7:40 ` [PATCH RESEND RFT net-next 2/2] idpf: remove __free usage in idpf_virtchnl Ally Heev
2025-11-24 9:59 ` [Intel-wired-lan] " Loktionov, Aleksandr
2025-12-01 21:40 ` [RFT net-next PATCH RESEND 0/2] ethernet: intel: fix freeing uninitialized pointers with __free Tony Nguyen
2025-12-02 19:47 ` ally heev [this message]
2025-12-02 18:17 ` [Intel-wired-lan] " Tony Nguyen
2025-12-03 8:09 ` ally heev
2025-12-03 8:45 ` Przemek Kitszel
2025-12-08 3:07 ` ally heev
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ec570c6f8c041f60f1de0b002e61e5a2971633c5.camel@gmail.com \
--to=allyheev@gmail.com \
--cc=aleksander.lobakin@intel.com \
--cc=andrew+netdev@lunn.ch \
--cc=anthony.l.nguyen@intel.com \
--cc=dan.carpenter@linaro.org \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=horms@kernel.org \
--cc=intel-wired-lan@lists.osuosl.org \
--cc=kuba@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=przemyslaw.kitszel@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®