* [PATCH][next] net: hns: fix unsigned comparison to less than zero
@ 2019-04-05 13:59 Colin King
2019-04-05 14:10 ` Mukesh Ojha
2019-04-07 1:29 ` David Miller
0 siblings, 2 replies; 3+ messages in thread
From: Colin King @ 2019-04-05 13:59 UTC (permalink / raw)
To: Yisen Zhuang, Salil Mehta, David S . Miller, Yonglong Liu, netdev
Cc: kernel-janitors, linux-kernel
From: Colin Ian King <colin.king@canonical.com>
Currently mskid is unsigned and hence comparisons with negative
error return values are always false. Fix this by making mskid an
int.
Fixes: f058e46855dc ("net: hns: fix ICMP6 neighbor solicitation messages discard problem")
Addresses-Coverity: ("Operands don't affect result")
Signed-off-by: Colin Ian King <colin.king@canonical.com>
---
drivers/net/ethernet/hisilicon/hns/hns_dsaf_main.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/net/ethernet/hisilicon/hns/hns_dsaf_main.c b/drivers/net/ethernet/hisilicon/hns/hns_dsaf_main.c
index 61eea6ac846f..e05d2095d09b 100644
--- a/drivers/net/ethernet/hisilicon/hns/hns_dsaf_main.c
+++ b/drivers/net/ethernet/hisilicon/hns/hns_dsaf_main.c
@@ -2769,7 +2769,7 @@ static void set_promisc_tcam_enable(struct dsaf_device *dsaf_dev, u32 port)
struct hns_mac_cb *mac_cb;
u8 addr[ETH_ALEN] = {0};
u8 port_num;
- u16 mskid;
+ int mskid;
/* promisc use vague table match with vlanid = 0 & macaddr = 0 */
hns_dsaf_set_mac_key(dsaf_dev, &mac_key, 0x00, port, addr);
--
2.20.1
^ permalink raw reply [flat|nested] 3+ messages in thread* Re: [PATCH][next] net: hns: fix unsigned comparison to less than zero
2019-04-05 13:59 [PATCH][next] net: hns: fix unsigned comparison to less than zero Colin King
@ 2019-04-05 14:10 ` Mukesh Ojha
2019-04-07 1:29 ` David Miller
1 sibling, 0 replies; 3+ messages in thread
From: Mukesh Ojha @ 2019-04-05 14:10 UTC (permalink / raw)
To: Colin King, Yisen Zhuang, Salil Mehta, David S . Miller,
Yonglong Liu, netdev
Cc: kernel-janitors, linux-kernel
On 4/5/2019 7:29 PM, Colin King wrote:
> From: Colin Ian King <colin.king@canonical.com>
>
> Currently mskid is unsigned and hence comparisons with negative
> error return values are always false. Fix this by making mskid an
> int.
>
> Fixes: f058e46855dc ("net: hns: fix ICMP6 neighbor solicitation messages discard problem")
> Addresses-Coverity: ("Operands don't affect result")
> Signed-off-by: Colin Ian King <colin.king@canonical.com>
Reviewed-by: Mukesh Ojha <mojha@codeaurora.org>
Cheers,
-Mukesh
> ---
> drivers/net/ethernet/hisilicon/hns/hns_dsaf_main.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/net/ethernet/hisilicon/hns/hns_dsaf_main.c b/drivers/net/ethernet/hisilicon/hns/hns_dsaf_main.c
> index 61eea6ac846f..e05d2095d09b 100644
> --- a/drivers/net/ethernet/hisilicon/hns/hns_dsaf_main.c
> +++ b/drivers/net/ethernet/hisilicon/hns/hns_dsaf_main.c
> @@ -2769,7 +2769,7 @@ static void set_promisc_tcam_enable(struct dsaf_device *dsaf_dev, u32 port)
> struct hns_mac_cb *mac_cb;
> u8 addr[ETH_ALEN] = {0};
> u8 port_num;
> - u16 mskid;
> + int mskid;
>
> /* promisc use vague table match with vlanid = 0 & macaddr = 0 */
> hns_dsaf_set_mac_key(dsaf_dev, &mac_key, 0x00, port, addr);
^ permalink raw reply [flat|nested] 3+ messages in thread* Re: [PATCH][next] net: hns: fix unsigned comparison to less than zero
2019-04-05 13:59 [PATCH][next] net: hns: fix unsigned comparison to less than zero Colin King
2019-04-05 14:10 ` Mukesh Ojha
@ 2019-04-07 1:29 ` David Miller
1 sibling, 0 replies; 3+ messages in thread
From: David Miller @ 2019-04-07 1:29 UTC (permalink / raw)
To: colin.king
Cc: yisen.zhuang, salil.mehta, liuyonglong, netdev, kernel-janitors,
linux-kernel
From: Colin King <colin.king@canonical.com>
Date: Fri, 5 Apr 2019 14:59:16 +0100
> From: Colin Ian King <colin.king@canonical.com>
>
> Currently mskid is unsigned and hence comparisons with negative
> error return values are always false. Fix this by making mskid an
> int.
>
> Fixes: f058e46855dc ("net: hns: fix ICMP6 neighbor solicitation messages discard problem")
> Addresses-Coverity: ("Operands don't affect result")
> Signed-off-by: Colin Ian King <colin.king@canonical.com>
Applied.
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2019-04-07 1:29 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-04-05 13:59 [PATCH][next] net: hns: fix unsigned comparison to less than zero Colin King
2019-04-05 14:10 ` Mukesh Ojha
2019-04-07 1:29 ` David Miller
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome