From: Peter Ujfalusi <peter.ujfalusi@ti.com>
To: Xu Wang <vulab@iscas.ac.cn>, <lgirdwood@gmail.com>,
<broonie@kernel.org>, <perex@perex.cz>, <tiwai@suse.com>,
<alsa-devel@alsa-project.org>
Cc: <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] ASoC: ti: davinci-evm: Remove redundant null check before clk_disable_unprepare
Date: Mon, 2 Nov 2020 10:18:24 +0200 [thread overview]
Message-ID: <ec63e4cc-b723-d183-8205-20fd0debbb43@ti.com> (raw)
In-Reply-To: <20201029082513.28233-1-vulab@iscas.ac.cn>
On 29/10/2020 10.25, Xu Wang wrote:
> Because clk_disable_unprepare() already checked NULL clock parameter,
> so the additional check is unnecessary, just remove it.
Acked-by: Peter Ujfalusi <peter.ujfalusi@ti.com>
> Signed-off-by: Xu Wang <vulab@iscas.ac.cn>
> ---
> sound/soc/ti/davinci-evm.c | 3 +--
> 1 file changed, 1 insertion(+), 2 deletions(-)
>
> diff --git a/sound/soc/ti/davinci-evm.c b/sound/soc/ti/davinci-evm.c
> index 105e56ab9cdc..b043a0070d20 100644
> --- a/sound/soc/ti/davinci-evm.c
> +++ b/sound/soc/ti/davinci-evm.c
> @@ -46,8 +46,7 @@ static void evm_shutdown(struct snd_pcm_substream *substream)
> struct snd_soc_card_drvdata_davinci *drvdata =
> snd_soc_card_get_drvdata(soc_card);
>
> - if (drvdata->mclk)
> - clk_disable_unprepare(drvdata->mclk);
> + clk_disable_unprepare(drvdata->mclk);
> }
>
> static int evm_hw_params(struct snd_pcm_substream *substream,
>
- Péter
Texas Instruments Finland Oy, Porkkalankatu 22, 00180 Helsinki.
Y-tunnus/Business ID: 0615521-4. Kotipaikka/Domicile: Helsinki
next prev parent reply other threads:[~2020-11-02 8:18 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-10-29 8:25 Xu Wang
2020-11-02 8:18 ` Peter Ujfalusi [this message]
2020-11-02 17:18 ` Mark Brown
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ec63e4cc-b723-d183-8205-20fd0debbb43@ti.com \
--to=peter.ujfalusi@ti.com \
--cc=alsa-devel@alsa-project.org \
--cc=broonie@kernel.org \
--cc=lgirdwood@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=perex@perex.cz \
--cc=tiwai@suse.com \
--cc=vulab@iscas.ac.cn \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®