[PATCH] dmaengine: amlogic: fix workqueque not free when probe failed

[PATCH] dmaengine: amlogic: fix workqueque not free when probe failed

[Xianwei Zhao via B4 Relay]

From: Xianwei Zhao <xianwei.zhao@amlogic.com>

when probe failed, workqueue not free. Convert the driver to use
devm_alloc_ordered_workqueue() for allocating the workqueue. This
ties the workqueue lifetime to the device and removes the need for
explicitly destroying it in the remove callback.

Fixes: b84b5197e344 ("dmaengine: amlogic: Add general DMA driver for A9")
Signed-off-by: Xianwei Zhao <xianwei.zhao@amlogic.com>
---
Fix workqueque not free when probe failed.
---
 drivers/dma/amlogic-dma.c | 3 +--
 1 file changed, 1 insertion(+), 2 deletions(-)

diff --git a/drivers/dma/amlogic-dma.c b/drivers/dma/amlogic-dma.c
index 684121d13fca..791bd82743d3 100644
--- a/drivers/dma/amlogic-dma.c
+++ b/drivers/dma/amlogic-dma.c
@@ -620,7 +620,7 @@ static int aml_dma_probe(struct platform_device *pdev)
 	if (!aml_dma)
 		return -ENOMEM;
 
-	aml_dma->free_wq = alloc_ordered_workqueue("aml_dma_free", 0);
+	aml_dma->free_wq = devm_alloc_ordered_workqueue(&pdev->dev, "aml_dma_free", 0);
 	if (!aml_dma->free_wq)
 		return -ENOMEM;
 
@@ -712,7 +712,6 @@ static void aml_dma_remove(struct platform_device *pdev)
 		if (aml_chan)
 			tasklet_kill(&aml_chan->vchan.task);
 	}
-	destroy_workqueue(aml_dma->free_wq);
 }
 
 static const struct of_device_id aml_dma_ids[] = {

---
base-commit: aff5e6a77fc69a7c490246465940d18422d7c631
change-id: 20261023-fix-a9-dma-wq-71fef50dff9b

Best regards,
-- 
Xianwei Zhao <xianwei.zhao@amlogic.com>

Re: [PATCH] dmaengine: amlogic: fix workqueque not free when probe failed

[Markus Elfring]

> when probe failed, workqueue not free. Convert the driver to use
…

I find this wording approach improvable.

See also:
[PATCH v2] dmaengine: amlogic: Fix missing destroy_workqueue() at error path in aml_dma_probe()
https://lore.kernel.org/dmaengine/13a835b1770e360af7991bb4c91ce52a8d01e331.1792785154.git.christophe.jaillet@wanadoo.fr/

Regards,
Markus

Re: [PATCH] dmaengine: amlogic: fix workqueque not free when probe failed

[Xianwei Zhao]

Hi Markus,
    Sorry, I didn't notice the submission you sent. I will drop my 
submission.

On 2026/10/25 15:05, Markus Elfring wrote:
>> when probe failed, workqueue not free. Convert the driver to use
> …
> 
> I find this wording approach improvable.
> 
> See also:
> [PATCH v2] dmaengine: amlogic: Fix missing destroy_workqueue() at error path in aml_dma_probe()
> https://lore.kernel.org/dmaengine/13a835b1770e360af7991bb4c91ce52a8d01e331.1792785154.git.christophe.jaillet@wanadoo.fr/
> 
> Regards,
> Markus

Re: [PATCH] dmaengine: amlogic: fix workqueque not free when probe failed

[Xianwei Zhao]

On 2026/10/26 10:30, Xianwei Zhao wrote:
> Hi Markus,
>     Sorry, I didn't notice the submission you sent. I will drop my 
> submission.
> 

Hi Markus,
     I didn't notice that you hadn't sent it when I submitted it. Of 
course, whoever submits it is fine as long as this problem can be 
solved. Please see if I can continue to submit or keep yours?

> On 2026/10/25 15:05, Markus Elfring wrote:
>>> when probe failed, workqueue not free. Convert the driver to use
>> …
>>
>> I find this wording approach improvable.
>>
>> See also:
>> [PATCH v2] dmaengine: amlogic: Fix missing destroy_workqueue() at 
>> error path in aml_dma_probe()
>> https://lore.kernel.org/dmaengine/13a835b1770e360af7991bb4c91ce52a8d01e331.1792785154.git.christophe.jaillet@wanadoo.fr/
>>
>> Regards,
>> Markus