mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Ziliang Liao <saraday@hust.edu.cn>
To: Linus Walleij <linus.walleij@linaro.org>
Cc: Andy Gross <agross@kernel.org>,
	Bjorn Andersson <andersson@kernel.org>,
	Konrad Dybcio <konrad.dybcio@linaro.org>,
	hust-os-kernel-patches@googlegroups.com,
	Dongliang Mu <dzm91@hust.edu.cn>,
	linux-arm-msm@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 2/2] bus: qcom-ebi2: simplify the code in qcom_ebi2_probe()
Date: Tue, 9 May 2023 00:22:10 +0800	[thread overview]
Message-ID: <ecc36fdc-a87b-4b0d-bf2b-cfdd030b0600@hust.edu.cn> (raw)
In-Reply-To: <CACRpkdZvTd4ibqhS2xQ_7BWLEkXzB_0qguccEV2X0d77KhC2UA@mail.gmail.com>

Thanks for your advice.
Do I need to delete the Fixes in [PATCH 2/2] and resend another patch set?

> On Sun, Apr 30, 2023 at 2:54 PM Ziliang Liao <saraday@hust.edu.cn> wrote:
>
>> The code use platform_get_resource() and devm_ioremap_resource() to
>> allocate memory resources for the device. It can be simplified by using
>> devm_platform_ioremap_resource().
>>
>> Fixes: 335a12754808 ("bus: qcom: add EBI2 driver")
> It doesn't need Fixes: if it's not a bug, but who cares. Maybe
> the stable maintainers care.
>
>> Signed-off-by: Ziliang Liao <saraday@hust.edu.cn>
>> Reviewed-by: Dongliang Mu <dzm91@hust.edu.cn>
> Reviewed-by: Linus Walleij <linus.walleij@linaro.org>
>
> Yours,
> Linus Walleij

  reply	other threads:[~2023-05-08 16:22 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-04-30 12:51 [PATCH 1/2] bus: qcom-ebi2: use prefix devm for clock resource allocation functions Ziliang Liao
2023-04-30 12:51 ` [PATCH 2/2] bus: qcom-ebi2: simplify the code in qcom_ebi2_probe() Ziliang Liao
2023-05-08 13:35   ` Linus Walleij
2023-05-08 16:22     ` Ziliang Liao [this message]
2023-05-09  7:06       ` Linus Walleij
2023-05-08 13:34 ` [PATCH 1/2] bus: qcom-ebi2: use prefix devm for clock resource allocation functions Linus Walleij

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=ecc36fdc-a87b-4b0d-bf2b-cfdd030b0600@hust.edu.cn \
    --to=saraday@hust.edu.cn \
    --cc=agross@kernel.org \
    --cc=andersson@kernel.org \
    --cc=dzm91@hust.edu.cn \
    --cc=hust-os-kernel-patches@googlegroups.com \
    --cc=konrad.dybcio@linaro.org \
    --cc=linus.walleij@linaro.org \
    --cc=linux-arm-msm@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®