From: "Chang S. Bae" <chang.seok.bae@intel.com>
To: Andrei Vagin <avagin@google.com>
Cc: Thomas Gleixner <tglx@kernel.org>, Ingo Molnar <mingo@redhat.com>,
Borislav Petkov <bp@alien8.de>, <linux-kernel@vger.kernel.org>,
<criu@lists.linux.dev>, Dave Hansen <dave.hansen@linux.intel.com>,
<x86@kernel.org>, "H. Peter Anvin" <hpa@zytor.com>
Subject: Re: [PATCH 09/10] x86/fpu: Allow restoring signal frames with larger xstate_size
Date: Fri, 10 Jul 2026 15:24:38 -0700 [thread overview]
Message-ID: <ecd95f49-0628-427f-9891-a22202f41ac1@intel.com> (raw)
In-Reply-To: <b3ecd9ab-fc00-4e6e-94b3-9f7c351edc97@intel.com>
On 7/9/2026 2:14 PM, Chang S. Bae wrote:
>
> Assuming the target task has never touched the dynamic state, if fx_sw-
> >xstate_size > fpstate->user_size is permitted, while fx_sw->xfeatures
> is still used directly as the XRSTOR RFBM, I think it may be possible to
> trigger an ugly #NM in the kernel along the way when
> CONFIG_X86_DEBUG_FPU=n. If CONFIG_X86_DEBUG_FPU=y, xfd_validate_state()
> could guard this by clearing the bit as part of its consistency check.
Bah, I should have doubted myself how the debug option could alter the
behavior. No, it only emits a warning out if it detects an inconsistency
between the RFBM and XFD state. So a screwed sigframe could still
trigger an in-kernel #NM during XRSTOR regardless of that config. The
relevant text from SDM Vol. 1 Section 13.14 says:
If XRSTOR or XRSTORS is loading state component i and bit i of the
XSTATE_BV field of the XSAVE header is 0, the instruction does not
generate #NM when XCR0[i] = IA32_XFD[i] = 1; instead, it initializes
the state component normally. (If bit i of the XSTATE_BV field of the
XSAVE header is 1, the instruction does generate #NM.)
Thanks,
Chang
next prev parent reply other threads:[~2026-07-10 22:24 UTC|newest]
Thread overview: 30+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-06-15 19:37 [PATCH v3 0/10] x86/fpu: Restore and reinforce signal frame portability Andrei Vagin
2026-06-15 19:37 ` [PATCH 01/10] x86/fpu: Document " Andrei Vagin
2026-06-26 13:51 ` Alexander Mikhalitsyn
2026-06-30 19:23 ` Chang S. Bae
2026-06-15 19:37 ` [PATCH 02/10] x86/fpu: Clean up and rename variables in signal frame handling Andrei Vagin
2026-06-26 17:05 ` Alexander Mikhalitsyn
2026-06-15 19:37 ` [PATCH 03/10] x86/fpu: Split __fpu_restore_sig to extract compat path Andrei Vagin
2026-06-26 17:20 ` Alexander Mikhalitsyn
2026-06-15 19:37 ` [PATCH 04/10] x86/fpu: Document reasoning of FX-only fallback Andrei Vagin
2026-06-26 14:22 ` Alexander Mikhalitsyn
2026-06-30 19:23 ` Chang S. Bae
2026-06-15 19:37 ` [PATCH 05/10] x86/fpu: Fix potential underflow in xstate_calculate_size() Andrei Vagin
2026-06-26 14:32 ` Alexander Mikhalitsyn
2026-06-30 19:23 ` Chang S. Bae
2026-06-15 19:37 ` [PATCH 06/10] selftests/x86: Add a test for signal frame FPU portability Andrei Vagin
2026-06-26 14:39 ` Alexander Mikhalitsyn
2026-06-15 19:37 ` [PATCH 07/10] x86/fpu: Pre-fault only required size of xstate buffer Andrei Vagin
2026-06-26 17:28 ` Alexander Mikhalitsyn
2026-06-15 19:37 ` [PATCH 08/10] selftests/x86: Add a sigframe insufficient xstate_size test Andrei Vagin
2026-06-26 15:02 ` Alexander Mikhalitsyn
2026-06-15 19:37 ` [PATCH 09/10] x86/fpu: Allow restoring signal frames with larger xstate_size Andrei Vagin
2026-06-26 17:32 ` Alexander Mikhalitsyn
2026-06-30 19:23 ` Chang S. Bae
2026-07-01 0:48 ` Andrei Vagin
2026-07-06 17:08 ` Chang S. Bae
2026-07-07 20:27 ` Andrei Vagin
2026-07-09 21:14 ` Chang S. Bae
2026-07-10 22:24 ` Chang S. Bae [this message]
2026-06-15 19:37 ` [PATCH 10/10] selftests/x86: Check restoring FPU state " Andrei Vagin
2026-06-26 15:12 ` Alexander Mikhalitsyn
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ecd95f49-0628-427f-9891-a22202f41ac1@intel.com \
--to=chang.seok.bae@intel.com \
--cc=avagin@google.com \
--cc=bp@alien8.de \
--cc=criu@lists.linux.dev \
--cc=dave.hansen@linux.intel.com \
--cc=hpa@zytor.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@redhat.com \
--cc=tglx@kernel.org \
--cc=x86@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome