mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Joel Fernandes <joelagnelf@nvidia.com>
To: Daniel Almeida <daniel.almeida@collabora.com>
Cc: "Boqun Feng" <boqun.feng@gmail.com>,
	"Alexandre Courbot" <acourbot@nvidia.com>,
	"Miguel Ojeda" <ojeda@kernel.org>,
	"Alex Gaynor" <alex.gaynor@gmail.com>,
	"Gary Guo" <gary@garyguo.net>,
	"Björn Roy Baron" <bjorn3_gh@protonmail.com>,
	"Benno Lossin" <benno.lossin@proton.me>,
	"Andreas Hindborg" <a.hindborg@kernel.org>,
	"Alice Ryhl" <aliceryhl@google.com>,
	"Trevor Gross" <tmgross@umich.edu>,
	"Danilo Krummrich" <dakr@kernel.org>,
	linux-kernel@vger.kernel.org, rust-for-linux@vger.kernel.org
Subject: Re: [PATCH v6] rust: kernel: add support for bits/genmask macros
Date: Fri, 20 Jun 2025 16:47:08 -0400	[thread overview]
Message-ID: <ed2aa3cf-ca2e-4abb-9c7a-7134572e4997@nvidia.com> (raw)
In-Reply-To: <D553B512-2338-4602-8EEE-B87B2BFC2FC8@collabora.com>

Hi Daniel,

On 6/20/2025 9:48 AM, Daniel Almeida wrote:
> Hi Joel,
> 
>>>>> I think generic over `RangeBounds` is a good idea, and we should
>>>>> .is_emtpy() or .contains() instead of comparison + boolean operation
>>>>> when possible. Seems we need a function to check whether one range
>> I am also of the opinion that RangeBounds is a good idea. I think it may come
>> down to both classes of devs, those who have used genmask before in C and
>> expect inclusivity, and those who are using it for the first time in Rust -
>> the latter may almost always want to use the non-inclusive syntax, no? 
>>
>> thanks,
>>
>> - Joel
> 
> Can’t do that in a const fn, and we really want a const fn as the default.
> Hence my suggestion to only support a..=b, which is both correct and explicit.

I haven't looked too deeply into the const issue, but the a..=b syntax is fine
with me.

thanks,

 - Joel


  reply	other threads:[~2025-06-20 20:47 UTC|newest]

Thread overview: 20+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-06-10 14:14 Daniel Almeida
2025-06-10 18:08 ` Miguel Ojeda
2025-06-10 20:52   ` Daniel Almeida
2025-06-14 13:38 ` Alexandre Courbot
2025-06-14 15:06   ` Boqun Feng
2025-06-14 15:56     ` Boqun Feng
2025-06-14 16:05       ` Boqun Feng
2025-06-18 20:58         ` Joel Fernandes
2025-06-20 13:48           ` Daniel Almeida
2025-06-20 20:47             ` Joel Fernandes [this message]
2025-06-15 12:59     ` Alexandre Courbot
2025-06-16 14:14   ` Daniel Almeida
2025-06-16 14:29     ` Boqun Feng
2025-06-16 14:42       ` Daniel Almeida
2025-06-16 14:45         ` Daniel Almeida
2025-06-16 14:52           ` Alexandre Courbot
2025-06-16 14:56             ` Daniel Almeida
2025-06-16 15:02               ` Alexandre Courbot
2025-06-16 15:02           ` Boqun Feng
2025-06-16 15:08     ` Alexandre Courbot

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=ed2aa3cf-ca2e-4abb-9c7a-7134572e4997@nvidia.com \
    --to=joelagnelf@nvidia.com \
    --cc=a.hindborg@kernel.org \
    --cc=acourbot@nvidia.com \
    --cc=alex.gaynor@gmail.com \
    --cc=aliceryhl@google.com \
    --cc=benno.lossin@proton.me \
    --cc=bjorn3_gh@protonmail.com \
    --cc=boqun.feng@gmail.com \
    --cc=dakr@kernel.org \
    --cc=daniel.almeida@collabora.com \
    --cc=gary@garyguo.net \
    --cc=linux-kernel@vger.kernel.org \
    --cc=ojeda@kernel.org \
    --cc=rust-for-linux@vger.kernel.org \
    --cc=tmgross@umich.edu \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®