mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: "Christian König" <christian.koenig@amd.com>
To: Leon Romanovsky <leon@kernel.org>
Cc: "Bjorn Helgaas" <bhelgaas@google.com>,
	"Logan Gunthorpe" <logang@deltatee.com>,
	"Jason Gunthorpe" <jgg@ziepe.ca>,
	"Joerg Roedel (AMD)" <joro@8bytes.org>,
	"Will Deacon" <will@kernel.org>,
	"Robin Murphy" <robin.murphy@arm.com>,
	"Thomas Hellström" <thomas.hellstrom@linux.intel.com>,
	linux-pci@vger.kernel.org, linux-kernel@vger.kernel.org,
	linux-doc@vger.kernel.org, iommu@lists.linux.dev,
	"Tushar Dave" <tdave@nvidia.com>,
	linux-media@vger.kernel.org, dri-devel@lists.freedesktop.org,
	linaro-mm-sig@lists.linaro.org, linux-rdma@vger.kernel.org,
	kvm@vger.kernel.org, "Chaitanya Kulkarni" <kch@nvidia.com>,
	"Greg Kroah-Hartman" <gregkh@linuxfoundation.org>,
	"Jens Axboe" <axboe@kernel.dk>,
	"Alex Williamson" <alex@shazbot.org>,
	"Ankit Agrawal" <ankita@nvidia.com>,
	"Jonathan Corbet" <corbet@lwn.net>,
	"Shuah Khan" <skhan@linuxfoundation.org>,
	"Randy Dunlap" <rdunlap@infradead.org>,
	"Sumit Semwal" <sumit.semwal@linaro.org>
Subject: Re: [PATCH v8 16/23] dma-buf: Let importers ask how peer-to-peer traffic is routed
Date: Wed, 30 Sep 2026 16:52:20 +0200	[thread overview]
Message-ID: <ed393791-46d5-40ad-998b-4ac0e1e9c6fa@amd.com> (raw)
In-Reply-To: <20260930143237.GI3401365@unreal>

On 9/30/26 16:32, Leon Romanovsky wrote:
> On Wed, Sep 30, 2026 at 01:52:39PM +0200, Christian König wrote:
...
>>> The importer needs a way to obtain device information from the exporter so
>>> that it can configure itself correctly.
>>
>> That won't work with DMA-buf then, the exporter is completely opaque to the importer and that is for really good reasons.
>>
>> Why in the world does the importer needs to know the information from the exporter before the mapping is created?
>>
>> It is the exporter who decides how data is accessed by the importer and not the other way around.
> 
> There are several reasons:
> 
> 1. This is how DMA-BUF MRs are built in RDMA. In mlx5, they rely on the ODP
>    mechanism, which requires an MKEY to be created first. See commit
>    90da7dc8206a (“RDMA/mlx5: Support dma-buf based userspace memory region”).

I know that patch, but I absolutely don't understand where the problem is.

> 2. P2P routing is a property of devices, not memory. It is known and remains
>    stable.

No, absolutely not. You are making completely incorrect assumptions how DMA-buf works.

Again: What is exported and from which path is up to the exporter and only determined when you create a DMA-buf mapping!

In most cases you don't even have a single device which is the DMA-buf exporter.

Only while creating the mapping the underlying access path is finally determined. It can be that P2P is used, it can be that internal connections are used, it can be that the data is moved to system memory....

That's why we have the distinction between attaching and importer and the importer creating a mapping.

> 3. See the VFIO TPH ST discussion, where the requirement to obtain the
>    exporter’s P2P information in the importer was raised again.

As far as I can see there isn't any. The TPH/ST information are just passed through from the exporter to the importer.

We could define a bit better what needs to come first the mapping or the TPH/ST query but for their use case that is actually irrelevant.

Regards,
Christian.

> 
> Thanks


  reply	other threads:[~2026-09-30 14:52 UTC|newest]

Thread overview: 40+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-09-28 11:19 [PATCH v8 00/23] PCI/P2PDMA: Route peer-to-peer DMA by TLP class Leon Romanovsky
2026-09-28 11:19 ` [PATCH v8 01/23] PCI/P2PDMA: Document the TLP attribute assumptions Leon Romanovsky
2026-09-28 11:19 ` [PATCH v8 02/23] PCI/P2PDMA: Derive routing from directional ACS controls Leon Romanovsky
2026-09-28 11:19 ` [PATCH v8 03/23] PCI: Reject unreadable ACS controls in isolation checks Leon Romanovsky
2026-09-28 11:19 ` [PATCH v8 04/23] PCI/P2PDMA: Evaluate ACS controls at the path divergence Leon Romanovsky
2026-09-28 11:19 ` [PATCH v8 05/23] PCI/P2PDMA: Document directional ACS routing Leon Romanovsky
2026-09-28 11:19 ` [PATCH v8 06/23] PCI/P2PDMA: Collect the path's ACS controls before deciding Leon Romanovsky
2026-09-28 11:19 ` [PATCH v8 07/23] PCI/P2PDMA: Answer routing per TLP class Leon Romanovsky
2026-09-28 11:19 ` [PATCH v8 08/23] PCI/P2PDMA: Route Relaxed Ordering Completions directly Leon Romanovsky
2026-09-28 11:19 ` [PATCH v8 09/23] PCI/P2PDMA: Reject Translated Requests blocked by Translation Blocking Leon Romanovsky
2026-09-28 11:19 ` [PATCH v8 10/23] PCI/P2PDMA: Route Translated Requests under Direct Translated P2P Leon Romanovsky
2026-09-28 11:19 ` [PATCH v8 11/23] PCI/P2PDMA: Log detailed ACS routing diagnostics Leon Romanovsky
2026-09-28 11:19 ` [PATCH v8 12/23] PCI/P2PDMA: Add KUnit tests for the ACS routing decisions Leon Romanovsky
2026-09-28 11:19 ` [PATCH v8 13/23] PCI/P2PDMA: Test the ACS P2P routing walk Leon Romanovsky
2026-09-28 11:19 ` [PATCH v8 14/23] PCI: Add KUnit coverage for ACS isolation checks Leon Romanovsky
2026-09-28 11:19 ` [PATCH v8 15/23] PCI/P2PDMA: Document TLP-class routing Leon Romanovsky
2026-09-28 11:19 ` [PATCH v8 16/23] dma-buf: Let importers ask how peer-to-peer traffic is routed Leon Romanovsky
2026-09-29  9:34   ` Christian König
2026-09-29 13:23     ` Leon Romanovsky
2026-09-29 13:39       ` Christian König
2026-09-29 17:57         ` Leon Romanovsky
2026-09-30  7:00           ` Christian König
2026-09-30  8:18             ` Leon Romanovsky
2026-09-30  8:34               ` Christian König
2026-09-30 11:43                 ` Leon Romanovsky
2026-09-30 11:52                   ` Christian König
2026-09-30 14:32                     ` Leon Romanovsky
2026-09-30 14:52                       ` Christian König [this message]
2026-09-30 14:57                       ` Thomas Hellström
2026-09-30 15:03                         ` Christian König
2026-09-30 16:52                         ` Jason Gunthorpe
2026-09-28 11:19 ` [PATCH v8 17/23] vfio/pci: Hand out the P2PDMA provider behind a dma-buf Leon Romanovsky
2026-09-28 11:19 ` [PATCH v8 18/23] RDMA/uverbs: " Leon Romanovsky
2026-09-28 11:19 ` [PATCH v8 19/23] RDMA/mlx5: Ask P2PDMA whether ATS takes a direct peer-to-peer route Leon Romanovsky
2026-09-28 11:19 ` [PATCH v8 20/23] PCI/P2PDMA: Let a client declare that it selects ATS per mapping Leon Romanovsky
2026-09-28 12:44   ` Thomas Hellström
2026-09-28 11:19 ` [PATCH v8 21/23] RDMA/mlx5: Declare to P2PDMA that ATS is selected per memory key Leon Romanovsky
2026-09-28 11:19 ` [PATCH v8 22/23] PCI/P2PDMA: Evaluate the ATS path for clients with ATS enabled Leon Romanovsky
2026-09-28 12:43   ` Thomas Hellström
2026-09-28 11:19 ` [PATCH v8 23/23] PCI/P2PDMA: Test the routing of " Leon Romanovsky

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=ed393791-46d5-40ad-998b-4ac0e1e9c6fa@amd.com \
    --to=christian.koenig@amd.com \
    --cc=alex@shazbot.org \
    --cc=ankita@nvidia.com \
    --cc=axboe@kernel.dk \
    --cc=bhelgaas@google.com \
    --cc=corbet@lwn.net \
    --cc=dri-devel@lists.freedesktop.org \
    --cc=gregkh@linuxfoundation.org \
    --cc=iommu@lists.linux.dev \
    --cc=jgg@ziepe.ca \
    --cc=joro@8bytes.org \
    --cc=kch@nvidia.com \
    --cc=kvm@vger.kernel.org \
    --cc=leon@kernel.org \
    --cc=linaro-mm-sig@lists.linaro.org \
    --cc=linux-doc@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-media@vger.kernel.org \
    --cc=linux-pci@vger.kernel.org \
    --cc=linux-rdma@vger.kernel.org \
    --cc=logang@deltatee.com \
    --cc=rdunlap@infradead.org \
    --cc=robin.murphy@arm.com \
    --cc=skhan@linuxfoundation.org \
    --cc=sumit.semwal@linaro.org \
    --cc=tdave@nvidia.com \
    --cc=thomas.hellstrom@linux.intel.com \
    --cc=will@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®