From: Mukesh Ojha <mojha@codeaurora.org>
To: Yue Haibing <yuehaibing@huawei.com>,
davem@davemloft.net, dougmill@linux.ibm.com
Cc: linux-kernel@vger.kernel.org, netdev@vger.kernel.org
Subject: Re: [PATCH -next] ehea: Fix a copy-paste err in ehea_init_port_res
Date: Thu, 4 Apr 2019 12:53:39 +0530 [thread overview]
Message-ID: <ed410447-3ee4-72d4-81cd-406c07a4d18c@codeaurora.org> (raw)
In-Reply-To: <20190403074759.13496-1-yuehaibing@huawei.com>
On 4/3/2019 1:17 PM, Yue Haibing wrote:
> From: YueHaibing <yuehaibing@huawei.com>
>
> pr->tx_bytes should be assigned to tx_bytes other than
> rx_bytes.
>
> Reported-by: Hulk Robot <hulkci@huawei.com>
> Fixes: ce45b873028f ("ehea: Fixing statistics")
> Signed-off-by: YueHaibing <yuehaibing@huawei.com>
Reviewed-by: Mukesh Ojha <mojha@codeaurora.org>
Cheers,
-Mukesh
> ---
> drivers/net/ethernet/ibm/ehea/ehea_main.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/net/ethernet/ibm/ehea/ehea_main.c b/drivers/net/ethernet/ibm/ehea/ehea_main.c
> index 90b62c1..707c8ba 100644
> --- a/drivers/net/ethernet/ibm/ehea/ehea_main.c
> +++ b/drivers/net/ethernet/ibm/ehea/ehea_main.c
> @@ -1463,7 +1463,7 @@ static int ehea_init_port_res(struct ehea_port *port, struct ehea_port_res *pr,
>
> memset(pr, 0, sizeof(struct ehea_port_res));
>
> - pr->tx_bytes = rx_bytes;
> + pr->tx_bytes = tx_bytes;
> pr->tx_packets = tx_packets;
> pr->rx_bytes = rx_bytes;
> pr->rx_packets = rx_packets;
next prev parent reply other threads:[~2019-04-04 7:23 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-04-03 7:47 Yue Haibing
2019-04-04 7:23 ` Mukesh Ojha [this message]
2019-04-05 0:36 ` David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ed410447-3ee4-72d4-81cd-406c07a4d18c@codeaurora.org \
--to=mojha@codeaurora.org \
--cc=davem@davemloft.net \
--cc=dougmill@linux.ibm.com \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=yuehaibing@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®