* [PATCH -next] ehea: Fix a copy-paste err in ehea_init_port_res
@ 2019-04-03 7:47 Yue Haibing
2019-04-04 7:23 ` Mukesh Ojha
2019-04-05 0:36 ` David Miller
0 siblings, 2 replies; 3+ messages in thread
From: Yue Haibing @ 2019-04-03 7:47 UTC (permalink / raw)
To: davem, dougmill; +Cc: linux-kernel, netdev, YueHaibing
From: YueHaibing <yuehaibing@huawei.com>
pr->tx_bytes should be assigned to tx_bytes other than
rx_bytes.
Reported-by: Hulk Robot <hulkci@huawei.com>
Fixes: ce45b873028f ("ehea: Fixing statistics")
Signed-off-by: YueHaibing <yuehaibing@huawei.com>
---
drivers/net/ethernet/ibm/ehea/ehea_main.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/net/ethernet/ibm/ehea/ehea_main.c b/drivers/net/ethernet/ibm/ehea/ehea_main.c
index 90b62c1..707c8ba 100644
--- a/drivers/net/ethernet/ibm/ehea/ehea_main.c
+++ b/drivers/net/ethernet/ibm/ehea/ehea_main.c
@@ -1463,7 +1463,7 @@ static int ehea_init_port_res(struct ehea_port *port, struct ehea_port_res *pr,
memset(pr, 0, sizeof(struct ehea_port_res));
- pr->tx_bytes = rx_bytes;
+ pr->tx_bytes = tx_bytes;
pr->tx_packets = tx_packets;
pr->rx_bytes = rx_bytes;
pr->rx_packets = rx_packets;
--
2.7.0
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH -next] ehea: Fix a copy-paste err in ehea_init_port_res
2019-04-03 7:47 [PATCH -next] ehea: Fix a copy-paste err in ehea_init_port_res Yue Haibing
@ 2019-04-04 7:23 ` Mukesh Ojha
2019-04-05 0:36 ` David Miller
1 sibling, 0 replies; 3+ messages in thread
From: Mukesh Ojha @ 2019-04-04 7:23 UTC (permalink / raw)
To: Yue Haibing, davem, dougmill; +Cc: linux-kernel, netdev
On 4/3/2019 1:17 PM, Yue Haibing wrote:
> From: YueHaibing <yuehaibing@huawei.com>
>
> pr->tx_bytes should be assigned to tx_bytes other than
> rx_bytes.
>
> Reported-by: Hulk Robot <hulkci@huawei.com>
> Fixes: ce45b873028f ("ehea: Fixing statistics")
> Signed-off-by: YueHaibing <yuehaibing@huawei.com>
Reviewed-by: Mukesh Ojha <mojha@codeaurora.org>
Cheers,
-Mukesh
> ---
> drivers/net/ethernet/ibm/ehea/ehea_main.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/net/ethernet/ibm/ehea/ehea_main.c b/drivers/net/ethernet/ibm/ehea/ehea_main.c
> index 90b62c1..707c8ba 100644
> --- a/drivers/net/ethernet/ibm/ehea/ehea_main.c
> +++ b/drivers/net/ethernet/ibm/ehea/ehea_main.c
> @@ -1463,7 +1463,7 @@ static int ehea_init_port_res(struct ehea_port *port, struct ehea_port_res *pr,
>
> memset(pr, 0, sizeof(struct ehea_port_res));
>
> - pr->tx_bytes = rx_bytes;
> + pr->tx_bytes = tx_bytes;
> pr->tx_packets = tx_packets;
> pr->rx_bytes = rx_bytes;
> pr->rx_packets = rx_packets;
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH -next] ehea: Fix a copy-paste err in ehea_init_port_res
2019-04-03 7:47 [PATCH -next] ehea: Fix a copy-paste err in ehea_init_port_res Yue Haibing
2019-04-04 7:23 ` Mukesh Ojha
@ 2019-04-05 0:36 ` David Miller
1 sibling, 0 replies; 3+ messages in thread
From: David Miller @ 2019-04-05 0:36 UTC (permalink / raw)
To: yuehaibing; +Cc: dougmill, linux-kernel, netdev
From: Yue Haibing <yuehaibing@huawei.com>
Date: Wed, 3 Apr 2019 15:47:59 +0800
> From: YueHaibing <yuehaibing@huawei.com>
>
> pr->tx_bytes should be assigned to tx_bytes other than
> rx_bytes.
>
> Reported-by: Hulk Robot <hulkci@huawei.com>
> Fixes: ce45b873028f ("ehea: Fixing statistics")
> Signed-off-by: YueHaibing <yuehaibing@huawei.com>
Applied.
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2019-04-05 0:36 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-04-03 7:47 [PATCH -next] ehea: Fix a copy-paste err in ehea_init_port_res Yue Haibing
2019-04-04 7:23 ` Mukesh Ojha
2019-04-05 0:36 ` David Miller
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®