From: Guenter Roeck <linux@roeck-us.net>
To: "Davíð Steinn Geirsson" <david@dsg.is>
Cc: "Jean Delvare" <jdelvare@suse.com>,
linux-hwmon@vger.kernel.org, "Rob Herring" <robh@kernel.org>,
"Krzysztof Kozlowski" <krzk+dt@kernel.org>,
"Conor Dooley" <conor+dt@kernel.org>,
devicetree@vger.kernel.org,
"Uwe Kleine-König" <ukleinek@kernel.org>,
linux-pwm@vger.kernel.org, "Jonathan Corbet" <corbet@lwn.net>,
"Shuah Khan" <skhan@linuxfoundation.org>,
"Randy Dunlap" <rdunlap@infradead.org>,
linux-doc@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 0/4] hwmon: (adt7475) Add thermal sensor and PWM provider support
Date: Sat, 14 Nov 2026 07:57:46 -0800 [thread overview]
Message-ID: <ed6fbe6f-bbdb-463d-9f20-0813c5df4aa5@roeck-us.net> (raw)
In-Reply-To: <yjB6Fbqe1FNgQm0q2QmXD6fKwCPWhZ-lnOVMD-gupg3DWK46gsVdy1CRR5PtE5ZuTjKBNyO3001YfjLfO8HzDcKy2SMiwDT3RfX2oZa_t4E=@dsg.is>
On 11/14/26 02:23, Davíð Steinn Geirsson wrote:
> On Saturday, November 14th, 2026 at 1:03 AM, Guenter Roeck <linux@roeck-us.net> wrote:
>
>> On 11/13/26 16:41, Davíð Steinn Geirsson wrote:
>>>
>>> This series lets boards use the temperature channels of the ADT7473,
>>> ADT7475, ADT7476 and ADT7490 as thermal zone sensors, and drive their
>>> PWM outputs with a PWM consumer such as pwm-fan. The kernel thermal
>>> framework can then control the fans. It follows the ADT7470 series [1],
>>> merged for v7.3.
>>>
>>
>> I am getting flooded with patches, and I have no time to review them all.
>>
>> Rule change: Functional changes for any hardware monitoring driver which
>> does not already implement it will have to include conversion to the
>> with_info hardware monitoring API.
>
> Thank you for taking the time to review, I appreciate it. I will address the items raised in the patch threads and submit a v2 once I've had time to re-validate on hardware.
>
> On the rule change, I'm not sure if this is meant for me? Patch 2/4 changes the adt7475 driver to the with_info API. I will address the locking issue you flagged in that thread, just wondering if there is a larger change being requested here.
>
No, you are doing exactly what I want people to do. Sorry, I should
have been more specific.
Thanks,
Guenter
prev parent reply other threads:[~2026-11-14 15:57 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-11-14 0:41 Davíð Steinn Geirsson
2026-11-14 0:41 ` [PATCH 1/4] dt-bindings: hwmon: adt7475: Add #thermal-sensor-cells Davíð Steinn Geirsson
2026-11-14 0:41 ` [PATCH 2/4] hwmon: (adt7475) Convert to hwmon_device_register_with_info() Davíð Steinn Geirsson
2026-11-14 6:07 ` Guenter Roeck
2026-11-14 0:41 ` [PATCH 3/4] hwmon: (adt7475) Add thermal zone sensor support Davíð Steinn Geirsson
2026-11-14 0:41 ` [PATCH 4/4] hwmon: (adt7475) Expose fan control via PWM framework Davíð Steinn Geirsson
2026-11-14 6:10 ` Guenter Roeck
2026-11-14 1:03 ` [PATCH 0/4] hwmon: (adt7475) Add thermal sensor and PWM provider support Guenter Roeck
2026-11-14 10:23 ` Davíð Steinn Geirsson
2026-11-14 15:57 ` Guenter Roeck [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ed6fbe6f-bbdb-463d-9f20-0813c5df4aa5@roeck-us.net \
--to=linux@roeck-us.net \
--cc=conor+dt@kernel.org \
--cc=corbet@lwn.net \
--cc=david@dsg.is \
--cc=devicetree@vger.kernel.org \
--cc=jdelvare@suse.com \
--cc=krzk+dt@kernel.org \
--cc=linux-doc@vger.kernel.org \
--cc=linux-hwmon@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pwm@vger.kernel.org \
--cc=rdunlap@infradead.org \
--cc=robh@kernel.org \
--cc=skhan@linuxfoundation.org \
--cc=ukleinek@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®