mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
* [PATCH] ata: pata_macio: drop driver owner assignment
@ 2024-03-27 17:49 Krzysztof Kozlowski
  2024-03-27 18:25 ` Sergey Shtylyov
                   ` (2 more replies)
  0 siblings, 3 replies; 4+ messages in thread
From: Krzysztof Kozlowski @ 2024-03-27 17:49 UTC (permalink / raw)
  To: Sergey Shtylyov, Damien Le Moal, Niklas Cassel, linux-ide, linux-kernel
  Cc: Krzysztof Kozlowski

PCI core in pci_register_driver() already sets the .owner, so driver
does not need to.

Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
---
 drivers/ata/pata_macio.c | 3 ---
 1 file changed, 3 deletions(-)

diff --git a/drivers/ata/pata_macio.c b/drivers/ata/pata_macio.c
index 4ac854f6b057..88b2e9817f49 100644
--- a/drivers/ata/pata_macio.c
+++ b/drivers/ata/pata_macio.c
@@ -1371,9 +1371,6 @@ static struct pci_driver pata_macio_pci_driver = {
 	.suspend	= pata_macio_pci_suspend,
 	.resume		= pata_macio_pci_resume,
 #endif
-	.driver = {
-		.owner		= THIS_MODULE,
-	},
 };
 MODULE_DEVICE_TABLE(pci, pata_macio_pci_match);
 
-- 
2.34.1


^ permalink raw reply	[flat|nested] 4+ messages in thread

* Re: [PATCH] ata: pata_macio: drop driver owner assignment
  2024-03-27 17:49 [PATCH] ata: pata_macio: drop driver owner assignment Krzysztof Kozlowski
@ 2024-03-27 18:25 ` Sergey Shtylyov
  2024-03-27 18:28 ` Sergey Shtylyov
  2024-03-28  0:17 ` Damien Le Moal
  2 siblings, 0 replies; 4+ messages in thread
From: Sergey Shtylyov @ 2024-03-27 18:25 UTC (permalink / raw)
  To: Krzysztof Kozlowski, Damien Le Moal, Niklas Cassel, linux-ide,
	linux-kernel

On 3/27/24 8:49 PM, Krzysztof Kozlowski wrote:

> PCI core in pci_register_driver() already sets the .owner, so driver
> does not need to.
> 
> Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>

Reviewed-by: Sergey Shtylyov <s.shtylyov@omp.ru>

[...]

MBR, Sergey

^ permalink raw reply	[flat|nested] 4+ messages in thread

* Re: [PATCH] ata: pata_macio: drop driver owner assignment
  2024-03-27 17:49 [PATCH] ata: pata_macio: drop driver owner assignment Krzysztof Kozlowski
  2024-03-27 18:25 ` Sergey Shtylyov
@ 2024-03-27 18:28 ` Sergey Shtylyov
  2024-03-28  0:17 ` Damien Le Moal
  2 siblings, 0 replies; 4+ messages in thread
From: Sergey Shtylyov @ 2024-03-27 18:28 UTC (permalink / raw)
  To: Krzysztof Kozlowski, Damien Le Moal, Niklas Cassel, linux-ide,
	linux-kernel

Well, strictly speaking, it's initializer, not assignment...

MBR, Sergey

^ permalink raw reply	[flat|nested] 4+ messages in thread

* Re: [PATCH] ata: pata_macio: drop driver owner assignment
  2024-03-27 17:49 [PATCH] ata: pata_macio: drop driver owner assignment Krzysztof Kozlowski
  2024-03-27 18:25 ` Sergey Shtylyov
  2024-03-27 18:28 ` Sergey Shtylyov
@ 2024-03-28  0:17 ` Damien Le Moal
  2 siblings, 0 replies; 4+ messages in thread
From: Damien Le Moal @ 2024-03-28  0:17 UTC (permalink / raw)
  To: Krzysztof Kozlowski, Sergey Shtylyov, Niklas Cassel, linux-ide,
	linux-kernel

On 3/28/24 02:49, Krzysztof Kozlowski wrote:
> PCI core in pci_register_driver() already sets the .owner, so driver
> does not need to.
> 
> Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>

Applied to for-6.9-fixes. Thanks !

-- 
Damien Le Moal
Western Digital Research


^ permalink raw reply	[flat|nested] 4+ messages in thread

end of thread, other threads:[~2024-03-28  0:17 UTC | newest]

Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2024-03-27 17:49 [PATCH] ata: pata_macio: drop driver owner assignment Krzysztof Kozlowski
2024-03-27 18:25 ` Sergey Shtylyov
2024-03-27 18:28 ` Sergey Shtylyov
2024-03-28  0:17 ` Damien Le Moal

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®