From: Sneh Mankad <sneh.mankad@oss.qualcomm.com>
To: Bjorn Andersson <andersson@kernel.org>
Cc: Konrad Dybcio <konradybcio@kernel.org>,
Rob Herring <robh@kernel.org>,
Krzysztof Kozlowski <krzk+dt@kernel.org>,
Conor Dooley <conor+dt@kernel.org>,
Maulik Shah <quic_mkshah@quicinc.com>,
linux-arm-msm@vger.kernel.org, devicetree@vger.kernel.org,
linux-kernel@vger.kernel.org,
Konrad Dybcio <konrad.dybcio@oss.qualcomm.com>
Subject: Re: [PATCH v3 3/3] arm64: dts: qcom: shikra: Update rpm-stats compatible to SoC specific
Date: Mon, 7 Sep 2026 19:20:07 +0530 [thread overview]
Message-ID: <ed8157d9-d8c7-4bce-a7b7-4e14015b6019@oss.qualcomm.com> (raw)
In-Reply-To: <73411be1-7b7c-4b06-ad1c-f98af338c5ae@oss.qualcomm.com>
On 07-09-2026 17:28, Sneh Mankad wrote:
>
>
> On 03-09-2026 19:36, Bjorn Andersson wrote:
>> On Mon, Jul 13, 2026 at 01:46:56PM +0530, Sneh Mankad wrote:
>>> A generic "qcom,rpm-stats" compatible only reads stats for SoC level LPM
>>> stats like vmin and vlow.
>>>
>>> Shikra SoC specific compatible allows reading individual subsystem level
>>> LPM stats along with SoC level LPM stats. Change it.
>>>
>>> Keep "qcom,rpm-stats" as fallback compatible.
>>
>> So the fallback compatible works, but the more specific compatible gives
>> you additional stats?
>>
>> If that interpretation is correct then this patch is correct.
>>
>> But then you need to fix the binding.
>
> I have already raised v4 with the option to keep fallback compatible
> in stats bindings.
Apologies, due to some other issue the send wasn't successful earlier. Have
raised v4 for this series now with the binding update.
Thanks,
Sneh
prev parent reply other threads:[~2026-09-07 13:50 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-07-13 8:16 [PATCH v3 0/3] Add subsystem LPM stats support for Shikra Sneh Mankad
2026-07-13 8:16 ` [PATCH v3 1/3] dt-bindings: soc: qcom: stats: Add compatible " Sneh Mankad
2026-07-13 8:16 ` [PATCH v3 2/3] soc: qcom: stats: Add stats compatible and config " Sneh Mankad
2026-07-13 8:16 ` [PATCH v3 3/3] arm64: dts: qcom: shikra: Update rpm-stats compatible to SoC specific Sneh Mankad
2026-07-28 6:18 ` Komal Bajaj
2026-09-03 14:06 ` Bjorn Andersson
2026-09-07 11:58 ` Sneh Mankad
2026-09-07 13:50 ` Sneh Mankad [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ed8157d9-d8c7-4bce-a7b7-4e14015b6019@oss.qualcomm.com \
--to=sneh.mankad@oss.qualcomm.com \
--cc=andersson@kernel.org \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=konrad.dybcio@oss.qualcomm.com \
--cc=konradybcio@kernel.org \
--cc=krzk+dt@kernel.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=quic_mkshah@quicinc.com \
--cc=robh@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®