From: Maxim Kochetkov <fido_max@inbox.ru>
To: Mark Brown <broonie@kernel.org>
Cc: alsa-devel@alsa-project.org,
"Liam Girdwood" <lgirdwood@gmail.com>,
"Jaroslav Kysela" <perex@perex.cz>,
"Takashi Iwai" <tiwai@suse.com>,
"Benjamin Mugnier" <benjamin.mugnier@foss.st.com>,
"Krzysztof Kozlowski" <krzysztof.kozlowski@linaro.org>,
"Greg Kroah-Hartman" <gregkh@linuxfoundation.org>,
"Uwe Kleine-König" <u.kleine-koenig@pengutronix.de>,
"Claudiu Beznea" <claudiu.beznea@microchip.com>,
"Charles Keepax" <ckeepax@opensource.cirrus.com>,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH 1/1] ASoC: codecs: max98090: Allow dsp_a mode
Date: Wed, 21 Jun 2023 16:55:18 +0300 [thread overview]
Message-ID: <ed9606a4-4be6-7403-6e32-1c045ac0bdf6@inbox.ru> (raw)
In-Reply-To: <b763d08e-f751-480c-96b6-339a53856768@sirena.org.uk>
On 21.06.2023 16:18, Mark Brown wrote:
> On Wed, Jun 21, 2023 at 04:02:34PM +0300, Maxim Kochetkov wrote:
>> On 21.06.2023 15:26, Mark Brown wrote:
>
>>> This is configuring DSP A identically to left justified mode, it looks
>>> like the format configuration needs at least some interlock with the TDM
>>> configuration.
>
>> According to datasheet MAX98090 supports only DSP_A (L data MSB after FRM
>> LRC) TDM mode. Allowing this mode will let us proper configure CPU audio
>> node via DT. Actual TDM mode activation is performed in
>> max98090_set_tdm_slot() via M98090_REG_TDM_FORMAT/M98090_REG_TDM_CONTROL
>> registers.
>
> I'm saying there should be some interlock between these two settings, if
> nothing else setting DSP A mode should force TDM mode with automatically
> configured slot sizes.
At this time there is no any interlock for TDM mode in MAX98090 driver.
We can specify dai-tdm-slot-* properties in DT and .set_tdm_slot() will
be called to setup TDM mode. And SND_SOC_DAIFMT cannot affect it. I
checked other codecs drivers: most of them performs TDM setup this way.
So why do we need such interlock right now?
next prev parent reply other threads:[~2023-06-21 13:55 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-06-21 11:53 Maxim Kochetkov
2023-06-21 12:26 ` Mark Brown
2023-06-21 13:02 ` Maxim Kochetkov
2023-06-21 13:18 ` Mark Brown
2023-06-21 13:55 ` Maxim Kochetkov [this message]
2023-06-21 14:01 ` Mark Brown
2023-06-21 14:28 ` Maxim Kochetkov
2023-06-21 14:35 ` Mark Brown
2023-06-21 19:57 ` Maxim Kochetkov
2023-06-21 20:46 ` Mark Brown
2023-06-22 6:30 ` Maxim Kochetkov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ed9606a4-4be6-7403-6e32-1c045ac0bdf6@inbox.ru \
--to=fido_max@inbox.ru \
--cc=alsa-devel@alsa-project.org \
--cc=benjamin.mugnier@foss.st.com \
--cc=broonie@kernel.org \
--cc=ckeepax@opensource.cirrus.com \
--cc=claudiu.beznea@microchip.com \
--cc=gregkh@linuxfoundation.org \
--cc=krzysztof.kozlowski@linaro.org \
--cc=lgirdwood@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=perex@perex.cz \
--cc=tiwai@suse.com \
--cc=u.kleine-koenig@pengutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®