From: Dmitry Osipenko <dmitry.osipenko@collabora.com>
To: AngeloGioacchino Del Regno
<angelogioacchino.delregno@collabora.com>,
matthias.bgg@gmail.com
Cc: linux-kernel@vger.kernel.org,
linux-arm-kernel@lists.infradead.org,
linux-mediatek@lists.infradead.org, wenst@chromium.org,
alyssa.rosenzweig@collabora.com, nfraprado@collabora.com,
digetx@gmail.com
Subject: Re: [PATCH v2] soc: mediatek: Introduce mediatek-regulator-coupler driver
Date: Tue, 28 Jun 2022 14:49:06 +0300 [thread overview]
Message-ID: <ed9e1326-b62a-bc98-027a-79121fe2914c@collabora.com> (raw)
In-Reply-To: <20220628110128.64137-1-angelogioacchino.delregno@collabora.com>
Hi Angelo,
On 6/28/22 14:01, AngeloGioacchino Del Regno wrote:
> + mrc->vsram_rdev = rdev;
> + } else if (!strstr(rdev_name, "vgpu") && !strstr(rdev_name, "Vgpu"))
> + return 1;
Nit: checkpatch --strict should warn about the missing {} here. In
general braces are always needed for each condition if they were needed
once in the if-else.
Reviewed-by: Dmitry Osipenko <dmitry.osipenko@collabora.com>
--
Best regards,
Dmitry
prev parent reply other threads:[~2022-06-28 11:49 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-06-28 11:01 AngeloGioacchino Del Regno
2022-06-28 11:49 ` Dmitry Osipenko [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ed9e1326-b62a-bc98-027a-79121fe2914c@collabora.com \
--to=dmitry.osipenko@collabora.com \
--cc=alyssa.rosenzweig@collabora.com \
--cc=angelogioacchino.delregno@collabora.com \
--cc=digetx@gmail.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mediatek@lists.infradead.org \
--cc=matthias.bgg@gmail.com \
--cc=nfraprado@collabora.com \
--cc=wenst@chromium.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®