From: Jani Nikula <jani.nikula@intel.com>
To: Lucas De Marchi <lucas.demarchi@intel.com>,
Ville Syrjala <ville.syrjala@linux.intel.com>
Cc: linux-kernel@vger.kernel.org,
Dibin Moolakadan Subrahmanian
<dibin.moolakadan.subrahmanian@intel.com>,
Imre Deak <imre.deak@intel.com>,
David Laight <david.laight.linux@gmail.com>,
Geert Uytterhoeven <geert+renesas@glider.be>,
Matt Wagantall <mattw@codeaurora.org>,
Dejin Zheng <zhengdejin5@gmail.com>,
intel-gfx@lists.freedesktop.org, intel-xe@lists.freedesktop.org
Subject: Re: [PATCH 1/4] iopoll: Generalize read_poll_timeout() into poll_timeout_us()
Date: Fri, 04 Jul 2025 11:40:20 +0300 [thread overview]
Message-ID: <edb1261d2cb3addea74d07e8be4d8eb54613ab54@intel.com> (raw)
In-Reply-To: <l2dmr55iucsg55e2qtsf46fn3huy5znd4tctzqcr7vq4durr3c@4xgp5ch3vrfl>
On Thu, 03 Jul 2025, Lucas De Marchi <lucas.demarchi@intel.com> wrote:
> On Thu, Jul 03, 2025 at 01:34:36AM +0300, Ville Syrjälä wrote:
>>-#define read_poll_timeout(op, val, cond, sleep_us, timeout_us, \
>>- sleep_before_read, args...) \
>>+#define poll_timeout_us(op, cond, sleep_us, timeout_us, sleep_before_op) \
>
> nit: could use use usec/msec etc that pairs nicely with USEC_PER_SEC
> and friends, also used by tools like perf and are a little bit more
> greppable than ms/us?
This horrendous quick and dirty git grep popularity contest says _us/_ms
suffixes are much more popular than _usec/_msec in kernel:
$ git grep -aoh "_[mu]s\(ec\)\?[^a-zA-Z0-9_]" | sed 's/[^a-zA-Z0-9_]$//' | sort | uniq -c | sort -rn
8603 _us
5901 _ms
1214 _usec
736 _msec
BR,
Jani.
--
Jani Nikula, Intel
next prev parent reply other threads:[~2025-07-04 8:40 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-07-02 22:34 Ville Syrjala
2025-07-02 22:34 ` [PATCH 2/4] iopoll: Avoid evaluating 'cond' twice in poll_timeout_us() Ville Syrjala
2025-07-03 11:55 ` Jani Nikula
2025-07-02 22:34 ` [PATCH 3/4] iopoll: Reorder the timeout handling " Ville Syrjala
2025-07-03 12:00 ` Jani Nikula
2025-07-02 22:34 ` [PATCH 4/4] DO-NOT-MERGE: drm/i915: Use poll_timeout_us() Ville Syrjala
2025-07-03 12:12 ` Jani Nikula
2025-07-03 12:50 ` Ville Syrjälä
2025-07-03 11:51 ` [PATCH 1/4] iopoll: Generalize read_poll_timeout() into poll_timeout_us() Jani Nikula
2025-07-03 14:28 ` Lucas De Marchi
2025-07-04 8:40 ` Jani Nikula [this message]
2025-07-08 13:16 ` [PATCH v2 " Ville Syrjala
2025-07-15 18:20 ` Ville Syrjälä
2025-07-31 8:51 ` Jani Nikula
2025-08-26 10:56 ` Jani Nikula
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=edb1261d2cb3addea74d07e8be4d8eb54613ab54@intel.com \
--to=jani.nikula@intel.com \
--cc=david.laight.linux@gmail.com \
--cc=dibin.moolakadan.subrahmanian@intel.com \
--cc=geert+renesas@glider.be \
--cc=imre.deak@intel.com \
--cc=intel-gfx@lists.freedesktop.org \
--cc=intel-xe@lists.freedesktop.org \
--cc=linux-kernel@vger.kernel.org \
--cc=lucas.demarchi@intel.com \
--cc=mattw@codeaurora.org \
--cc=ville.syrjala@linux.intel.com \
--cc=zhengdejin5@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®