From: Haris Iqbal <haris.iqbal@linux.dev>
To: Christoph Hellwig <hch@lst.de>, Jens Axboe <axboe@kernel.dk>
Cc: linux-block@vger.kernel.org, linux-kernel@vger.kernel.org,
Keith Busch <kbusch@kernel.org>, Jonathan Corbet <corbet@lwn.net>,
linux-doc@vger.kernel.org
Subject: Re: [v4 0/3] block: delay support for error injection
Date: Sat, 21 Nov 2026 12:27:47 +0100 [thread overview]
Message-ID: <edb8249a-7bc3-430e-bbb7-243e1881a0b8@linux.dev> (raw)
In-Reply-To: <20261120164416.GA32719@lst.de>
On 11/20/26 17:44, Christoph Hellwig wrote:
> On Wed, Nov 18, 2026 at 09:07:49AM -0700, Jens Axboe wrote:
>>
>> On Wed, 11 Nov 2026 22:58:35 +0100, Md Haris Iqbal wrote:
>>> Error injection can only fail a bio today. This adds a delay_us option so
>>> that a rule can hold a bio back first, to model a slow device. The delay
>>> happens above the driver, so it tests the code waiting above the block
>>> layer, not the blk-mq timeout handler.
>>>
>>> A delayed bio is marked with a new BIO_ERROR_INJECTED flag so the rules
>>> are not applied to it again, even after a split. Christoph asked on v2
>>> to avoid the flag by allowing a delay only together with an error. I kept
>>> delay-only rules, as a slow device that succeeds is the more useful case,
>>> so the flag question is still open.
>>>
>>> [...]
>>
>> Applied, thanks!
>>
>
> Hmm. This still has rela issues as pointed out by Sashiko. I'd very
> much expect a resend to address them.
I can resend with the fix, or send just the fix to be patched above
this, since these are already picked. Let me know whats preferable.
prev parent reply other threads:[~2026-11-21 11:27 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-11-11 21:58 Md Haris Iqbal
2026-11-11 21:58 ` [v4 1/3] block: Reject unknown status tags in error injection rules Md Haris Iqbal
2026-11-12 13:53 ` Christoph Hellwig
2026-11-11 21:58 ` [v4 2/3] block: allow error injection rules to delay bios Md Haris Iqbal
2026-11-12 13:54 ` Christoph Hellwig
2026-11-11 21:58 ` [v4 3/3] Documentation: block: document error injection delay feature Md Haris Iqbal
2026-11-12 13:54 ` Christoph Hellwig
2026-11-18 16:07 ` [v4 0/3] block: delay support for error injection Jens Axboe
2026-11-20 16:44 ` Christoph Hellwig
2026-11-21 11:27 ` Haris Iqbal [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=edb8249a-7bc3-430e-bbb7-243e1881a0b8@linux.dev \
--to=haris.iqbal@linux.dev \
--cc=axboe@kernel.dk \
--cc=corbet@lwn.net \
--cc=hch@lst.de \
--cc=kbusch@kernel.org \
--cc=linux-block@vger.kernel.org \
--cc=linux-doc@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®