* [PATCH v2] wifi: ath11k: Add missing platform IDs for quirk table
@ 2025-09-29 19:21 Mark Pearson
2025-09-30 2:17 ` Baochen Qiang
2025-10-06 16:51 ` Jeff Johnson
0 siblings, 2 replies; 7+ messages in thread
From: Mark Pearson @ 2025-09-29 19:21 UTC (permalink / raw)
To: mpearson-lenovo; +Cc: jjohnson, ath11k, linux-wireless, linux-kernel
Lenovo platforms can come with one of two different IDs.
The pm_quirk table was missing the second ID for each platform.
Add missing ID and some extra platform identification comments.
Reported on https://bugzilla.kernel.org/show_bug.cgi?id=219196
Tested-on: P14s G4 AMD.
Fixes: ce8669a27016 ("wifi: ath11k: determine PM policy based on machine model")
Signed-off-by: Mark Pearson <mpearson-lenovo@squebb.ca>
---
Changes in v2:
- Correct typo for T14s G4 AMD to use correct ID. Sorry!
- Added in Fixes and Tested-on tags correctly.
drivers/net/wireless/ath/ath11k/core.c | 54 +++++++++++++++++++++++---
1 file changed, 48 insertions(+), 6 deletions(-)
diff --git a/drivers/net/wireless/ath/ath11k/core.c b/drivers/net/wireless/ath/ath11k/core.c
index d49353b6b2e7..47522fa186a1 100644
--- a/drivers/net/wireless/ath/ath11k/core.c
+++ b/drivers/net/wireless/ath/ath11k/core.c
@@ -912,42 +912,84 @@ static const struct ath11k_hw_params ath11k_hw_params[] = {
static const struct dmi_system_id ath11k_pm_quirk_table[] = {
{
.driver_data = (void *)ATH11K_PM_WOW,
- .matches = {
+ .matches = { /* X13 G4 AMD #1 */
+ DMI_MATCH(DMI_BOARD_VENDOR, "LENOVO"),
+ DMI_MATCH(DMI_PRODUCT_NAME, "21J3"),
+ },
+ },
+ {
+ .driver_data = (void *)ATH11K_PM_WOW,
+ .matches = { /* X13 G4 AMD #2 */
DMI_MATCH(DMI_BOARD_VENDOR, "LENOVO"),
DMI_MATCH(DMI_PRODUCT_NAME, "21J4"),
},
},
{
.driver_data = (void *)ATH11K_PM_WOW,
- .matches = {
+ .matches = { /* T14 G4 AMD #1 */
+ DMI_MATCH(DMI_BOARD_VENDOR, "LENOVO"),
+ DMI_MATCH(DMI_PRODUCT_NAME, "21K3"),
+ },
+ },
+ {
+ .driver_data = (void *)ATH11K_PM_WOW,
+ .matches = { /* T14 G4 AMD #2 */
DMI_MATCH(DMI_BOARD_VENDOR, "LENOVO"),
DMI_MATCH(DMI_PRODUCT_NAME, "21K4"),
},
},
{
.driver_data = (void *)ATH11K_PM_WOW,
- .matches = {
+ .matches = { /* P14s G4 AMD #1 */
+ DMI_MATCH(DMI_BOARD_VENDOR, "LENOVO"),
+ DMI_MATCH(DMI_PRODUCT_NAME, "21K5"),
+ },
+ },
+ {
+ .driver_data = (void *)ATH11K_PM_WOW,
+ .matches = { /* P14s G4 AMD #2 */
DMI_MATCH(DMI_BOARD_VENDOR, "LENOVO"),
DMI_MATCH(DMI_PRODUCT_NAME, "21K6"),
},
},
{
.driver_data = (void *)ATH11K_PM_WOW,
- .matches = {
+ .matches = { /* T16 G2 AMD #1 */
+ DMI_MATCH(DMI_BOARD_VENDOR, "LENOVO"),
+ DMI_MATCH(DMI_PRODUCT_NAME, "21K7"),
+ },
+ },
+ {
+ .driver_data = (void *)ATH11K_PM_WOW,
+ .matches = { /* T16 G2 AMD #2 */
DMI_MATCH(DMI_BOARD_VENDOR, "LENOVO"),
DMI_MATCH(DMI_PRODUCT_NAME, "21K8"),
},
},
{
.driver_data = (void *)ATH11K_PM_WOW,
- .matches = {
+ .matches = { /*P16s G2 AMD #1 */
+ DMI_MATCH(DMI_BOARD_VENDOR, "LENOVO"),
+ DMI_MATCH(DMI_PRODUCT_NAME, "21K9"),
+ },
+ },
+ {
+ .driver_data = (void *)ATH11K_PM_WOW,
+ .matches = { /*P16s G2 AMD #2 */
DMI_MATCH(DMI_BOARD_VENDOR, "LENOVO"),
DMI_MATCH(DMI_PRODUCT_NAME, "21KA"),
},
},
{
.driver_data = (void *)ATH11K_PM_WOW,
- .matches = {
+ .matches = { /*T14s G4 AMD #1 */
+ DMI_MATCH(DMI_BOARD_VENDOR, "LENOVO"),
+ DMI_MATCH(DMI_PRODUCT_NAME, "21F8"),
+ },
+ },
+ {
+ .driver_data = (void *)ATH11K_PM_WOW,
+ .matches = { /*T14s G4 AMD #2 */
DMI_MATCH(DMI_BOARD_VENDOR, "LENOVO"),
DMI_MATCH(DMI_PRODUCT_NAME, "21F9"),
},
--
2.43.0
^ permalink raw reply [flat|nested] 7+ messages in thread* Re: [PATCH v2] wifi: ath11k: Add missing platform IDs for quirk table
2025-09-29 19:21 [PATCH v2] wifi: ath11k: Add missing platform IDs for quirk table Mark Pearson
@ 2025-09-30 2:17 ` Baochen Qiang
2025-09-30 12:05 ` Mark Pearson
2025-10-02 0:11 ` Jeff Johnson
2025-10-06 16:51 ` Jeff Johnson
1 sibling, 2 replies; 7+ messages in thread
From: Baochen Qiang @ 2025-09-30 2:17 UTC (permalink / raw)
To: Mark Pearson; +Cc: jjohnson, ath11k, linux-wireless, linux-kernel
On 9/30/2025 3:21 AM, Mark Pearson wrote:
> Lenovo platforms can come with one of two different IDs.
> The pm_quirk table was missing the second ID for each platform.
>
> Add missing ID and some extra platform identification comments.
> Reported on https://bugzilla.kernel.org/show_bug.cgi?id=219196
>
> Tested-on: P14s G4 AMD.
Leave a blank line as 'Tested-on:' is not an official tag
> Fixes: ce8669a27016 ("wifi: ath11k: determine PM policy based on machine model")
Better to move the bugzilla link here and reword as below?
Closes: https://bugzilla.kernel.org/show_bug.cgi?id=219196
> Signed-off-by: Mark Pearson <mpearson-lenovo@squebb.ca>
> ---
> Changes in v2:
> - Correct typo for T14s G4 AMD to use correct ID. Sorry!
> - Added in Fixes and Tested-on tags correctly.
>
> drivers/net/wireless/ath/ath11k/core.c | 54 +++++++++++++++++++++++---
> 1 file changed, 48 insertions(+), 6 deletions(-)
>
> diff --git a/drivers/net/wireless/ath/ath11k/core.c b/drivers/net/wireless/ath/ath11k/core.c
> index d49353b6b2e7..47522fa186a1 100644
> --- a/drivers/net/wireless/ath/ath11k/core.c
> +++ b/drivers/net/wireless/ath/ath11k/core.c
> @@ -912,42 +912,84 @@ static const struct ath11k_hw_params ath11k_hw_params[] = {
> static const struct dmi_system_id ath11k_pm_quirk_table[] = {
> {
> .driver_data = (void *)ATH11K_PM_WOW,
> - .matches = {
> + .matches = { /* X13 G4 AMD #1 */
> + DMI_MATCH(DMI_BOARD_VENDOR, "LENOVO"),
> + DMI_MATCH(DMI_PRODUCT_NAME, "21J3"),
> + },
> + },
> + {
> + .driver_data = (void *)ATH11K_PM_WOW,
> + .matches = { /* X13 G4 AMD #2 */
> DMI_MATCH(DMI_BOARD_VENDOR, "LENOVO"),
> DMI_MATCH(DMI_PRODUCT_NAME, "21J4"),
> },
> },
> {
> .driver_data = (void *)ATH11K_PM_WOW,
> - .matches = {
> + .matches = { /* T14 G4 AMD #1 */
> + DMI_MATCH(DMI_BOARD_VENDOR, "LENOVO"),
> + DMI_MATCH(DMI_PRODUCT_NAME, "21K3"),
> + },
> + },
> + {
> + .driver_data = (void *)ATH11K_PM_WOW,
> + .matches = { /* T14 G4 AMD #2 */
> DMI_MATCH(DMI_BOARD_VENDOR, "LENOVO"),
> DMI_MATCH(DMI_PRODUCT_NAME, "21K4"),
> },
> },
> {
> .driver_data = (void *)ATH11K_PM_WOW,
> - .matches = {
> + .matches = { /* P14s G4 AMD #1 */
> + DMI_MATCH(DMI_BOARD_VENDOR, "LENOVO"),
> + DMI_MATCH(DMI_PRODUCT_NAME, "21K5"),
> + },
> + },
> + {
> + .driver_data = (void *)ATH11K_PM_WOW,
> + .matches = { /* P14s G4 AMD #2 */
> DMI_MATCH(DMI_BOARD_VENDOR, "LENOVO"),
> DMI_MATCH(DMI_PRODUCT_NAME, "21K6"),
> },
> },
> {
> .driver_data = (void *)ATH11K_PM_WOW,
> - .matches = {
> + .matches = { /* T16 G2 AMD #1 */
> + DMI_MATCH(DMI_BOARD_VENDOR, "LENOVO"),
> + DMI_MATCH(DMI_PRODUCT_NAME, "21K7"),
> + },
> + },
> + {
> + .driver_data = (void *)ATH11K_PM_WOW,
> + .matches = { /* T16 G2 AMD #2 */
> DMI_MATCH(DMI_BOARD_VENDOR, "LENOVO"),
> DMI_MATCH(DMI_PRODUCT_NAME, "21K8"),
> },
> },
> {
> .driver_data = (void *)ATH11K_PM_WOW,
> - .matches = {
> + .matches = { /*P16s G2 AMD #1 */
> + DMI_MATCH(DMI_BOARD_VENDOR, "LENOVO"),
> + DMI_MATCH(DMI_PRODUCT_NAME, "21K9"),
> + },
> + },
> + {
> + .driver_data = (void *)ATH11K_PM_WOW,
> + .matches = { /*P16s G2 AMD #2 */
> DMI_MATCH(DMI_BOARD_VENDOR, "LENOVO"),
> DMI_MATCH(DMI_PRODUCT_NAME, "21KA"),
> },
> },
> {
> .driver_data = (void *)ATH11K_PM_WOW,
> - .matches = {
> + .matches = { /*T14s G4 AMD #1 */
> + DMI_MATCH(DMI_BOARD_VENDOR, "LENOVO"),
> + DMI_MATCH(DMI_PRODUCT_NAME, "21F8"),
> + },
> + },
> + {
> + .driver_data = (void *)ATH11K_PM_WOW,
> + .matches = { /*T14s G4 AMD #2 */
> DMI_MATCH(DMI_BOARD_VENDOR, "LENOVO"),
> DMI_MATCH(DMI_PRODUCT_NAME, "21F9"),
> },
assuming Jeff can resolve above nits ...
Reviewed-by: Baochen Qiang <baochen.qiang@oss.qualcomm.com>
^ permalink raw reply [flat|nested] 7+ messages in thread* Re: [PATCH v2] wifi: ath11k: Add missing platform IDs for quirk table
2025-09-30 2:17 ` Baochen Qiang
@ 2025-09-30 12:05 ` Mark Pearson
2025-09-30 14:48 ` Jeff Johnson
2025-10-02 0:11 ` Jeff Johnson
1 sibling, 1 reply; 7+ messages in thread
From: Mark Pearson @ 2025-09-30 12:05 UTC (permalink / raw)
To: Baochen Qiang; +Cc: jjohnson, ath11k, linux-wireless, linux-kernel
On Mon, Sep 29, 2025, at 10:17 PM, Baochen Qiang wrote:
> On 9/30/2025 3:21 AM, Mark Pearson wrote:
>> Lenovo platforms can come with one of two different IDs.
>> The pm_quirk table was missing the second ID for each platform.
>>
>> Add missing ID and some extra platform identification comments.
>> Reported on https://bugzilla.kernel.org/show_bug.cgi?id=219196
>>
>> Tested-on: P14s G4 AMD.
>
> Leave a blank line as 'Tested-on:' is not an official tag
>
>> Fixes: ce8669a27016 ("wifi: ath11k: determine PM policy based on machine model")
>
> Better to move the bugzilla link here and reword as below?
>
> Closes: https://bugzilla.kernel.org/show_bug.cgi?id=219196
>
>> Signed-off-by: Mark Pearson <mpearson-lenovo@squebb.ca>
>> ---
>> Changes in v2:
>> - Correct typo for T14s G4 AMD to use correct ID. Sorry!
>> - Added in Fixes and Tested-on tags correctly.
>>
>> drivers/net/wireless/ath/ath11k/core.c | 54 +++++++++++++++++++++++---
>> 1 file changed, 48 insertions(+), 6 deletions(-)
>>
>> diff --git a/drivers/net/wireless/ath/ath11k/core.c b/drivers/net/wireless/ath/ath11k/core.c
>> index d49353b6b2e7..47522fa186a1 100644
>> --- a/drivers/net/wireless/ath/ath11k/core.c
>> +++ b/drivers/net/wireless/ath/ath11k/core.c
>> @@ -912,42 +912,84 @@ static const struct ath11k_hw_params ath11k_hw_params[] = {
>> static const struct dmi_system_id ath11k_pm_quirk_table[] = {
>> {
>> .driver_data = (void *)ATH11K_PM_WOW,
>> - .matches = {
>> + .matches = { /* X13 G4 AMD #1 */
>> + DMI_MATCH(DMI_BOARD_VENDOR, "LENOVO"),
>> + DMI_MATCH(DMI_PRODUCT_NAME, "21J3"),
>> + },
>> + },
>> + {
>> + .driver_data = (void *)ATH11K_PM_WOW,
>> + .matches = { /* X13 G4 AMD #2 */
>> DMI_MATCH(DMI_BOARD_VENDOR, "LENOVO"),
>> DMI_MATCH(DMI_PRODUCT_NAME, "21J4"),
>> },
>> },
>> {
>> .driver_data = (void *)ATH11K_PM_WOW,
>> - .matches = {
>> + .matches = { /* T14 G4 AMD #1 */
>> + DMI_MATCH(DMI_BOARD_VENDOR, "LENOVO"),
>> + DMI_MATCH(DMI_PRODUCT_NAME, "21K3"),
>> + },
>> + },
>> + {
>> + .driver_data = (void *)ATH11K_PM_WOW,
>> + .matches = { /* T14 G4 AMD #2 */
>> DMI_MATCH(DMI_BOARD_VENDOR, "LENOVO"),
>> DMI_MATCH(DMI_PRODUCT_NAME, "21K4"),
>> },
>> },
>> {
>> .driver_data = (void *)ATH11K_PM_WOW,
>> - .matches = {
>> + .matches = { /* P14s G4 AMD #1 */
>> + DMI_MATCH(DMI_BOARD_VENDOR, "LENOVO"),
>> + DMI_MATCH(DMI_PRODUCT_NAME, "21K5"),
>> + },
>> + },
>> + {
>> + .driver_data = (void *)ATH11K_PM_WOW,
>> + .matches = { /* P14s G4 AMD #2 */
>> DMI_MATCH(DMI_BOARD_VENDOR, "LENOVO"),
>> DMI_MATCH(DMI_PRODUCT_NAME, "21K6"),
>> },
>> },
>> {
>> .driver_data = (void *)ATH11K_PM_WOW,
>> - .matches = {
>> + .matches = { /* T16 G2 AMD #1 */
>> + DMI_MATCH(DMI_BOARD_VENDOR, "LENOVO"),
>> + DMI_MATCH(DMI_PRODUCT_NAME, "21K7"),
>> + },
>> + },
>> + {
>> + .driver_data = (void *)ATH11K_PM_WOW,
>> + .matches = { /* T16 G2 AMD #2 */
>> DMI_MATCH(DMI_BOARD_VENDOR, "LENOVO"),
>> DMI_MATCH(DMI_PRODUCT_NAME, "21K8"),
>> },
>> },
>> {
>> .driver_data = (void *)ATH11K_PM_WOW,
>> - .matches = {
>> + .matches = { /*P16s G2 AMD #1 */
>> + DMI_MATCH(DMI_BOARD_VENDOR, "LENOVO"),
>> + DMI_MATCH(DMI_PRODUCT_NAME, "21K9"),
>> + },
>> + },
>> + {
>> + .driver_data = (void *)ATH11K_PM_WOW,
>> + .matches = { /*P16s G2 AMD #2 */
>> DMI_MATCH(DMI_BOARD_VENDOR, "LENOVO"),
>> DMI_MATCH(DMI_PRODUCT_NAME, "21KA"),
>> },
>> },
>> {
>> .driver_data = (void *)ATH11K_PM_WOW,
>> - .matches = {
>> + .matches = { /*T14s G4 AMD #1 */
>> + DMI_MATCH(DMI_BOARD_VENDOR, "LENOVO"),
>> + DMI_MATCH(DMI_PRODUCT_NAME, "21F8"),
>> + },
>> + },
>> + {
>> + .driver_data = (void *)ATH11K_PM_WOW,
>> + .matches = { /*T14s G4 AMD #2 */
>> DMI_MATCH(DMI_BOARD_VENDOR, "LENOVO"),
>> DMI_MATCH(DMI_PRODUCT_NAME, "21F9"),
>> },
>
> assuming Jeff can resolve above nits ...
>
> Reviewed-by: Baochen Qiang <baochen.qiang@oss.qualcomm.com>
Thanks for the review.
Jeff, let me know if you need a v3 with the small changes.
Mark
^ permalink raw reply [flat|nested] 7+ messages in thread* Re: [PATCH v2] wifi: ath11k: Add missing platform IDs for quirk table
2025-09-30 12:05 ` Mark Pearson
@ 2025-09-30 14:48 ` Jeff Johnson
0 siblings, 0 replies; 7+ messages in thread
From: Jeff Johnson @ 2025-09-30 14:48 UTC (permalink / raw)
To: Mark Pearson, Baochen Qiang
Cc: jjohnson, ath11k, linux-wireless, linux-kernel
On 9/30/2025 5:05 AM, Mark Pearson wrote:
> On Mon, Sep 29, 2025, at 10:17 PM, Baochen Qiang wrote:
>> On 9/30/2025 3:21 AM, Mark Pearson wrote:
...>> assuming Jeff can resolve above nits ...
>>
>> Reviewed-by: Baochen Qiang <baochen.qiang@oss.qualcomm.com>
>
> Thanks for the review.
> Jeff, let me know if you need a v3 with the small changes.
I can address those in 'pending'
/jeff
^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [PATCH v2] wifi: ath11k: Add missing platform IDs for quirk table
2025-09-30 2:17 ` Baochen Qiang
2025-09-30 12:05 ` Mark Pearson
@ 2025-10-02 0:11 ` Jeff Johnson
2025-10-02 0:37 ` Mark Pearson
1 sibling, 1 reply; 7+ messages in thread
From: Jeff Johnson @ 2025-10-02 0:11 UTC (permalink / raw)
To: Baochen Qiang, Mark Pearson
Cc: jjohnson, ath11k, linux-wireless, linux-kernel
On 9/29/2025 7:17 PM, Baochen Qiang wrote:
> On 9/30/2025 3:21 AM, Mark Pearson wrote:
...>> + .matches = { /*P16s G2 AMD #1 */
...>> + .matches = { /*P16s G2 AMD #2 */
...>> + .matches = { /*T14s G4 AMD #1 */
...>> + .matches = { /*T14s G4 AMD #2 */
In addition to Baochen's comments, in my pending branch I've also fixed these
4 instances of missing space after /*
https://git.kernel.org/pub/scm/linux/kernel/git/ath/ath.git/commit/?h=pending&id=79208b9ac68a7e71ad7e60cc37038c35b2b4252f
^ permalink raw reply [flat|nested] 7+ messages in thread* Re: [PATCH v2] wifi: ath11k: Add missing platform IDs for quirk table
2025-10-02 0:11 ` Jeff Johnson
@ 2025-10-02 0:37 ` Mark Pearson
0 siblings, 0 replies; 7+ messages in thread
From: Mark Pearson @ 2025-10-02 0:37 UTC (permalink / raw)
To: Jeff Johnson, Baochen Qiang
Cc: jjohnson, ath11k, linux-wireless, linux-kernel
On Wed, Oct 1, 2025, at 8:11 PM, Jeff Johnson wrote:
> On 9/29/2025 7:17 PM, Baochen Qiang wrote:
>> On 9/30/2025 3:21 AM, Mark Pearson wrote:
> ...>> + .matches = { /*P16s G2 AMD #1 */
> ...>> + .matches = { /*P16s G2 AMD #2 */
> ...>> + .matches = { /*T14s G4 AMD #1 */
> ...>> + .matches = { /*T14s G4 AMD #2 */
>
> In addition to Baochen's comments, in my pending branch I've also fixed these
> 4 instances of missing space after /*
>
> https://git.kernel.org/pub/scm/linux/kernel/git/ath/ath.git/commit/?h=pending&id=79208b9ac68a7e71ad7e60cc37038c35b2b4252f
Thanks Jeff
Mark
^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [PATCH v2] wifi: ath11k: Add missing platform IDs for quirk table
2025-09-29 19:21 [PATCH v2] wifi: ath11k: Add missing platform IDs for quirk table Mark Pearson
2025-09-30 2:17 ` Baochen Qiang
@ 2025-10-06 16:51 ` Jeff Johnson
1 sibling, 0 replies; 7+ messages in thread
From: Jeff Johnson @ 2025-10-06 16:51 UTC (permalink / raw)
To: Mark Pearson; +Cc: jjohnson, ath11k, linux-wireless, linux-kernel
On Mon, 29 Sep 2025 15:21:35 -0400, Mark Pearson wrote:
> Lenovo platforms can come with one of two different IDs.
> The pm_quirk table was missing the second ID for each platform.
>
> Add missing ID and some extra platform identification comments.
> Reported on https://bugzilla.kernel.org/show_bug.cgi?id=219196
>
>
> [...]
Applied, thanks!
[1/1] wifi: ath11k: Add missing platform IDs for quirk table
commit: 0eb002c93c3b47f88244cecb1e356eaeab61a6bf
Best regards,
--
Jeff Johnson <jeff.johnson@oss.qualcomm.com>
^ permalink raw reply [flat|nested] 7+ messages in thread
end of thread, other threads:[~2025-10-06 16:51 UTC | newest]
Thread overview: 7+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2025-09-29 19:21 [PATCH v2] wifi: ath11k: Add missing platform IDs for quirk table Mark Pearson
2025-09-30 2:17 ` Baochen Qiang
2025-09-30 12:05 ` Mark Pearson
2025-09-30 14:48 ` Jeff Johnson
2025-10-02 0:11 ` Jeff Johnson
2025-10-02 0:37 ` Mark Pearson
2025-10-06 16:51 ` Jeff Johnson
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®