mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Mario Limonciello <mario.limonciello@amd.com>
To: Yazen Ghannam <yazen.ghannam@amd.com>, x86@kernel.org
Cc: linux-kernel@vger.kernel.org,
	platform-driver-x86@vger.kernel.org, markgross@kernel.org,
	hdegoede@redhat.com, Shyam-sundar.S-k@amd.com,
	linux-edac@vger.kernel.org, clemens@ladisch.de,
	jdelvare@suse.com, linux@roeck-us.net,
	linux-hwmon@vger.kernel.org, babu.moger@amd.com
Subject: Re: [PATCH v2 0/6] Enhance AMD SMN Error Checking
Date: Sun, 18 Jun 2023 21:42:18 -0500	[thread overview]
Message-ID: <eddd118b-a10b-7208-7e96-df909d038233@amd.com> (raw)
In-Reply-To: <20230615160328.419610-1-yazen.ghannam@amd.com>

On 6/15/23 11:03, Yazen Ghannam wrote:
> Hi all,
> 
> This set implements more robust error checking for AMD System Management
> Network (SMN) accesses.
> 
> This set is a follow up to this discussion:
> https://lore.kernel.org/lkml/20230403164244.471141-1-yazen.ghannam@amd.com/
> 
> Patches 1-3:
> 	- Pre-patches in AMD64 EDAC and K10Temp modules.
> 	- Required in order to avoid build warnings with the
> 	  introduction of the __must_check attribute in patch 4.
> Patch 4:
> 	- Introduces __must_check attribute for SMN access functions.
> 	- Handles "PCI Error Response" behavior for SMN reads.
> Patches 5-6:
> 	- Optional cleanup patches in k10temp.
> 	- Not required for the SMN access issue, but I thought they may
> 	  be good to do.
> 

Each of the patches in the series looks good to me.
Reviewed-by: Mario Limonciello <mario.limonciello@amd.com>

> I've included x86 platform driver folks for awareness, since there are
> some AMD SMN users there.

These uses seem to be handled fine by the existing error checking to me.
There is also a consumer of amd_smn_read/amd_smn_write in 
arch/x86/pci/fixup.c that I think looks fine still.

> 
> Thanks,
> Yazen
> 
> Link:
> https://lore.kernel.org/r/20230516202430.4157216-1-yazen.ghannam@amd.com
> 
> v1->v2:
> * Rebase on tip/master.
> * Address comments from Guenter.
> 
> Yazen Ghannam (6):
>    EDAC/amd64: Remove unused register accesses
>    EDAC/amd64: Check return value of amd_smn_read()
>    hwmon: (k10temp) Check return value of amd_smn_read()
>    x86/amd_nb: Enhance SMN access error checking
>    hwmon: (k10temp) Define helper function to read CCD temp
>    hwmon: (k10temp) Reduce k10temp_get_ccd_support() parameters
> 
>   arch/x86/include/asm/amd_nb.h |  4 +--
>   arch/x86/kernel/amd_nb.c      | 46 ++++++++++++++++++++----
>   drivers/edac/amd64_edac.c     | 68 +++++++++++++++++++----------------
>   drivers/edac/amd64_edac.h     |  4 ---
>   drivers/hwmon/k10temp.c       | 57 +++++++++++++++++++----------
>   5 files changed, 119 insertions(+), 60 deletions(-)
> 


      parent reply	other threads:[~2023-06-19  2:43 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-06-15 16:03 Yazen Ghannam
2023-06-15 16:03 ` [PATCH v2 1/6] EDAC/amd64: Remove unused register accesses Yazen Ghannam
2023-06-15 16:03 ` [PATCH v2 2/6] EDAC/amd64: Check return value of amd_smn_read() Yazen Ghannam
2023-06-15 16:03 ` [PATCH v2 3/6] hwmon: (k10temp) " Yazen Ghannam
2023-06-16  2:21   ` Guenter Roeck
2023-06-15 16:03 ` [PATCH v2 4/6] x86/amd_nb: Enhance SMN access error checking Yazen Ghannam
2023-06-15 16:03 ` [PATCH v2 5/6] hwmon: (k10temp) Define helper function to read CCD temp Yazen Ghannam
2023-06-16  2:22   ` Guenter Roeck
2023-06-15 16:03 ` [PATCH v2 6/6] hwmon: (k10temp) Reduce k10temp_get_ccd_support() parameters Yazen Ghannam
2023-06-19  2:42 ` Mario Limonciello [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=eddd118b-a10b-7208-7e96-df909d038233@amd.com \
    --to=mario.limonciello@amd.com \
    --cc=Shyam-sundar.S-k@amd.com \
    --cc=babu.moger@amd.com \
    --cc=clemens@ladisch.de \
    --cc=hdegoede@redhat.com \
    --cc=jdelvare@suse.com \
    --cc=linux-edac@vger.kernel.org \
    --cc=linux-hwmon@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux@roeck-us.net \
    --cc=markgross@kernel.org \
    --cc=platform-driver-x86@vger.kernel.org \
    --cc=x86@kernel.org \
    --cc=yazen.ghannam@amd.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®