From: AngeloGioacchino Del Regno <angelogioacchino.delregno@collabora.com>
To: Zhongjun Tan <hbut_tan@163.com>,
lgirdwood@gmail.com, broonie@kernel.org, perex@perex.c,
tiwai@suse.com, matthias.bgg@gmail.com, jiaxin.yu@mediatek.com,
tanzhongjun@coolpad.com, colin.king@intel.com
Cc: alsa-devel@alsa-project.org,
linux-arm-kernel@lists.infradead.org,
linux-mediatek@lists.infradead.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] ASoC: mediatek: mt8186: Remove condition with no effect
Date: Fri, 8 Jul 2022 10:01:20 +0200 [thread overview]
Message-ID: <ee0d9788-b742-21bb-9cc5-7b729897408b@collabora.com> (raw)
In-Reply-To: <20220708024651.42999-1-hbut_tan@163.com>
Il 08/07/22 04:46, Zhongjun Tan ha scritto:
> From: Zhongjun Tan <tanzhongjun@coolpad.com>
>
> Remove condition with no effect
>
> Signed-off-by: Zhongjun Tan <tanzhongjun@coolpad.com>
> ---
> sound/soc/mediatek/mt8186/mt8186-dai-adda.c | 2 --
> 1 file changed, 2 deletions(-)
>
> diff --git a/sound/soc/mediatek/mt8186/mt8186-dai-adda.c b/sound/soc/mediatek/mt8186/mt8186-dai-adda.c
> index db71b032770d..6be6d4f3b585 100644
> --- a/sound/soc/mediatek/mt8186/mt8186-dai-adda.c
> +++ b/sound/soc/mediatek/mt8186/mt8186-dai-adda.c
> @@ -295,8 +295,6 @@ static int mtk_adda_pad_top_event(struct snd_soc_dapm_widget *w,
> case SND_SOC_DAPM_PRE_PMU:
> if (afe_priv->mtkaif_protocol == MTKAIF_PROTOCOL_2_CLK_P2)
> regmap_write(afe->regmap, AFE_AUD_PAD_TOP, 0x39);
> - else if (afe_priv->mtkaif_protocol == MTKAIF_PROTOCOL_2)
> - regmap_write(afe->regmap, AFE_AUD_PAD_TOP, 0x31);
I think that this needs some clarification from MediaTek: was 0x31 a typo here?
Regards,
Angelo
> else
> regmap_write(afe->regmap, AFE_AUD_PAD_TOP, 0x31);
> break;
next prev parent reply other threads:[~2022-07-08 8:01 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-07-08 2:46 Zhongjun Tan
2022-07-08 8:01 ` AngeloGioacchino Del Regno [this message]
2022-07-08 8:11 ` Matthias Brugger
2022-07-08 10:19 ` Jiaxin Yu
2022-07-08 15:44 ` AngeloGioacchino Del Regno
2022-07-11 13:42 ` Mark Brown
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ee0d9788-b742-21bb-9cc5-7b729897408b@collabora.com \
--to=angelogioacchino.delregno@collabora.com \
--cc=alsa-devel@alsa-project.org \
--cc=broonie@kernel.org \
--cc=colin.king@intel.com \
--cc=hbut_tan@163.com \
--cc=jiaxin.yu@mediatek.com \
--cc=lgirdwood@gmail.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mediatek@lists.infradead.org \
--cc=matthias.bgg@gmail.com \
--cc=perex@perex.c \
--cc=tanzhongjun@coolpad.com \
--cc=tiwai@suse.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®