Re: [PATCH v2 0/2] ASoC: codecs: lpass-{tx,wsa}-macro: fix enum kcontrol accesses

[Srinivas Kandagatla <srinivas.kandagatla@oss.qualcomm.com>]

On 7/30/26 11:58 AM, Dawid Wróbel via B4 Relay wrote:
> Both drivers access enumerated controls through value.integer.value[0]
> instead of value.enumerated.item[0]. The same bug was fixed in rx-macro
> and va-macro in 2022 (bcfe5f76cc40, 0ea5eff7c606); tx-macro and
> wsa-macro were missed.
> 
> On 64-bit kernels with CONFIG_SND_CTL_DEBUG this trips the elem value
> sanity check, and every read of the affected controls fails with
> -EINVAL.
> 
> Reproduced and fixed on a Xiaomi Mi Pad 5 Pro (SM8250) for tx-macro.
> wsa-macro is compile-tested only — that codec is not instantiated on
> this hardware.
> 
> Signed-off-by: Dawid Wróbel <me@dawidwrobel.com>
> ---

LGTM,

Reviewed-by: Srinivas Kandagatla <srinivas.kandagatla@oss.qualcomm.com>

--srini
> Changes in v2:
> - wsa-macro: also fix wsa_macro_rx_mux_get() and wsa_macro_rx_mux_put(),
>   which have the same bug (Srinivas Kandagatla)
> - Cc stable on both patches (Srinivas Kandagatla)
> - Link to v1: https://lore.kernel.org/r/20260729-worktree-lpass-tx-macro-enum-fix-v1-0-0cf02c681332@dawidwrobel.com
> 
> ---
> Dawid Wróbel (2):
>       ASoC: codecs: lpass-tx-macro: Fix enum kcontrol accesses
>       ASoC: codecs: lpass-wsa-macro: Fix enum kcontrol accesses
> 
>  sound/soc/codecs/lpass-tx-macro.c  | 4 ++--
>  sound/soc/codecs/lpass-wsa-macro.c | 8 ++++----
>  2 files changed, 6 insertions(+), 6 deletions(-)
> ---
> base-commit: 57b8e2d666a31fa201432d58f5fe3469a0dd83ba
> change-id: 20260729-worktree-lpass-tx-macro-enum-fix-c5fbafef75b6
> 
> Best regards,