From: "Dragan Simic" <dsimic@manjaro.org>
To: "Geraldo Nascimento" <geraldogabriel@gmail.com>
Cc: "Shawn Lin" <shawn.lin@rock-chips.com>,
linux-rockchip@lists.infradead.org,
"Lorenzo Pieralisi" <lpieralisi@kernel.org>,
"Krzysztof Wilczyński" <kwilczynski@kernel.org>,
"Manivannan Sadhasivam" <mani@kernel.org>,
"Rob Herring" <robh@kernel.org>,
"Bjorn Helgaas" <bhelgaas@google.com>,
linux-pci@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH v7 1/3] PCI: rockchip-ep: do not attempt 5.0 GT/s retraining
Date: Tue, 16 Jun 2026 21:06:53 +0200 [thread overview]
Message-ID: <ee80e2c7-8327-0000-5986-e909f0a41df1@manjaro.org> (raw)
In-Reply-To: <d994f8fb3481bbb8f3972f117334a6e8aea383fb.1781622998.git.geraldogabriel@gmail.com>
Hello Geraldo,
Thanks for the v6 and v7 of this series.
On Tuesday, June 16, 2026 17:25 CEST, Geraldo Nascimento <geraldogabriel@gmail.com> wrote:
> Drop the 5.0 GT/s Link Speed retraining code block from Rockchip PCIe
> EP driver. The reason is that Shawn Lin from Rockchip has reiterated
> that there may be danger of "catastrophic failure" in using their PCIe
> with 5.0 GT/s speeds.
>
> While Rockchip has done so informally without issuing a proper errata,
> and the particulars are thus unknown, this may cause data loss or
> worse.
>
> This change is corroborated by RK3399 official datasheet [1], which
> states maximum link speed for this platform is 2.5 GT/s.
>
> [1] https://opensource.rock-chips.com/images/d/d7/Rockchip_RK3399_Datasheet_V2.1-20200323.pdf
>
> Link: https://lore.kernel.org/all/ffd05070-9879-4468-94e3-b88968b4c21b@rock-chips.com/
> Cc: stable@vger.kernel.org
> Reported-by: Dragan Simic <dsimic@manjaro.org>
> Reported-by: Shawn Lin <shawn.lin@rock-chips.com>
> Signed-off-by: Geraldo Nascimento <geraldogabriel@gmail.com>
> ---
> drivers/pci/controller/pcie-rockchip-ep.c | 13 -------------
> 1 file changed, 13 deletions(-)
>
> diff --git a/drivers/pci/controller/pcie-rockchip-ep.c b/drivers/pci/controller/pcie-rockchip-ep.c
> index 799461335762e..9ebc227a1ef84 100644
> --- a/drivers/pci/controller/pcie-rockchip-ep.c
> +++ b/drivers/pci/controller/pcie-rockchip-ep.c
> @@ -553,19 +553,6 @@ static void rockchip_pcie_ep_link_training(struct work_struct *work)
> if (ret)
> goto again;
>
> - /*
> - * Check the current speed: if gen2 speed was requested and we are not
> - * at gen2 speed yet, retrain again for gen2.
> - */
> - val = rockchip_pcie_read(rockchip, PCIE_CORE_CTRL);
> - if (!PCIE_LINK_IS_GEN2(val) && rockchip->link_gen == 2) {
> - /* Enable retrain for gen2 */
> - rockchip_pcie_ep_retrain_link(rockchip);
> - readl_poll_timeout(rockchip->apb_base + PCIE_CORE_CTRL,
> - val, PCIE_LINK_IS_GEN2(val), 50,
> - LINK_TRAIN_TIMEOUT);
> - }
> -
> /* Check again that the link is up */
> if (!rockchip_pcie_ep_link_up(rockchip))
> goto again;
Looking good to me, so please feel free to include
Reviewed-by: Dragan Simic <dsimic@manjaro.org>
next prev parent reply other threads:[~2026-06-16 19:12 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-06-16 15:24 [PATCH v7 0/3] PCI: rockchip: 5.0 GT/s speed discouraged by Rockchip Geraldo Nascimento
2026-06-16 15:25 ` [PATCH v7 1/3] PCI: rockchip-ep: do not attempt 5.0 GT/s retraining Geraldo Nascimento
2026-06-16 19:06 ` Dragan Simic [this message]
2026-06-16 15:25 ` [PATCH v7 2/3] PCI: rockchip-host: " Geraldo Nascimento
2026-06-16 19:08 ` Dragan Simic
2026-06-16 15:26 ` [PATCH v7 3/3] PCI: rockchip: drive at 2.5 GT/s, error other speeds Geraldo Nascimento
2026-06-16 19:10 ` Dragan Simic
2026-08-13 17:26 ` [PATCH v7 0/3] PCI: rockchip: 5.0 GT/s speed discouraged by Rockchip Geraldo Nascimento
2026-10-09 6:59 ` Shawn Lin
2026-10-13 13:47 ` Manivannan Sadhasivam
2026-10-13 18:11 ` Geraldo Nascimento
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ee80e2c7-8327-0000-5986-e909f0a41df1@manjaro.org \
--to=dsimic@manjaro.org \
--cc=bhelgaas@google.com \
--cc=geraldogabriel@gmail.com \
--cc=kwilczynski@kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pci@vger.kernel.org \
--cc=linux-rockchip@lists.infradead.org \
--cc=lpieralisi@kernel.org \
--cc=mani@kernel.org \
--cc=robh@kernel.org \
--cc=shawn.lin@rock-chips.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®