From: Robin Murphy <robin.murphy@arm.com>
To: Ilkka Koskinen <ilkka@os.amperecomputing.com>
Cc: will@kernel.org, mark.rutland@arm.com,
linux-arm-kernel@lists.infradead.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH 1/8] perf/arm-cmn: Refactor node ID handling. Again.
Date: Tue, 27 Aug 2024 14:51:25 +0100 [thread overview]
Message-ID: <eeb1eb1c-2e94-4110-a0ff-75efd0794c8e@arm.com> (raw)
In-Reply-To: <ab1b89c7-7bf-78d2-50ca-3411e511ec33@os.amperecomputing.com>
On 24/08/2024 2:00 am, Ilkka Koskinen wrote:
[...]
>> static struct arm_cmn_node *arm_cmn_node_to_xp(const struct arm_cmn *cmn,
>> const struct arm_cmn_node *dn)
>> {
>> - struct arm_cmn_nodeid nid = arm_cmn_nid(cmn, dn->id);
>> - int xp_idx = cmn->mesh_x * nid.y + nid.x;
>> + int id = dn->id >> (dn->portid_bits + dn->deviceid_bits);
>> + int bits = arm_cmn_xyidbits(cmn);
>> + int x = id > bits;
> ^^^
>
> Instead of comparison, shouldn't that be bit shift?
Oh dear indeed... and of course the effects of that would only show up
on hardware configurations I don't have. Good catch, thanks!
Cheers,
Robin.
next prev parent reply other threads:[~2024-08-27 13:51 UTC|newest]
Thread overview: 32+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-08-09 19:15 [PATCH 0/8] perf/arm-cmn: Fixes and updates Robin Murphy
2024-08-09 19:15 ` [PATCH 1/8] perf/arm-cmn: Refactor node ID handling. Again Robin Murphy
2024-08-16 9:33 ` Mark Rutland
2024-08-16 11:56 ` Robin Murphy
2024-08-16 12:45 ` Mark Rutland
2024-08-16 13:21 ` Robin Murphy
2024-08-24 1:00 ` Ilkka Koskinen
2024-08-27 13:51 ` Robin Murphy [this message]
2024-08-09 19:15 ` [PATCH 2/8] perf/arm-cmn: Fix CCLA register offset Robin Murphy
2024-08-16 10:00 ` Mark Rutland
2024-08-16 18:33 ` Robin Murphy
2024-08-23 23:18 ` Ilkka Koskinen
2024-08-09 19:15 ` [PATCH 3/8] perf/arm-cmn: Ensure dtm_idx is big enough Robin Murphy
2024-08-16 10:14 ` Mark Rutland
2024-08-19 15:00 ` Robin Murphy
2024-08-20 9:27 ` Mark Rutland
2024-08-23 23:58 ` Ilkka Koskinen
2024-08-09 19:15 ` [PATCH 4/8] perf/arm-cmn: Improve build-time assertions Robin Murphy
2024-08-16 10:20 ` Mark Rutland
2024-08-09 19:15 ` [PATCH 5/8] perf/arm-cmn: Make cycle counts less surprising Robin Murphy
2024-08-16 10:25 ` Mark Rutland
2024-08-19 16:35 ` Robin Murphy
2024-08-09 19:15 ` [PATCH 6/8] perf/arm-cmn: Refactor DTC PMU register access Robin Murphy
2024-08-16 10:29 ` Mark Rutland
2024-08-19 16:41 ` Robin Murphy
2024-08-20 9:23 ` Mark Rutland
2024-08-23 23:46 ` Ilkka Koskinen
2024-08-09 19:15 ` [PATCH 7/8] dt-bindings: perf: arm-cmn: Add CMN S3 Robin Murphy
2024-08-15 15:20 ` Rob Herring (Arm)
2024-08-09 19:15 ` [PATCH 8/8] perf/arm-cmn: Support " Robin Murphy
2024-08-16 10:32 ` Mark Rutland
2024-08-23 23:38 ` Ilkka Koskinen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=eeb1eb1c-2e94-4110-a0ff-75efd0794c8e@arm.com \
--to=robin.murphy@arm.com \
--cc=ilkka@os.amperecomputing.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mark.rutland@arm.com \
--cc=will@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®