* [PATCH 1/2] checkpatch: kconfig: replace '---help---' with 'help'
@ 2020-12-14 10:23 Nicolai Fischer
2020-12-20 19:02 ` Joe Perches
0 siblings, 1 reply; 3+ messages in thread
From: Nicolai Fischer @ 2020-12-14 10:23 UTC (permalink / raw)
To: linux-kernel; +Cc: joe, apw, johannes.czekay, linux-kernel
All '---help---' lines have been replaced by just 'help'.
Therefore it is no longer necessary to include '---' in the regex.
Signed-off-by: Nicolai Fischer <nicolai.fischer@fau.de>
Co-developed-by: Johannes Czekay <johannes.czekay@fau.de>
Signed-off-by: Johannes Czekay <johannes.czekay@fau.de>
---
scripts/checkpatch.pl | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/scripts/checkpatch.pl b/scripts/checkpatch.pl
index 52f467fd32f9..5cd98f2b75f6 100755
--- a/scripts/checkpatch.pl
+++ b/scripts/checkpatch.pl
@@ -3323,7 +3323,7 @@ sub process {
if ($lines[$ln - 1] =~ /^\+\s*(?:bool|tristate|prompt)\s*["']/) {
$is_start = 1;
- } elsif ($lines[$ln - 1] =~ /^\+\s*(?:---)?help(?:---)?$/) {
+ } elsif ($lines[$ln - 1] =~ /^\+\s*help$/) {
$length = -1;
}
--
2.28.0
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH 1/2] checkpatch: kconfig: replace '---help---' with 'help'
2020-12-14 10:23 [PATCH 1/2] checkpatch: kconfig: replace '---help---' with 'help' Nicolai Fischer
@ 2020-12-20 19:02 ` Joe Perches
2020-12-23 1:38 ` Andrew Morton
0 siblings, 1 reply; 3+ messages in thread
From: Joe Perches @ 2020-12-20 19:02 UTC (permalink / raw)
To: Nicolai Fischer, linux-kernel, Andrew Morton
Cc: apw, johannes.czekay, linux-kernel
On Mon, 2020-12-14 at 11:23 +0100, Nicolai Fischer wrote:
> All '---help---' lines have been replaced by just 'help'.
> Therefore it is no longer necessary to include '---' in the regex.
>
> Signed-off-by: Nicolai Fischer <nicolai.fischer@fau.de>
> Co-developed-by: Johannes Czekay <johannes.czekay@fau.de>
> Signed-off-by: Johannes Czekay <johannes.czekay@fau.de>
Acked-by: Joe Perches <joe@perches.com>
> ---
> scripts/checkpatch.pl | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/scripts/checkpatch.pl b/scripts/checkpatch.pl
> index 52f467fd32f9..5cd98f2b75f6 100755
> --- a/scripts/checkpatch.pl
> +++ b/scripts/checkpatch.pl
> @@ -3323,7 +3323,7 @@ sub process {
>
>
> if ($lines[$ln - 1] =~ /^\+\s*(?:bool|tristate|prompt)\s*["']/) {
> $is_start = 1;
> - } elsif ($lines[$ln - 1] =~ /^\+\s*(?:---)?help(?:---)?$/) {
> + } elsif ($lines[$ln - 1] =~ /^\+\s*help$/) {
> $length = -1;
> }
>
>
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH 1/2] checkpatch: kconfig: replace '---help---' with 'help'
2020-12-20 19:02 ` Joe Perches
@ 2020-12-23 1:38 ` Andrew Morton
0 siblings, 0 replies; 3+ messages in thread
From: Andrew Morton @ 2020-12-23 1:38 UTC (permalink / raw)
To: Joe Perches
Cc: Nicolai Fischer, linux-kernel, apw, johannes.czekay, linux-kernel
On Sun, 20 Dec 2020 11:02:15 -0800 Joe Perches <joe@perches.com> wrote:
> On Mon, 2020-12-14 at 11:23 +0100, Nicolai Fischer wrote:
> > All '---help---' lines have been replaced by just 'help'.
> > Therefore it is no longer necessary to include '---' in the regex.
> >
> > Signed-off-by: Nicolai Fischer <nicolai.fischer@fau.de>
> > Co-developed-by: Johannes Czekay <johannes.czekay@fau.de>
> > Signed-off-by: Johannes Czekay <johannes.czekay@fau.de>
>
> Acked-by: Joe Perches <joe@perches.com>
Seems that [2/2] will be reissued. Nicolai, please cc me on the v2
series?
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2020-12-23 1:39 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-12-14 10:23 [PATCH 1/2] checkpatch: kconfig: replace '---help---' with 'help' Nicolai Fischer
2020-12-20 19:02 ` Joe Perches
2020-12-23 1:38 ` Andrew Morton
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®