From: Konrad Dybcio <konrad.dybcio@oss.qualcomm.com>
To: Albert Esteve <aesteve@redhat.com>,
Bjorn Andersson <andersson@kernel.org>,
Konrad Dybcio <konradybcio@kernel.org>
Cc: linux-arm-msm@vger.kernel.org, linux-kernel@vger.kernel.org,
Ninad Naik <quic_ninanaik@quicinc.com>,
Murali Nalajala <quic_mnalajal@quicinc.com>,
Venkatakrishnaiah Pari <quic_vpari@quicinc.com>,
Jian Shu <quic_jianshu@quicinc.com>,
Guru Das Srinagesh <linux@gurudas.dev>
Subject: Re: [PATCH 1/2] firmware: qcom: scm: Introduce new locking mechanism for SCM driver
Date: Tue, 25 Aug 2026 12:15:38 +0200 [thread overview]
Message-ID: <eee2a3eb-6199-495b-880a-7c94a697d900@oss.qualcomm.com> (raw)
In-Reply-To: <20260824-port-scm-patches-v1-1-1dfd69374402@redhat.com>
On 8/24/26 1:35 PM, Albert Esteve wrote:
> From: Ninad Naik <quic_ninanaik@quicinc.com>
>
> With the existing global mutex lock, there is a possibility that it
> could resulty into a deadlock when SMCInvoke and smc call go to
> firmware in the same order and both wait on same WAITQ in firmware.
I think the commit message should be extended to better explain how
that may happen (because presumably it did in the real world)
A Fixes tag may also be applicable here
Konrad
next prev parent reply other threads:[~2026-08-25 10:15 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-08-24 11:35 [PATCH 0/2] firmware: qcom: scm locking improvements Albert Esteve
2026-08-24 11:35 ` [PATCH 1/2] firmware: qcom: scm: Introduce new locking mechanism for SCM driver Albert Esteve
2026-08-25 10:15 ` Konrad Dybcio [this message]
2026-08-26 11:33 ` Albert Esteve
2026-08-24 11:35 ` [PATCH 2/2] firmware: qcom: scm: Allow the SMC request to freeze and kill Albert Esteve
2026-08-25 10:21 ` Konrad Dybcio
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=eee2a3eb-6199-495b-880a-7c94a697d900@oss.qualcomm.com \
--to=konrad.dybcio@oss.qualcomm.com \
--cc=aesteve@redhat.com \
--cc=andersson@kernel.org \
--cc=konradybcio@kernel.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux@gurudas.dev \
--cc=quic_jianshu@quicinc.com \
--cc=quic_mnalajal@quicinc.com \
--cc=quic_ninanaik@quicinc.com \
--cc=quic_vpari@quicinc.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®