Re: [PATCH RESEND 1/2] media: dt-bindings: nxp,imx8-jpeg: Add compatible strings for IMX95 JPEG

[Nicolas Dufresne <nicolas@ndufresne.ca>]

Hi,

Le mercredi 21 mai 2025 à 13:34 -0400, Frank Li a écrit :
> Add compatible strings "nxp,imx95-jpgdec" and "nxp,imx95-jpgenc", which
> are backward compatible with "nxp,imx8qxp-jpgdec" and
> "nxp,imx8qxp-jpegenc". i.MX95 just need one power domain which combine
> wrap and all slots together. Reduce minItems of power-domains to 1 for
> i.MX95 and keep the same restriction for others.
> 
> Reviewed-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
> Signed-off-by: Frank Li <Frank.Li@nxp.com>

Acked-by: Nicolas Dufresne <nicolas.dufresne@collabora.com>

Krzysztof, will you take this one once the DTS part is ready ?

regards,
Nicolas

> ---
>  .../bindings/media/nxp,imx8-jpeg.yaml         | 28 +++++++++++++++++--
>  1 file changed, 25 insertions(+), 3 deletions(-)
> 
> diff --git a/Documentation/devicetree/bindings/media/nxp,imx8-jpeg.yaml
> b/Documentation/devicetree/bindings/media/nxp,imx8-jpeg.yaml
> index 2be30c5fdc839..4cba42ba7cf72 100644
> --- a/Documentation/devicetree/bindings/media/nxp,imx8-jpeg.yaml
> +++ b/Documentation/devicetree/bindings/media/nxp,imx8-jpeg.yaml
> @@ -22,10 +22,14 @@ properties:
>              - nxp,imx8qxp-jpgdec
>              - nxp,imx8qxp-jpgenc
>        - items:
> -          - const: nxp,imx8qm-jpgdec
> +          - enum:
> +              - nxp,imx8qm-jpgdec
> +              - nxp,imx95-jpgdec
>            - const: nxp,imx8qxp-jpgdec
>        - items:
> -          - const: nxp,imx8qm-jpgenc
> +          - enum:
> +              - nxp,imx8qm-jpgenc
> +              - nxp,imx95-jpgenc
>            - const: nxp,imx8qxp-jpgenc
>  
>    reg:
> @@ -48,7 +52,7 @@ properties:
>      description:
>        List of phandle and PM domain specifier as documented in
>        Documentation/devicetree/bindings/power/power_domain.txt
> -    minItems: 2               # Wrapper and 1 slot
> +    minItems: 1               # Wrapper and all slots
>      maxItems: 5               # Wrapper and 4 slots
>  
>  required:
> @@ -58,6 +62,24 @@ required:
>    - interrupts
>    - power-domains
>  
> +allOf:
> +  - if:
> +      properties:
> +        compatible:
> +          contains:
> +            enum:
> +              - nxp,imx95-jpgenc
> +              - nxp,imx95-jpgdec
> +    then:
> +      properties:
> +        power-domains:
> +          maxItems: 1
> +    else:
> +      properties:
> +        power-domains:
> +          minItems: 2        # Wrapper and 1 slot
> +
> +
>  additionalProperties: false
>  
>  examples: