mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Michal Wilczynski <m.wilczynski@samsung.com>
To: Alessio Belle <Alessio.Belle@imgtec.com>
Cc: "lkp@intel.com" <lkp@intel.com>,
	Luigi Santivetti <Luigi.Santivetti@imgtec.com>,
	"tzimmermann@suse.de" <tzimmermann@suse.de>,
	"simona@ffwll.ch" <simona@ffwll.ch>,
	"dri-devel@lists.freedesktop.org"
	<dri-devel@lists.freedesktop.org>,
	"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
	Frank Binns <Frank.Binns@imgtec.com>,
	"maarten.lankhorst@linux.intel.com"
	<maarten.lankhorst@linux.intel.com>,
	"mripard@kernel.org" <mripard@kernel.org>,
	"airlied@gmail.com" <airlied@gmail.com>
Subject: Re: [PATCH v3] drm/imagination: Align rogue_fwif_hwrtdata to 64 bytes
Date: Thu, 29 Oct 2026 09:07:56 +0100	[thread overview]
Message-ID: <ef0683f4-b14e-430f-8b28-8e1851ad3cf2@samsung.com> (raw)
In-Reply-To: <29ed7e87285e39dfcb87c07d3c8a17361277f878.camel@imgtec.com>



On 10/28/26 15:43, Alessio Belle wrote:
> Hi Michal,
> 
> On Mon, 2026-08-10 at 12:20 +0200, Michal Wilczynski wrote:
>> The build fails on RISC-V using GCC because `SIZE_CHECK(struct
>> rogue_fwif_hwrtdata, 384)` expects 384 bytes, but the compiler generates
>> a 336-byte structure.
>>
>> This is due to an alignment conflict: the inner member `cleanup_state`
>> requires 64-byte alignment, but the outer struct is explicitly marked
>> `__aligned(8)`.
>>
>> While GCC on ARM64 implicitly pads the size to a multiple of 64, GCC on
>> RISC-V strictly respects the 8-byte outer alignment, resulting in a size
>> mismatch.
>>
>> Fix this by aligning the entire structure to 64 bytes, which resolves
>> the contradiction and forces the correct 384 byte size on all
>> architectures.
>>
>> Fixes: a26f067feac1 ("drm/imagination: Add FWIF headers")
>> Reported-by: kernel test robot <lkp@intel.com>
>> Closes: https://lore.kernel.org/oe-kbuild-all/202512131851.1WNXk3BC-lkp@intel.com/
>> Reviewed-by: Luigi Santivetti <luigi.santivetti@imgtec.com>
>> Signed-off-by: Michal Wilczynski <m.wilczynski@samsung.com>
>> ---
>> Changes in v3:
>> - Cleaned up the changelog section by removing the accidental b4
>>   "EDITME" template from v2.
>> - No changes to the code or commit message.
>> - Rebased patch on latest master.
>>
>> Changes in v2:
>> - Expanded the commit message to properly explain the root cause of the
>>   GCC alignment conflict on RISC-V vs ARM64, based on v1 feedback.
> 
> Sorry to bother again on this. All versions have the same commit message as the
> original. Do you still have the updated message that I think was meant to be
> sent in v2? Or are you fine with me making these changes to the commit message
> (+ rewrap) before applying this?
> 
> - "The build fails on RISC-V using GCC" -> "Sparse (W=1) builds fail"
> - "While GCC on ARM64" -> "While a non-sparse build"
> - "GCC on RISC-V strictly respects" -> "a sparse build strictly respects"
> - "on all architectures" -> "on all builds"
> 
> Thanks,
> Alessio
> 

Hmm I was sure the commit text was changed last time, anyway will fix
and resend thanks !


Best regards,
-- 
Michal Wilczynski <m.wilczynski@samsung.com>

      reply	other threads:[~2026-10-29  8:07 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <CGME20260810102037eucas1p2f68492f185b4e411aafa83d5d15d0499@eucas1p2.samsung.com>
2026-08-10 10:20 ` Michal Wilczynski
2026-10-28 14:43   ` Alessio Belle
2026-10-29  8:07     ` Michal Wilczynski [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=ef0683f4-b14e-430f-8b28-8e1851ad3cf2@samsung.com \
    --to=m.wilczynski@samsung.com \
    --cc=Alessio.Belle@imgtec.com \
    --cc=Frank.Binns@imgtec.com \
    --cc=Luigi.Santivetti@imgtec.com \
    --cc=airlied@gmail.com \
    --cc=dri-devel@lists.freedesktop.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=lkp@intel.com \
    --cc=maarten.lankhorst@linux.intel.com \
    --cc=mripard@kernel.org \
    --cc=simona@ffwll.ch \
    --cc=tzimmermann@suse.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®