From: Waiman Long <longman@redhat.com>
To: Mukesh Ojha <quic_mojha@quicinc.com>, Hillf Danton <hdanton@sina.com>
Cc: "Peter Zijlstra" <peterz@infradead.org>,
"Ingo Molnar" <mingo@redhat.com>, "Will Deacon" <will@kernel.org>,
"Boqun Feng" <boqun.feng@gmail.com>,
linux-kernel@vger.kernel.org, john.p.donnelly@oracle.com,
"Ting11 Wang 王婷" <wangting11@xiaomi.com>
Subject: Re: [PATCH v3 4/5] locking/rwsem: Enable direct rwsem lock handoff
Date: Tue, 18 Oct 2022 13:37:20 -0400 [thread overview]
Message-ID: <ef17f410-1cc2-7159-5e4c-f146a9e4aad1@redhat.com> (raw)
In-Reply-To: <9b63611e-8d9a-529b-dcdc-05b10a8a712a@quicinc.com>
On 10/18/22 10:13, Mukesh Ojha wrote:
> Hi,
>
> On 10/18/2022 4:44 PM, Hillf Danton wrote:
>> On 17 Oct 2022 17:13:55 -0400 Waiman Long <longman@redhat.com>
>>> @@ -1067,13 +1119,33 @@ rwsem_down_read_slowpath(struct rw_semaphore
>>> *sem, long count, unsigned int stat
>>> return sem;
>>> }
>>> adjustment += RWSEM_FLAG_WAITERS;
>>> + } else if ((count & RWSEM_FLAG_HANDOFF) &&
>>> + ((count & RWSEM_LOCK_MASK) == RWSEM_READER_BIAS)) {
>>
>> Could a couple of CPUs go read slow path in parallel?
This is under wait_lock protection. So no parallel execution is possible.
>>
>>> + /*
>>> + * If the waiter to be handed off is a reader, this reader
>>> + * can piggyback on top of top of that.
>>> + */
>>> + if (rwsem_first_waiter(sem)->type == RWSEM_WAITING_FOR_READ)
>>> + adjustment = 0;
>>> + rwsem_handoff(sem, adjustment, &wake_q);
>>> +
>>> + if (!adjustment) {
>>> + raw_spin_unlock_irq(&sem->wait_lock);
>>> + wake_up_q(&wake_q);
>>> + return sem;
>>> + }
>>> + adjustment = 0;
>>> }
>>> rwsem_add_waiter(sem, &waiter);
>>
>> Why can this acquirer pigyback without becoming a waiter?
The idea is to have as much reader parallelism as possible without
writer starvation. In other word, a continuous stream of readers is not
allowed to block out writer. However, there are places where allow one
more reader to get the lock won't cause writer starvation.
>>
>>> - /* we're now waiting on the lock, but no longer actively
>>> locking */
>>> - count = atomic_long_add_return(adjustment, &sem->count);
>>> -
>>> - rwsem_cond_wake_waiter(sem, count, &wake_q);
>>> + if (adjustment) {
>>> + /*
>>> + * We are now waiting on the lock with no handoff, but no
>>> + * longer actively locking.
>>> + */
>>> + count = atomic_long_add_return(adjustment, &sem->count);
>>> + rwsem_cond_wake_waiter(sem, count, &wake_q);
>>> + }
>>> raw_spin_unlock_irq(&sem->wait_lock);
>>> if (!wake_q_empty(&wake_q))
>>> @@ -1120,7 +1192,6 @@ static struct rw_semaphore __sched *
>>> rwsem_down_write_slowpath(struct rw_semaphore *sem, int state)
>>> {
>>> struct rwsem_waiter waiter;
>>> - int null_owner_retries;
>>
>> This reverts 2/5 and feel free to drop it directly.
>
> I think, he intents to tag the first two patches to go to stable
> branches.
This patch is too disruptive to go to the stable branches. Yes, I do
intend the first 2 patches to go into stable branches.
Cheers,
Longman
next prev parent reply other threads:[~2022-10-18 17:37 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-10-17 21:13 [PATCH v3 0/5] lockinig/rwsem: Fix rwsem bugs & enable true " Waiman Long
2022-10-17 21:13 ` [PATCH v3 1/5] locking/rwsem: Prevent non-first waiter from spinning in down_write() slowpath Waiman Long
2022-10-24 13:17 ` Peter Zijlstra
2022-10-24 13:50 ` Waiman Long
2022-10-17 21:13 ` [PATCH v3 2/5] locking/rwsem: Limit # of null owner retries for handoff writer Waiman Long
2022-10-24 13:31 ` Peter Zijlstra
2022-10-24 15:55 ` Waiman Long
2022-10-25 11:22 ` Peter Zijlstra
2022-10-25 11:48 ` Peter Zijlstra
2022-10-25 19:55 ` Waiman Long
2022-10-25 20:14 ` Peter Zijlstra
2022-10-26 1:44 ` Waiman Long
[not found] ` <20221025145843.2953-1-hdanton@sina.com>
2022-10-25 19:00 ` Waiman Long
2022-10-17 21:13 ` [PATCH v3 3/5] locking/rwsem: Change waiter->hanodff_set to a handoff_state enum Waiman Long
2022-10-17 21:13 ` [PATCH v3 4/5] locking/rwsem: Enable direct rwsem lock handoff Waiman Long
2022-10-17 21:13 ` [PATCH v3 5/5] locking/rwsem: Update handoff lock events tracking Waiman Long
[not found] ` <20221018111424.1007-1-hdanton@sina.com>
2022-10-18 14:13 ` [PATCH v3 4/5] locking/rwsem: Enable direct rwsem lock handoff Mukesh Ojha
2022-10-18 17:37 ` Waiman Long [this message]
[not found] ` <20221018235138.1088-1-hdanton@sina.com>
2022-10-19 0:39 ` Waiman Long
[not found] ` <20221019022934.1166-1-hdanton@sina.com>
2022-10-19 2:49 ` Waiman Long
[not found] ` <20221019070559.1220-1-hdanton@sina.com>
2022-10-19 15:02 ` Waiman Long
2022-10-24 16:18 ` Waiman Long
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ef17f410-1cc2-7159-5e4c-f146a9e4aad1@redhat.com \
--to=longman@redhat.com \
--cc=boqun.feng@gmail.com \
--cc=hdanton@sina.com \
--cc=john.p.donnelly@oracle.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@redhat.com \
--cc=peterz@infradead.org \
--cc=quic_mojha@quicinc.com \
--cc=wangting11@xiaomi.com \
--cc=will@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®