mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: James Clark <james.clark@linaro.org>
To: Suzuki K Poulose <suzuki.poulose@arm.com>
Cc: coresight@lists.linaro.org, linux-kernel@vger.kernel.org,
	Sashiko <sashiko-bot@kernel.org>, Mike Leach <mike.leach@arm.com>,
	Leo Yan <leo.yan@arm.com>, Yeoreum Yun <yeoreum.yun@arm.com>
Subject: Re: [PATCH 0/9] coresight: Fix assorted bugs reported by Sashiko
Date: Wed, 4 Nov 2026 14:55:33 +0000	[thread overview]
Message-ID: <ef1891a6-f53e-4f9b-8fa3-b8ea17e05c89@linaro.org> (raw)
In-Reply-To: <3a778670-846a-4c29-bf8e-2f2e255d14ef@arm.com>



On 04/11/2026 10:25, Suzuki K Poulose wrote:
> On 27/10/2026 14:55, James Clark wrote:
>> Small fixes for bugs in the CoreSight drivers that were found by
>> Sashiko. Mostly reference and resource leaks on error paths, plus a
>> deadlock, a missing lock, and a sysfs store that should return -EBUSY
>> while a sysfs session is enabled.
>>
>> This series depends on "coresight: Prevent per-thread events from
>> sharing a sink" v4 [1]. That series takes coresight_mutex for perf AUX
>> setup and adds coresight_release_path_locked(), which the
>> etm_setup_aux() and coresight_build_path() fixes here are based on.
> 
> Please could you post these based on coresight/next ? As these are fixes
> for existing issues, I can queue them (and potentially be backported for
> stable) without additional dependencies ?
> 
> Cheers
> Suzuki
> 

Yeah I can pull "coresight: etm-perf: Serialize AUX topology access" out 
of the other patchset and add it to this one, it's also a fix and the 
only thing that these depended on.

>>
>> [1]: https://lore.kernel.org/r/20261016-james-cs-multiple-per-threads- 
>> v4-0-dedf961aca0e@linaro.org/
>>
>> Signed-off-by: James Clark <james.clark@linaro.org>
>> ---
>> James Clark (9):
>>        coresight: cpu-debug: Fix PM usage counter leak in 
>> debug_enable_func()
>>        coresight: etm4x: Remove perf symlink if config registration fails
>>        coresight: etm4x: Fix truncation of nr_ext_inp
>>        coresight: etm-perf: Fix sink device reference leak in 
>> etm_setup_aux()
>>        coresight: syscfg: Take csdev lock when removing owned features
>>        coresight: syscfg: Fix deadlock in cscfg_create_device() error 
>> path
>>        coresight: Fix resource leaks on coresight_build_path() errors
>>        coresight: etm3x: Don't ignore etm_parse_event_config() errors
>>        coresight: etm3x: Prohibit modifying seq_curr_state while 
>> session is enabled
>>
>>   drivers/hwtracing/coresight/coresight-core.c        | 6 ++++--
>>   drivers/hwtracing/coresight/coresight-cpu-debug.c   | 4 ++--
>>   drivers/hwtracing/coresight/coresight-etm-perf.c    | 4 ++++
>>   drivers/hwtracing/coresight/coresight-etm3x-core.c  | 6 +++++-
>>   drivers/hwtracing/coresight/coresight-etm3x-sysfs.c | 5 +++++
>>   drivers/hwtracing/coresight/coresight-etm4x-core.c  | 1 +
>>   drivers/hwtracing/coresight/coresight-etm4x.h       | 2 +-
>>   drivers/hwtracing/coresight/coresight-syscfg.c      | 8 +++++++-
>>   8 files changed, 29 insertions(+), 7 deletions(-)
>> ---
>> base-commit: 343cfcbb3ecfdb80aa576a428cfa3b65ad783842
>> change-id: 20261027-james-cs-sashiko-easy-fixes-1-692d80016a89
>> prerequisite-message-id: <20261016-james-cs-multiple-per-threads-v4-0- 
>> dedf961aca0e@linaro.org>
>> prerequisite-patch-id: 81acda380ba25acd3845eb58d5ded812175b9631
>> prerequisite-patch-id: 430caddc9c87948d4e9a0d1967bf3d8a50bca06b
>> prerequisite-patch-id: 633377150141300f7578b265fcc02eba52e592a8
>> prerequisite-patch-id: 9a82ffe5d705ac1fdf1250ff6bf242cfcd9d8fbf
>> prerequisite-patch-id: cf211801575d6bd0aa7fc0f6e19c3b90cea446a0
>> prerequisite-patch-id: d22fee48bf4aa3e01536e4683ccd797b3dbe1c91
>> prerequisite-patch-id: 55eeffb37cae55a1f47c2827899e0512b47a6efa
>> prerequisite-patch-id: c542d74cd4bc76158d5872bab12b8bd7a00f0c27
>> prerequisite-patch-id: 71cd37ed83d3e01d7a0321cdfa5cfc5ee113fe7b
>> prerequisite-patch-id: 74c1e3ed6dba4e25bfd3c39f06d43b079eed45e1
>>
>> Best regards,
>> -- 
>> James Clark <james.clark@linaro.org>
> 


      reply	other threads:[~2026-11-04 14:55 UTC|newest]

Thread overview: 14+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-10-27 14:55 James Clark
2026-10-27 14:55 ` [PATCH 1/9] coresight: cpu-debug: Fix PM usage counter leak in debug_enable_func() James Clark
2026-10-27 18:08   ` Leo Yan
2026-10-28  9:16     ` James Clark
2026-10-27 14:55 ` [PATCH 2/9] coresight: etm4x: Remove perf symlink if config registration fails James Clark
2026-10-27 14:55 ` [PATCH 3/9] coresight: etm4x: Fix truncation of nr_ext_inp James Clark
2026-10-27 14:55 ` [PATCH 4/9] coresight: etm-perf: Fix sink device reference leak in etm_setup_aux() James Clark
2026-10-27 14:55 ` [PATCH 5/9] coresight: syscfg: Take csdev lock when removing owned features James Clark
2026-10-27 14:55 ` [PATCH 6/9] coresight: syscfg: Fix deadlock in cscfg_create_device() error path James Clark
2026-10-27 14:55 ` [PATCH 7/9] coresight: Fix resource leaks on coresight_build_path() errors James Clark
2026-10-27 14:55 ` [PATCH 8/9] coresight: etm3x: Don't ignore etm_parse_event_config() errors James Clark
2026-10-27 14:55 ` [PATCH 9/9] coresight: etm3x: Prohibit modifying seq_curr_state while session is enabled James Clark
2026-11-04 10:25 ` [PATCH 0/9] coresight: Fix assorted bugs reported by Sashiko Suzuki K Poulose
2026-11-04 14:55   ` James Clark [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=ef1891a6-f53e-4f9b-8fa3-b8ea17e05c89@linaro.org \
    --to=james.clark@linaro.org \
    --cc=coresight@lists.linaro.org \
    --cc=leo.yan@arm.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mike.leach@arm.com \
    --cc=sashiko-bot@kernel.org \
    --cc=suzuki.poulose@arm.com \
    --cc=yeoreum.yun@arm.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®