mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
* [PATCH] sfc: fix CONFIG_CXL_MEM dependency
@ 2026-09-17 15:55 Arnd Bergmann
  2026-09-21  7:43 ` Lucero Palau, Alejandro
  2026-09-21 23:20 ` patchwork-bot+netdevbpf
  0 siblings, 2 replies; 3+ messages in thread
From: Arnd Bergmann @ 2026-09-17 15:55 UTC (permalink / raw)
  To: Edward Cree, Andrew Lunn, David S. Miller, Eric Dumazet,
	Jakub Kicinski, Paolo Abeni, Dave Jiang, Dan Williams,
	Alejandro Lucero
  Cc: Arnd Bergmann, Jonathan Cameron, Alison Schofield, netdev,
	linux-net-drivers, linux-kernel

From: Arnd Bergmann <arnd@arndb.de>

A recent patch introduced a call to devm_cxl_probe_mem(), which is only
available when CXL_MEM is enabled. If CXL_MEM is in a loadable module,
this causes a link failure for a builtin driver:

s390-linux-ld: drivers/net/ethernet/sfc/efx_cxl.o: in function `efx_cxl_init':
efx_cxl.c:(.text+0x156): undefined reference to `devm_cxl_probe_mem'

Adapt the dependency to require CXL_MEM instead of CXL_BUS, which
we know is available when CXL_MEM is.

Fixes: 0418860ef2ca ("sfc: obtain and map cxl range using devm_cxl_probe_mem")
Signed-off-by: Arnd Bergmann <arnd@arndb.de>
---
 drivers/net/ethernet/sfc/Kconfig | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/net/ethernet/sfc/Kconfig b/drivers/net/ethernet/sfc/Kconfig
index 979f2801e2a8..e2898ec2e6e9 100644
--- a/drivers/net/ethernet/sfc/Kconfig
+++ b/drivers/net/ethernet/sfc/Kconfig
@@ -68,7 +68,7 @@ config SFC_MCDI_LOGGING
 	  a sysfs file 'mcdi_logging' under the PCI device.
 config SFC_CXL
 	bool "Solarflare SFC9100-family CXL support"
-	depends on SFC && CXL_BUS >= SFC
+	depends on SFC && CXL_MEM >= SFC
 	default SFC
 	help
 	  This enables SFC CXL support if the kernel is configuring CXL for
-- 
2.53.0


^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: [PATCH] sfc: fix CONFIG_CXL_MEM dependency
  2026-09-17 15:55 [PATCH] sfc: fix CONFIG_CXL_MEM dependency Arnd Bergmann
@ 2026-09-21  7:43 ` Lucero Palau, Alejandro
  2026-09-21 23:20 ` patchwork-bot+netdevbpf
  1 sibling, 0 replies; 3+ messages in thread
From: Lucero Palau, Alejandro @ 2026-09-21  7:43 UTC (permalink / raw)
  To: Arnd Bergmann, Edward Cree, Andrew Lunn, David S. Miller,
	Eric Dumazet, Jakub Kicinski, Paolo Abeni, Dave Jiang,
	Dan Williams, Alejandro Lucero
  Cc: Arnd Bergmann, Jonathan Cameron, Alison Schofield, netdev,
	linux-net-drivers, linux-kernel


On 17/09/2026 16:55, Arnd Bergmann wrote:
> From: Arnd Bergmann <arnd@arndb.de>
>
> A recent patch introduced a call to devm_cxl_probe_mem(), which is only
> available when CXL_MEM is enabled. If CXL_MEM is in a loadable module,
> this causes a link failure for a builtin driver:
>
> s390-linux-ld: drivers/net/ethernet/sfc/efx_cxl.o: in function `efx_cxl_init':
> efx_cxl.c:(.text+0x156): undefined reference to `devm_cxl_probe_mem'
>
> Adapt the dependency to require CXL_MEM instead of CXL_BUS, which
> we know is available when CXL_MEM is.
>
> Fixes: 0418860ef2ca ("sfc: obtain and map cxl range using devm_cxl_probe_mem")
> Signed-off-by: Arnd Bergmann <arnd@arndb.de>
> ---
>   drivers/net/ethernet/sfc/Kconfig | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/net/ethernet/sfc/Kconfig b/drivers/net/ethernet/sfc/Kconfig
> index 979f2801e2a8..e2898ec2e6e9 100644
> --- a/drivers/net/ethernet/sfc/Kconfig
> +++ b/drivers/net/ethernet/sfc/Kconfig
> @@ -68,7 +68,7 @@ config SFC_MCDI_LOGGING
>   	  a sysfs file 'mcdi_logging' under the PCI device.
>   config SFC_CXL
>   	bool "Solarflare SFC9100-family CXL support"
> -	depends on SFC && CXL_BUS >= SFC
> +	depends on SFC && CXL_MEM >= SFC
>   	default SFC
>   	help
>   	  This enables SFC CXL support if the kernel is configuring CXL for


Reviewed-by: Alejandro Lucero <alucerop@amd.com>


^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: [PATCH] sfc: fix CONFIG_CXL_MEM dependency
  2026-09-17 15:55 [PATCH] sfc: fix CONFIG_CXL_MEM dependency Arnd Bergmann
  2026-09-21  7:43 ` Lucero Palau, Alejandro
@ 2026-09-21 23:20 ` patchwork-bot+netdevbpf
  1 sibling, 0 replies; 3+ messages in thread
From: patchwork-bot+netdevbpf @ 2026-09-21 23:20 UTC (permalink / raw)
  To: Arnd Bergmann
  Cc: ecree.xilinx, andrew+netdev, davem, edumazet, kuba, pabeni,
	dave.jiang, djbw, alucerop, arnd, Jonathan.Cameron,
	alison.schofield, netdev, linux-net-drivers, linux-kernel

Hello:

This patch was applied to netdev/net-next.git (main)
by Jakub Kicinski <kuba@kernel.org>:

On Thu, 17 Sep 2026 17:55:11 +0200 you wrote:
> From: Arnd Bergmann <arnd@arndb.de>
> 
> A recent patch introduced a call to devm_cxl_probe_mem(), which is only
> available when CXL_MEM is enabled. If CXL_MEM is in a loadable module,
> this causes a link failure for a builtin driver:
> 
> s390-linux-ld: drivers/net/ethernet/sfc/efx_cxl.o: in function `efx_cxl_init':
> efx_cxl.c:(.text+0x156): undefined reference to `devm_cxl_probe_mem'
> 
> [...]

Here is the summary with links:
  - sfc: fix CONFIG_CXL_MEM dependency
    https://git.kernel.org/netdev/net-next/c/c6219deaee41

You are awesome, thank you!
-- 
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/patchwork/pwbot.html



^ permalink raw reply	[flat|nested] 3+ messages in thread

end of thread, other threads:[~2026-09-21 23:21 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2026-09-17 15:55 [PATCH] sfc: fix CONFIG_CXL_MEM dependency Arnd Bergmann
2026-09-21  7:43 ` Lucero Palau, Alejandro
2026-09-21 23:20 ` patchwork-bot+netdevbpf

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®