mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: SF Markus Elfring <elfring@users.sourceforge.net>
To: Vinod Koul <vinod.koul@intel.com>,
	Dave Jiang <dave.jiang@intel.com>,
	dmaengine@vger.kernel.org
Cc: Dan Carpenter <dan.carpenter@oracle.com>,
	Arvind Yadav <arvind.yadav.cs@gmail.com>,
	"Williams, Dan J" <dan.j.williams@intel.com>,
	Geliang Tang <geliangtang@gmail.com>,
	Krister Johansen <kjlx@templeofstupid.com>,
	Pan Bian <bianpan2016@163.com>,
	LKML <linux-kernel@vger.kernel.org>,
	kernel-janitors@vger.kernel.org
Subject: Re: dmaengine: ioat: Use common error handling code in ioat_xor_val_self_test()
Date: Mon, 23 Oct 2017 19:39:21 +0200	[thread overview]
Message-ID: <ef4d8039-6d5c-5d31-515b-eda9f05faff6@users.sourceforge.net> (raw)
In-Reply-To: <20171023165617.GK936@localhost>

>> I agree with Dan. I'm ok with not accepting this patch.
> 
> And I have no intention to :)

This is a pity.


> At least they should explain why or how it help,

Do you see useful consequences (like a bit less memory requirements)
if the assignment statement “err = -ENODEV” will be stored only once
behind the jump label “failure_indication” in the suggested update
for the implementation of the function “ioat_xor_val_self_test”
(instead of being duplicated several times)?


> give the Coccinelle scripts..

How can they matter for a better understanding of the concrete
source code adjustment?


> But sadly that is not done ...

I did not include a link for special background information explicitly.
But how do you think about corresponding details from discussions
on a topic like “Comparing statement lists with SmPL”?

https://systeme.lip6.fr/pipermail/cocci/2017-August/004388.html

Regards,
Markus

      reply	other threads:[~2017-10-23 17:39 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-10-22 15:34 [PATCH] " SF Markus Elfring
2017-10-23  7:27 ` Dan Carpenter
2017-10-23 15:59   ` Dave Jiang
2017-10-23 16:56     ` Vinod Koul
2017-10-23 17:39       ` SF Markus Elfring [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=ef4d8039-6d5c-5d31-515b-eda9f05faff6@users.sourceforge.net \
    --to=elfring@users.sourceforge.net \
    --cc=arvind.yadav.cs@gmail.com \
    --cc=bianpan2016@163.com \
    --cc=dan.carpenter@oracle.com \
    --cc=dan.j.williams@intel.com \
    --cc=dave.jiang@intel.com \
    --cc=dmaengine@vger.kernel.org \
    --cc=geliangtang@gmail.com \
    --cc=kernel-janitors@vger.kernel.org \
    --cc=kjlx@templeofstupid.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=vinod.koul@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome