* [PATCH] HID: amd_sfh: change global variables to static
@ 2022-04-20 14:22 Tom Rix
2022-04-20 17:50 ` Basavaraj Natikar
2022-04-21 8:19 ` Jiri Kosina
0 siblings, 2 replies; 3+ messages in thread
From: Tom Rix @ 2022-04-20 14:22 UTC (permalink / raw)
To: basavaraj.natikar, jikos, benjamin.tissoires,
nehal-bakulchandra.shah, Shyam-sundar.S-k
Cc: linux-input, linux-kernel, Tom Rix
Smatch reports this representative issue
amd_sfh_hid_report_desc.h:182:10: warning: symbol 'gyro3_report_descriptor' was not declared. Should it be static?
Similar issues for comp3_report_descriptor and als_report_descriptor.
Global variables should not be defined in header files.
This only works because amd_sfh_hid_report_desc.h in only included by
amd_sfh_hid_desc.c so change the storage-class specifiers to static.
Signed-off-by: Tom Rix <trix@redhat.com>
---
.../amd-sfh-hid/hid_descriptor/amd_sfh_hid_report_desc.h | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
diff --git a/drivers/hid/amd-sfh-hid/hid_descriptor/amd_sfh_hid_report_desc.h b/drivers/hid/amd-sfh-hid/hid_descriptor/amd_sfh_hid_report_desc.h
index b07dc4bbb858..7a2b4e434e4f 100644
--- a/drivers/hid/amd-sfh-hid/hid_descriptor/amd_sfh_hid_report_desc.h
+++ b/drivers/hid/amd-sfh-hid/hid_descriptor/amd_sfh_hid_report_desc.h
@@ -179,7 +179,7 @@ static const u8 accel3_report_descriptor[] = {
0xC0 /* HID end collection */
};
-const u8 gyro3_report_descriptor[] = {
+static const u8 gyro3_report_descriptor[] = {
0x05, 0x20, /* Usage page */
0x09, 0x76, /* Motion type Gyro3D */
0xA1, 0x00, /* HID Collection (Physical) */
@@ -340,7 +340,7 @@ const u8 gyro3_report_descriptor[] = {
0xC0, /* HID end collection */
};
-const u8 comp3_report_descriptor[] = {
+static const u8 comp3_report_descriptor[] = {
0x05, 0x20, /* Usage page */
0x09, 0x83, /* Motion type Orientation compass 3D */
0xA1, 0x00, /* HID Collection (Physical) */
@@ -512,7 +512,7 @@ const u8 comp3_report_descriptor[] = {
0xC0 /* HID end collection */
};
-const u8 als_report_descriptor[] = {
+static const u8 als_report_descriptor[] = {
0x05, 0x20, /* HID usage page sensor */
0x09, 0x41, /* HID usage sensor type Ambientlight */
0xA1, 0x00, /* HID Collection (Physical) */
--
2.27.0
^ permalink raw reply [flat|nested] 3+ messages in thread* Re: [PATCH] HID: amd_sfh: change global variables to static
2022-04-20 14:22 [PATCH] HID: amd_sfh: change global variables to static Tom Rix
@ 2022-04-20 17:50 ` Basavaraj Natikar
2022-04-21 8:19 ` Jiri Kosina
1 sibling, 0 replies; 3+ messages in thread
From: Basavaraj Natikar @ 2022-04-20 17:50 UTC (permalink / raw)
To: Tom Rix, basavaraj.natikar, jikos, benjamin.tissoires,
nehal-bakulchandra.shah, Shyam-sundar.S-k
Cc: linux-input, linux-kernel
On 4/20/2022 7:52 PM, Tom Rix wrote:
> Smatch reports this representative issue
> amd_sfh_hid_report_desc.h:182:10: warning: symbol 'gyro3_report_descriptor' was not declared. Should it be static?
> Similar issues for comp3_report_descriptor and als_report_descriptor.
>
> Global variables should not be defined in header files.
> This only works because amd_sfh_hid_report_desc.h in only included by
> amd_sfh_hid_desc.c so change the storage-class specifiers to static.
>
> Signed-off-by: Tom Rix <trix@redhat.com>
> ---
> .../amd-sfh-hid/hid_descriptor/amd_sfh_hid_report_desc.h | 6 +++---
> 1 file changed, 3 insertions(+), 3 deletions(-)
>
> diff --git a/drivers/hid/amd-sfh-hid/hid_descriptor/amd_sfh_hid_report_desc.h b/drivers/hid/amd-sfh-hid/hid_descriptor/amd_sfh_hid_report_desc.h
> index b07dc4bbb858..7a2b4e434e4f 100644
> --- a/drivers/hid/amd-sfh-hid/hid_descriptor/amd_sfh_hid_report_desc.h
> +++ b/drivers/hid/amd-sfh-hid/hid_descriptor/amd_sfh_hid_report_desc.h
> @@ -179,7 +179,7 @@ static const u8 accel3_report_descriptor[] = {
> 0xC0 /* HID end collection */
> };
>
> -const u8 gyro3_report_descriptor[] = {
> +static const u8 gyro3_report_descriptor[] = {
> 0x05, 0x20, /* Usage page */
> 0x09, 0x76, /* Motion type Gyro3D */
> 0xA1, 0x00, /* HID Collection (Physical) */
> @@ -340,7 +340,7 @@ const u8 gyro3_report_descriptor[] = {
> 0xC0, /* HID end collection */
> };
>
> -const u8 comp3_report_descriptor[] = {
> +static const u8 comp3_report_descriptor[] = {
> 0x05, 0x20, /* Usage page */
> 0x09, 0x83, /* Motion type Orientation compass 3D */
> 0xA1, 0x00, /* HID Collection (Physical) */
> @@ -512,7 +512,7 @@ const u8 comp3_report_descriptor[] = {
> 0xC0 /* HID end collection */
> };
>
> -const u8 als_report_descriptor[] = {
> +static const u8 als_report_descriptor[] = {
> 0x05, 0x20, /* HID usage page sensor */
> 0x09, 0x41, /* HID usage sensor type Ambientlight */
> 0xA1, 0x00, /* HID Collection (Physical) */
Acked-by: Basavaraj Natikar <Basavaraj.Natikar@amd.com>
^ permalink raw reply [flat|nested] 3+ messages in thread* Re: [PATCH] HID: amd_sfh: change global variables to static
2022-04-20 14:22 [PATCH] HID: amd_sfh: change global variables to static Tom Rix
2022-04-20 17:50 ` Basavaraj Natikar
@ 2022-04-21 8:19 ` Jiri Kosina
1 sibling, 0 replies; 3+ messages in thread
From: Jiri Kosina @ 2022-04-21 8:19 UTC (permalink / raw)
To: Tom Rix
Cc: basavaraj.natikar, benjamin.tissoires, nehal-bakulchandra.shah,
Shyam-sundar.S-k, linux-input, linux-kernel
On Wed, 20 Apr 2022, Tom Rix wrote:
> Smatch reports this representative issue
> amd_sfh_hid_report_desc.h:182:10: warning: symbol 'gyro3_report_descriptor' was not declared. Should it be static?
> Similar issues for comp3_report_descriptor and als_report_descriptor.
>
> Global variables should not be defined in header files.
> This only works because amd_sfh_hid_report_desc.h in only included by
> amd_sfh_hid_desc.c so change the storage-class specifiers to static.
>
> Signed-off-by: Tom Rix <trix@redhat.com>
Applied, thanks Tom.
--
Jiri Kosina
SUSE Labs
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2022-04-21 8:19 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2022-04-20 14:22 [PATCH] HID: amd_sfh: change global variables to static Tom Rix
2022-04-20 17:50 ` Basavaraj Natikar
2022-04-21 8:19 ` Jiri Kosina
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®