From: "Nícolas F. R. A. Prado" <nfraprado@collabora.com>
To: Mark Brown <broonie@kernel.org>
Cc: kernel@collabora.com,
AngeloGioacchino Del Regno
<angelogioacchino.delregno@collabora.com>,
Chen-Yu Tsai <wenst@chromium.org>,
Jaroslav Kysela <perex@perex.cz>,
Liam Girdwood <lgirdwood@gmail.com>,
Matthias Brugger <matthias.bgg@gmail.com>,
Takashi Iwai <tiwai@suse.com>,
alsa-devel@alsa-project.org,
linux-arm-kernel@lists.infradead.org,
linux-kernel@vger.kernel.org, linux-mediatek@lists.infradead.org
Subject: Re: [PATCH] Revert "ASoC: mediatek: mt8192-mt6359: Remove " Jack" from Headphone pin name"
Date: Fri, 9 Jun 2023 09:08:47 -0400 [thread overview]
Message-ID: <ef54367a-a4f5-45af-aff1-08513c75c63c@notapiano> (raw)
In-Reply-To: <abe6e5f5-7373-44fc-90b6-2c01b1f1e96e@sirena.org.uk>
On Fri, Jun 09, 2023 at 10:39:25AM +0100, Mark Brown wrote:
> On Thu, Jun 08, 2023 at 06:10:48PM -0400, Nícolas F. R. A. Prado wrote:
> > This reverts commit cbbc0ec6dea09c815f1d1ef0abaf3f2ec89ff11f. That
> > commit removed the " Jack" suffix with the reasoning that it is
> > automatically added to the name of the kcontrol created, which is true,
>
> Please submit patches using subject lines reflecting the style for the
> subsystem, this makes it easier for people to identify relevant patches.
> Look at what existing commits in the area you're changing are doing and
> make sure your subject lines visually resemble what they're doing.
> There's no need to resubmit to fix this alone.
>
> Please include human readable descriptions of things like commits and
> issues being discussed in e-mail in your mails, this makes them much
> easier for humans to read especially when they have no internet access.
> I do frequently catch up on my mail on flights or while otherwise
> travelling so this is even more pressing for me than just being about
> making things a bit easier to read.
Hi Mark,
just for my own reference in the future, what exactly should have been done
differently in this commit? Are the subject line and commit reference in the
message generated by 'git revert' no good? Or is this message from a bot that
can't handle revert commits?
Thanks,
Nícolas
next prev parent reply other threads:[~2023-06-09 13:09 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-06-08 22:10 Nícolas F. R. A. Prado
2023-06-09 7:37 ` AngeloGioacchino Del Regno
2023-06-09 9:39 ` Mark Brown
2023-06-09 9:39 ` Mark Brown
2023-06-09 13:08 ` Nícolas F. R. A. Prado [this message]
2023-06-09 13:13 ` Mark Brown
2023-06-09 12:03 ` Mark Brown
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ef54367a-a4f5-45af-aff1-08513c75c63c@notapiano \
--to=nfraprado@collabora.com \
--cc=alsa-devel@alsa-project.org \
--cc=angelogioacchino.delregno@collabora.com \
--cc=broonie@kernel.org \
--cc=kernel@collabora.com \
--cc=lgirdwood@gmail.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mediatek@lists.infradead.org \
--cc=matthias.bgg@gmail.com \
--cc=perex@perex.cz \
--cc=tiwai@suse.com \
--cc=wenst@chromium.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®