mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Patrice CHOTARD <patrice.chotard@foss.st.com>
To: Krzysztof Kozlowski <krzk@kernel.org>
Cc: Rob Herring <robh@kernel.org>,
	Krzysztof Kozlowski <krzk+dt@kernel.org>,
	Conor Dooley <conor+dt@kernel.org>,
	Maxime Coquelin <mcoquelin.stm32@gmail.com>,
	Alexandre Torgue <alexandre.torgue@foss.st.com>,
	Christophe Roullier <christophe.roullier@foss.st.com>,
	Srinivas Kandagatla <srini@kernel.org>,
	Simeon Marijon <simeon.marijon@foss.st.com>,
	<linux-stm32@st-md-mailman.stormreply.com>,
	<devicetree@vger.kernel.org>,
	<linux-arm-kernel@lists.infradead.org>,
	<linux-kernel@vger.kernel.org>
Subject: Re: [PATCH v3 2/3] dt-bindings: arm: stm32: allow TAMP nvram child node for syscon
Date: Wed, 4 Nov 2026 14:43:16 +0100	[thread overview]
Message-ID: <ef5bfb63-4e57-49e0-a1aa-81b5de14a36f@foss.st.com> (raw)
In-Reply-To: <20261017-valiant-exotic-heron-c0b6e8@quoll>



On 10/17/26 19:52, Krzysztof Kozlowski wrote:
> On Fri, Oct 16, 2026 at 05:26:04PM +0200, Patrice Chotard wrote:
>> The STM32 TAMP node (compatible "st,stm32-tamp", "syscon", "simple-mfd")
>> exposes its backup registers through an nvram child node described by
>> nvmem/st,stm32-tamp-nvram.yaml. That requires the TAMP node to carry
>> "#address-cells", "#size-cells", "ranges" and an "nvram@..." child.
>>
>> st,stm32-syscon.yaml uses "additionalProperties: false" and only allowed
>> reg/clocks/#clock-cells, so wiring the nvram provider into the DTSI made
>> "make dtbs_check" fail on every STM32MP TAMP node:
>>
>>   tamp@5c00a000 (st,stm32-tamp): '#address-cells', '#size-cells',
>>   'nvram@5c00a100', 'ranges' do not match any of the regexes:
>>   '^pinctrl-[0-9]+$'
> 
> There are no children of tamp@5c00a000 in
> arch/arm/boot/dts/st/stm32mp151.dtsi. How is it possible to reproduce
> this warning?
> 
> Are you using some other patches bugs as a reason of change in bindings?

Hi Krzysztof

yes, in this patch [1] arch/arm/boot/dts/st/stm32mp151.dtsi is updated
that's why bindings need this change.

See the complete series [2]. 

[1] https://patchwork.kernel.org/project/linux-arm-kernel/patch/20260930-upstream_tamp_nvram_dts_part-v2-2-bd73158ce46b@foss.st.com/
[2] https://patchwork.kernel.org/series/1176665/
> 
>>
>> Allow the addressing properties and the nvram child, gated on the
>> st,stm32-tamp compatible so the other syscon variants stay strict.
>> "#size-cells" may be 1 or 2: the STM32MP21 soc bus uses two size cells
>> (an empty "ranges" requires the node to match its parent) while the
>> other STM32MP SoCs use one.
>>
>> Signed-off-by: Patrice Chotard <patrice.chotard@foss.st.com>
>> ---
>>  .../bindings/arm/stm32/st,stm32-syscon.yaml        | 30 ++++++++++++++++++++++
>>  1 file changed, 30 insertions(+)
>>
>> diff --git a/Documentation/devicetree/bindings/arm/stm32/st,stm32-syscon.yaml b/Documentation/devicetree/bindings/arm/stm32/st,stm32-syscon.yaml
>> index 95d2319afe23..1aeb54867db2 100644
>> --- a/Documentation/devicetree/bindings/arm/stm32/st,stm32-syscon.yaml
>> +++ b/Documentation/devicetree/bindings/arm/stm32/st,stm32-syscon.yaml
>> @@ -39,6 +39,23 @@ properties:
>>    "#clock-cells":
>>      const: 0
>>  
>> +  "#address-cells":
>> +    const: 1
>> +
>> +  "#size-cells":
>> +    enum: [1, 2]
>> +
>> +  ranges: true
> 
> You work on some weeks old tree.

Indeed, this series need to be rebased on top of v7.4-rc1

Thanks
Patrice

> 
>> +
>> +patternProperties:
>> +  "^nvram@[0-9a-f]+$":
>> +    type: object
> 
> additionalProperties true with ref or false with a compatible, just like
> every other binding. See also display/msm for some examples.
> 
>> +    description:
>> +      TAMP backup registers exposed as an NVMEM provider. See
>> +      nvmem/st,stm32-tamp-nvram.yaml.
>> +    required:
>> +      - compatible
> 
> Best regards,
> Krzysztof
> 


  reply	other threads:[~2026-11-04 13:43 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-10-16 15:26 [PATCH v3 0/3] Add STM32 TAMP nvram driver support Patrice Chotard
2026-10-16 15:26 ` [PATCH v3 1/3] dt-bindings: nvmem: add STM32MPX TAMP backup registers Patrice Chotard
2026-10-16 15:26 ` [PATCH v3 2/3] dt-bindings: arm: stm32: allow TAMP nvram child node for syscon Patrice Chotard
2026-10-17 17:52   ` Krzysztof Kozlowski
2026-11-04 13:43     ` Patrice CHOTARD [this message]
2026-10-16 15:26 ` [PATCH v3 3/3] nvmem: stm32: add TAMP nvmem driver Patrice Chotard
2026-10-17 17:57   ` Krzysztof Kozlowski
2026-11-04 13:43     ` Patrice CHOTARD

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=ef5bfb63-4e57-49e0-a1aa-81b5de14a36f@foss.st.com \
    --to=patrice.chotard@foss.st.com \
    --cc=alexandre.torgue@foss.st.com \
    --cc=christophe.roullier@foss.st.com \
    --cc=conor+dt@kernel.org \
    --cc=devicetree@vger.kernel.org \
    --cc=krzk+dt@kernel.org \
    --cc=krzk@kernel.org \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-stm32@st-md-mailman.stormreply.com \
    --cc=mcoquelin.stm32@gmail.com \
    --cc=robh@kernel.org \
    --cc=simeon.marijon@foss.st.com \
    --cc=srini@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®