From: Dmitry Osipenko <dmitry.osipenko@collabora.com>
To: Erico Nunes <nunes.erico@gmail.com>, Steven Price <steven.price@arm.com>
Cc: David Airlie <airlied@linux.ie>, Daniel Vetter <daniel@ffwll.ch>,
Tomeu Vizoso <tomeu.vizoso@collabora.com>,
Rob Herring <robh@kernel.org>,
Alyssa Rosenzweig <alyssa.rosenzweig@collabora.com>,
Rob Clark <robdclark@gmail.com>,
Andrey Grodzovsky <andrey.grodzovsky@amd.com>,
Dmitry Osipenko <digetx@gmail.com>,
linux-kernel <linux-kernel@vger.kernel.org>,
dri-devel <dri-devel@lists.freedesktop.org>
Subject: Re: [PATCH v1] drm/scheduler: Don't kill jobs in interrupt context
Date: Tue, 17 May 2022 12:03:39 +0300 [thread overview]
Message-ID: <ef88ec2c-77b5-fa0d-49d1-fdd2451713b7@collabora.com> (raw)
In-Reply-To: <CAK4VdL2hCEoshWZbCh5mkHuS6wYMiPFR3v4MWTnrEKM9zyv6Mw@mail.gmail.com>
On 5/17/22 10:40, Erico Nunes wrote:
> On Wed, Apr 13, 2022 at 12:05 PM Steven Price <steven.price@arm.com> wrote:
>>
>> On 11/04/2022 23:15, Dmitry Osipenko wrote:
>>> Interrupt context can't sleep. Drivers like Panfrost and MSM are taking
>>> mutex when job is released, and thus, that code can sleep. This results
>>> into "BUG: scheduling while atomic" if locks are contented while job is
>>> freed. There is no good reason for releasing scheduler's jobs in IRQ
>>> context, hence use normal context to fix the trouble.
>>>
>>> Cc: stable@vger.kernel.org
>>> Fixes: 542cff7893a3 ("drm/sched: Avoid lockdep spalt on killing a processes")
>>> Signed-off-by: Dmitry Osipenko <dmitry.osipenko@collabora.com>
>>
>> Reviewed-by: Steven Price <steven.price@arm.com>
>
> Is there something blocking this patch?
> Mesa CI is still hitting the issue and I have been waiting for it to
> be applied/backported to update CI with it.
> Thanks
If this patch won't be picked up anytime soon, then I'll include it into
my "memory shrinker" patchset together with the rest of the fixes, so it
won't get lost.
--
Best regards,
Dmitry
next prev parent reply other threads:[~2022-05-17 9:03 UTC|newest]
Thread overview: 27+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-04-11 22:15 Dmitry Osipenko
2022-04-12 16:51 ` Andrey Grodzovsky
2022-04-12 18:20 ` Dmitry Osipenko
2022-04-12 19:40 ` Andrey Grodzovsky
2022-04-12 19:55 ` Dmitry Osipenko
2022-04-12 22:59 ` Erico Nunes
2022-04-13 6:05 ` Dmitry Osipenko
2022-04-13 9:45 ` Erico Nunes
2022-04-13 10:04 ` Steven Price
2022-05-17 7:40 ` Erico Nunes
2022-05-17 9:03 ` Dmitry Osipenko [this message]
2022-05-17 14:03 ` Andrey Grodzovsky
2022-05-17 14:13 ` Andrey Grodzovsky
2022-05-17 14:48 ` Dmitry Osipenko
2022-07-06 7:07 ` Dmitry Osipenko
2022-07-06 13:49 ` Andrey Grodzovsky
2022-07-06 14:57 ` Dmitry Osipenko
2022-07-06 15:46 ` Alex Deucher
2022-07-12 8:56 ` Dmitry Osipenko
2022-07-14 9:57 ` Dmitry Osipenko
2022-07-14 14:14 ` Andrey Grodzovsky
2022-07-14 14:23 ` Dmitry Osipenko
2022-07-14 16:22 ` Alex Deucher
2022-07-14 17:58 ` Andrey Grodzovsky
2022-07-14 21:16 ` Alex Deucher
2022-07-15 15:18 ` Andrey Grodzovsky
2022-07-15 15:24 ` Dmitry Osipenko
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ef88ec2c-77b5-fa0d-49d1-fdd2451713b7@collabora.com \
--to=dmitry.osipenko@collabora.com \
--cc=airlied@linux.ie \
--cc=alyssa.rosenzweig@collabora.com \
--cc=andrey.grodzovsky@amd.com \
--cc=daniel@ffwll.ch \
--cc=digetx@gmail.com \
--cc=dri-devel@lists.freedesktop.org \
--cc=linux-kernel@vger.kernel.org \
--cc=nunes.erico@gmail.com \
--cc=robdclark@gmail.com \
--cc=robh@kernel.org \
--cc=steven.price@arm.com \
--cc=tomeu.vizoso@collabora.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®