From: Siddharth Vadapalli <s-vadapalli@ti.com>
To: "Kumar, Udit" <u-kumar1@ti.com>
Cc: Parth Pancholi <parth105105@gmail.com>,
Nishanth Menon <nm@ti.com>, Vignesh Raghavendra <vigneshr@ti.com>,
Tero Kristo <kristo@kernel.org>, Rob Herring <robh@kernel.org>,
Krzysztof Kozlowski <krzk+dt@kernel.org>,
Conor Dooley <conor+dt@kernel.org>,
Siddharth Vadapalli <s-vadapalli@ti.com>,
Parth Pancholi <parth.pancholi@toradex.com>,
<linux-arm-kernel@lists.infradead.org>,
<devicetree@vger.kernel.org>, <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH v2] arm64: dts: ti: k3-j784s4-main: Enable ACSPCIE outputs for PCIe interfaces
Date: Sun, 20 Apr 2025 08:25:22 +0530 [thread overview]
Message-ID: <eff95b10-f20e-4abc-b519-36fd80843954@ti.com> (raw)
In-Reply-To: <7da470c6-5426-48bf-838a-bc7a5b5dc5db@ti.com>
On Sat, Apr 19, 2025 at 06:38:00PM +0530, Kumar, Udit wrote:
> Thanks for patch, Parth
>
> On 4/4/2025 3:42 PM, Parth Pancholi wrote:
Hello Parth,
> > From: Parth Pancholi <parth.pancholi@toradex.com>
> >
> > TI J784S4-based devices, such as the AM69 SoC, provide PCIE_REFCLK outputs
> > from the SoC, which can be used to clock external PCIe endpoint devices.
> > Each PCIE_REFCLK output is enabled via the corresponding ACSPCIE clock
> > buffer, with each buffer supporting two PADs to provide reference clocks
> > for two associated PCIe instances. The mappings are as follows:
> > - PCIe0 -> ACSPCIE1 PAD0
> > - PCIe1 -> ACSPCIE0 PAD0
> > - PCIe2 -> ACSPCIE1 PAD1
> > - PCIe3 -> ACSPCIE0 PAD1
> >
> > This patch enables each ACSPCIE module and its corresponding PADs to ensure
> > that all PCIE_REFCLK outputs are functional.
> >
> > This change have been tested on an AM69-based custom hardware platform,
> > where all four PCIe instances (PCIe0, PCIe1, PCIe2, and PCIe3) with the
> > internal PCIE_REFCLK are utilized with various endpoint devices such as
> > a WiFi card, NVMe SSD, and PCIe-to-USB bridge.
>
> You can enabling REFCLK to be out as default.
>
> There are few boards, on which this clock is either terminated at test point
> or not connected at all
>
> Example AM69 board
>
> PCIE_REFCLK2_P_OUT is not connected and PCIE_REFCLK0_P_OUT is terminated at
> test points.
>
>
> IMO, this clock to be enabled where this can be connected to PCIe EP.
>
> Let Siddharth also share his comment, where to enable these clocks board
> file or SOC file.
As Udit has pointed out, the reference clock outputs from ACSPCIE
buffers should be enabled in the board files. I will be updating the
patch that I had posted for enabling output of ACSPCIE0 PAD0 for PCIe1
by moving the changes to the board file
k3-j784s4-j742s2-evm-common.dtsi
Please update your patch accordingly. The overrides will no longer be
required as the property will be defined in the board file itself for
AM69.
Regards,
Siddharth.
next prev parent reply other threads:[~2025-04-20 2:55 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-04-04 10:12 Parth Pancholi
2025-04-19 13:08 ` Kumar, Udit
2025-04-20 2:55 ` Siddharth Vadapalli [this message]
2025-04-22 12:38 ` Siddharth Vadapalli
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=eff95b10-f20e-4abc-b519-36fd80843954@ti.com \
--to=s-vadapalli@ti.com \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=kristo@kernel.org \
--cc=krzk+dt@kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=nm@ti.com \
--cc=parth.pancholi@toradex.com \
--cc=parth105105@gmail.com \
--cc=robh@kernel.org \
--cc=u-kumar1@ti.com \
--cc=vigneshr@ti.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®