mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: "Kumar, Udit" <u-kumar1@ti.com>
To: Parth Pancholi <parth105105@gmail.com>,
	Nishanth Menon <nm@ti.com>, Vignesh Raghavendra <vigneshr@ti.com>,
	Tero Kristo <kristo@kernel.org>, Rob Herring <robh@kernel.org>,
	Krzysztof Kozlowski <krzk+dt@kernel.org>,
	Conor Dooley <conor+dt@kernel.org>,
	Siddharth Vadapalli <s-vadapalli@ti.com>
Cc: Parth Pancholi <parth.pancholi@toradex.com>,
	<linux-arm-kernel@lists.infradead.org>,
	<devicetree@vger.kernel.org>, <linux-kernel@vger.kernel.org>,
	<u-kumar1@ti.com>
Subject: Re: [PATCH v2] arm64: dts: ti: k3-j784s4-main: Enable ACSPCIE outputs for PCIe interfaces
Date: Sat, 19 Apr 2025 18:38:00 +0530	[thread overview]
Message-ID: <7da470c6-5426-48bf-838a-bc7a5b5dc5db@ti.com> (raw)
In-Reply-To: <20250404101234.2671147-1-parth105105@gmail.com>

Thanks for patch, Parth

On 4/4/2025 3:42 PM, Parth Pancholi wrote:
> From: Parth Pancholi <parth.pancholi@toradex.com>
>
> TI J784S4-based devices, such as the AM69 SoC, provide PCIE_REFCLK outputs
> from the SoC, which can be used to clock external PCIe endpoint devices.
> Each PCIE_REFCLK output is enabled via the corresponding ACSPCIE clock
> buffer, with each buffer supporting two PADs to provide reference clocks
> for two associated PCIe instances. The mappings are as follows:
>          - PCIe0 -> ACSPCIE1 PAD0
>          - PCIe1 -> ACSPCIE0 PAD0
>          - PCIe2 -> ACSPCIE1 PAD1
>          - PCIe3 -> ACSPCIE0 PAD1
>
> This patch enables each ACSPCIE module and its corresponding PADs to ensure
> that all PCIE_REFCLK outputs are functional.
>
> This change have been tested on an AM69-based custom hardware platform,
> where all four PCIe instances (PCIe0, PCIe1, PCIe2, and PCIe3) with the
> internal PCIE_REFCLK are utilized with various endpoint devices such as
> a WiFi card, NVMe SSD, and PCIe-to-USB bridge.

You can enabling REFCLK to be out as default.

There are few boards, on which this clock is either terminated at test 
point or not connected at all

Example AM69 board

PCIE_REFCLK2_P_OUT is not connected and PCIE_REFCLK0_P_OUT is terminated 
at test points.


IMO, this clock to be enabled where this can be connected to PCIe EP.

Let Siddharth also share his comment, where to enable these clocks board 
file or SOC file.

Regards

Udit

> Link: https://e2e.ti.com/support/processors-group/processors/f/processors-forum/1484211/am69-pcie-refclk-out-and-acspcie-mappings
> Signed-off-by: Parth Pancholi <parth.pancholi@toradex.com>
> ---
> This change depends on https://lore.kernel.org/all/20241209085157.1203168-1-s-vadapalli@ti.com/
> v2: set ti,syscon-acspcie-proxy-ctrl mask to 0x3 for all PCIe instances to prevent unintended overrides.
> v1: https://lore.kernel.org/all/20250320122259.525613-1-parth105105@gmail.com/
> ---
>   .../boot/dts/ti/k3-j784s4-j742s2-main-common.dtsi    | 12 +++++++++---
>   arch/arm64/boot/dts/ti/k3-j784s4-main.dtsi           | 10 ++++++----
>   2 files changed, 15 insertions(+), 7 deletions(-)
> [..]

  reply	other threads:[~2025-04-19 13:08 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-04-04 10:12 Parth Pancholi
2025-04-19 13:08 ` Kumar, Udit [this message]
2025-04-20  2:55   ` Siddharth Vadapalli
2025-04-22 12:38     ` Siddharth Vadapalli

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=7da470c6-5426-48bf-838a-bc7a5b5dc5db@ti.com \
    --to=u-kumar1@ti.com \
    --cc=conor+dt@kernel.org \
    --cc=devicetree@vger.kernel.org \
    --cc=kristo@kernel.org \
    --cc=krzk+dt@kernel.org \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=nm@ti.com \
    --cc=parth.pancholi@toradex.com \
    --cc=parth105105@gmail.com \
    --cc=robh@kernel.org \
    --cc=s-vadapalli@ti.com \
    --cc=vigneshr@ti.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®