mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: "Agrawal, Akshu" <aagrawal2@amd.com>
To: Mark Brown <broonie@kernel.org>, Akshu Agrawal <akshu.agrawal@amd.com>
Cc: yuhsuan@chromium.org, Liam Girdwood <lgirdwood@gmail.com>,
	Jaroslav Kysela <perex@perex.cz>, Takashi Iwai <tiwai@suse.com>,
	YueHaibing <yuehaibing@huawei.com>,
	Kuninori Morimoto <kuninori.morimoto.gx@renesas.com>,
	"moderated list:SOUND - SOC LAYER / DYNAMIC AUDIO POWER
	MANAGEM..."  <alsa-devel@alsa-project.org>,
	open list <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] ASoC: AMD: Use mixer control to switch between DMICs
Date: Thu, 28 May 2020 10:43:25 +0530	[thread overview]
Message-ID: <f0087d94-c81d-3dc0-9b6d-473795a89918@amd.com> (raw)
In-Reply-To: <20200527112758.GE5308@sirena.org.uk>


On 5/27/2020 4:57 PM, Mark Brown wrote:
> On Wed, May 27, 2020 at 07:10:16AM +0530, Akshu Agrawal wrote:
>
>> +	SOC_SINGLE_BOOL_EXT("Front Mic", 0, front_mic_get, front_mic_set),
> This should probably be a mux with two labelled options, or if it's a
> boolean control it should end in Switch.  A mux definitely seems like a
> better option though.

Actually it's a dmic switch, so will change it to boolean control named 
"DMIC switch". Front or rear mic might change with variants.

Thanks,

Akshu


      reply	other threads:[~2020-05-28  5:16 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-05-27  1:40 Akshu Agrawal
2020-05-27 11:27 ` Mark Brown
2020-05-28  5:13   ` Agrawal, Akshu [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=f0087d94-c81d-3dc0-9b6d-473795a89918@amd.com \
    --to=aagrawal2@amd.com \
    --cc=akshu.agrawal@amd.com \
    --cc=alsa-devel@alsa-project.org \
    --cc=broonie@kernel.org \
    --cc=kuninori.morimoto.gx@renesas.com \
    --cc=lgirdwood@gmail.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=perex@perex.cz \
    --cc=tiwai@suse.com \
    --cc=yuehaibing@huawei.com \
    --cc=yuhsuan@chromium.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®