* [PATCH] dt-bindings: i3c: dw: Document missing optional core reset
@ 2026-07-17 10:58 Shubham Patil
2026-07-17 11:33 ` Krzysztof Kozlowski
0 siblings, 1 reply; 2+ messages in thread
From: Shubham Patil @ 2026-07-17 10:58 UTC (permalink / raw)
To: alexandre.belloni, Frank.Li, robh, krzk+dt, conor+dt
Cc: linux-i3c, devicetree, linux-kernel, radhey.shyam.pandey,
michal.simek, Shubham Patil
The DesignWare I3C master IP supports a core reset input, but the
binding is missing the corresponding reset description.
Document the reset property and name in the binding. Keep the reset
optional because the reset line is integration-specific..
Signed-off-by: Shubham Patil <shubhamsanjay.patil@amd.com>
---
Note:
The DesignWare I3C driver support was added by
1dd728f5d4d4 ("i3c: master: Add driver for Synopsys DesignWare IP").
The original Synopsys DesignWare I3C binding was added by
116e246a8bcd ("dt-binding: i3c: Document Synopsys DesignWare I3C"),
but it did not document the optional core reset.
---
.../devicetree/bindings/i3c/snps,dw-i3c-master.yaml | 6 ++++++
1 file changed, 6 insertions(+)
diff --git a/Documentation/devicetree/bindings/i3c/snps,dw-i3c-master.yaml b/Documentation/devicetree/bindings/i3c/snps,dw-i3c-master.yaml
index e803457d3f55..822faf8d221b 100644
--- a/Documentation/devicetree/bindings/i3c/snps,dw-i3c-master.yaml
+++ b/Documentation/devicetree/bindings/i3c/snps,dw-i3c-master.yaml
@@ -38,6 +38,12 @@ properties:
interrupts:
maxItems: 1
+ resets:
+ maxItems: 1
+
+ reset-names:
+ const: core_rst
+
power-domains:
maxItems: 1
base-commit: a13c140cc289c0b7b3770bce5b3ad42ab35074aa
--
2.49.1
^ permalink raw reply [flat|nested] 2+ messages in thread
* Re: [PATCH] dt-bindings: i3c: dw: Document missing optional core reset
2026-07-17 10:58 [PATCH] dt-bindings: i3c: dw: Document missing optional core reset Shubham Patil
@ 2026-07-17 11:33 ` Krzysztof Kozlowski
0 siblings, 0 replies; 2+ messages in thread
From: Krzysztof Kozlowski @ 2026-07-17 11:33 UTC (permalink / raw)
To: Shubham Patil, alexandre.belloni, Frank.Li, robh, krzk+dt, conor+dt
Cc: linux-i3c, devicetree, linux-kernel, radhey.shyam.pandey, michal.simek
On 17/07/2026 12:58, Shubham Patil wrote:
> The DesignWare I3C master IP supports a core reset input, but the
> binding is missing the corresponding reset description.
>
> Document the reset property and name in the binding. Keep the reset
> optional because the reset line is integration-specific..
>
> Signed-off-by: Shubham Patil <shubhamsanjay.patil@amd.com>
> ---
> Note:
> The DesignWare I3C driver support was added by
> 1dd728f5d4d4 ("i3c: master: Add driver for Synopsys DesignWare IP").
>
> The original Synopsys DesignWare I3C binding was added by
> 116e246a8bcd ("dt-binding: i3c: Document Synopsys DesignWare I3C"),
> but it did not document the optional core reset.
> ---
> .../devicetree/bindings/i3c/snps,dw-i3c-master.yaml | 6 ++++++
> 1 file changed, 6 insertions(+)
>
> diff --git a/Documentation/devicetree/bindings/i3c/snps,dw-i3c-master.yaml b/Documentation/devicetree/bindings/i3c/snps,dw-i3c-master.yaml
> index e803457d3f55..822faf8d221b 100644
> --- a/Documentation/devicetree/bindings/i3c/snps,dw-i3c-master.yaml
> +++ b/Documentation/devicetree/bindings/i3c/snps,dw-i3c-master.yaml
> @@ -38,6 +38,12 @@ properties:
> interrupts:
> maxItems: 1
>
> + resets:
> + maxItems: 1
> +
> + reset-names:
> + const: core_rst
Drop the names, pretty redundant, and fix the driver. Sneaking ABI is a
poor excuse, IMO, to keep discouraged names.
Best regards,
Krzysztof
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2026-07-17 11:33 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2026-07-17 10:58 [PATCH] dt-bindings: i3c: dw: Document missing optional core reset Shubham Patil
2026-07-17 11:33 ` Krzysztof Kozlowski
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome